From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFAEC433DF for ; Sat, 18 Jul 2020 15:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 805622076A for ; Sat, 18 Jul 2020 15:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084601; bh=cUkYggOnauCffTTOaCBMD+Umyy7fk+m3swMQxVSA0Mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=uMG8nIZa7xVnZNQug/vPyuuQqahxytp8cdUpScSyAB6mOfU9Y5vAs04Mt6nB90Z4c g1NUIyYyqppq2iBZHmruTBWd3iTtXznXXNQy3oE2npmiBQlLGzqsvELAR8w7FiC8GR GZUEyP/YV4lp5hx0n5w303c4QTxVcI0UTN9LJXnM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726742AbgGRPDU (ORCPT ); Sat, 18 Jul 2020 11:03:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:35736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPDU (ORCPT ); Sat, 18 Jul 2020 11:03:20 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DC632065D; Sat, 18 Jul 2020 15:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084599; bh=cUkYggOnauCffTTOaCBMD+Umyy7fk+m3swMQxVSA0Mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tytHDbm3fzPIsRCWGphtMFPCa5v9OlxaZxsVuxBcDBjNE5Eh3kuMblQYuh3NRCNv+ CT4mvLB/OpkEXYmnFLkqddIXoYFz43Y23gmB//UnyCMmkRkwZfRL7GBYPDquExkm+f GkbWe6k3wAeQeRtFeGT0iLCb4aBGarmPJ5Fgttmg= Date: Sat, 18 Jul 2020 16:03:14 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Charles-Antoine Couret Subject: Re: [PATCH 17/30] iio: adc: ad7949: Fix misspelling issue and compiler attribute ordering Message-ID: <20200718160314.69fc73dd@archlinux> In-Reply-To: <20200716135928.1456727-18-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-18-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:15 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member 'indio_dev' not described in 'ad7949_adc_chip' > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7949_adc_chip' Holding this one pending discussion of whether to add ___cacheline_aligned to the stuff kernel-doc effectively skips when processing structures. Jonathan > > Cc: Michael Hennerich > Cc: Charles-Antoine Couret > Signed-off-by: Lee Jones > --- > drivers/iio/adc/ad7949.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c > index 2c6f60edb7ced..a3fc42617feb9 100644 > --- a/drivers/iio/adc/ad7949.c > +++ b/drivers/iio/adc/ad7949.c > @@ -39,7 +39,7 @@ static const struct ad7949_adc_spec ad7949_adc_spec[] = { > * struct ad7949_adc_chip - AD ADC chip > * @lock: protects write sequences > * @vref: regulator generating Vref > - * @iio_dev: reference to iio structure > + * @indio_dev: reference to iio structure > * @spi: reference to spi structure > * @resolution: resolution of the chip > * @cfg: copy of the configuration register > @@ -54,7 +54,7 @@ struct ad7949_adc_chip { > u8 resolution; > u16 cfg; > unsigned int current_channel; > - u16 buffer ____cacheline_aligned; > + u16 ____cacheline_aligned buffer; > }; > > static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AA0C433E2 for ; Sat, 18 Jul 2020 15:04:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9390B2065D for ; Sat, 18 Jul 2020 15:04:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="itgfm9D6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tytHDbm3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9390B2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hn0UhERrE/5TTHUgCfG71EDlVdDJagusFF5ArB+1D0c=; b=itgfm9D6UF6oxAtpdBJa+DqSA +9os8lfbCKv8gZzkPzCx6Og7ErII8sAV8TtepaONEBbLOwQRIFYug0oVe1FgnfE2ooJSah85SVKRZ 3dV2yFBVMvEtAgbHX+9yhmAcAz1umXu0lLDRopN5ol9MNjhuSiMqtzuihdmRy3XwHCUMwRwwQFv5J pQCvI1248ME/P0qJ/ZY2HwcER+ZlUN/gTzHN+/h227PxM/s6fxfGAzjUxAtfey3FQcZ5MWTDntfRR aaI3tiJtXHjQKKJbtoYAaMp+RcHChaZ6jYB6P+UzZgB5hGYWdljUCszYcuy2f+18WSJYvYnnLL2FE d6Yu08zVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoN1-0007OP-1o; Sat, 18 Jul 2020 15:03:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoMy-0007NQ-FL for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:03:21 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DC632065D; Sat, 18 Jul 2020 15:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084599; bh=cUkYggOnauCffTTOaCBMD+Umyy7fk+m3swMQxVSA0Mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tytHDbm3fzPIsRCWGphtMFPCa5v9OlxaZxsVuxBcDBjNE5Eh3kuMblQYuh3NRCNv+ CT4mvLB/OpkEXYmnFLkqddIXoYFz43Y23gmB//UnyCMmkRkwZfRL7GBYPDquExkm+f GkbWe6k3wAeQeRtFeGT0iLCb4aBGarmPJ5Fgttmg= Date: Sat, 18 Jul 2020 16:03:14 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 17/30] iio: adc: ad7949: Fix misspelling issue and compiler attribute ordering Message-ID: <20200718160314.69fc73dd@archlinux> In-Reply-To: <20200716135928.1456727-18-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-18-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_110320_600221_B5D5FBCA X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Charles-Antoine Couret , lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:15 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member 'indio_dev' not described in 'ad7949_adc_chip' > drivers/iio/adc/ad7949.c:58: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7949_adc_chip' Holding this one pending discussion of whether to add ___cacheline_aligned to the stuff kernel-doc effectively skips when processing structures. Jonathan > > Cc: Michael Hennerich > Cc: Charles-Antoine Couret > Signed-off-by: Lee Jones > --- > drivers/iio/adc/ad7949.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c > index 2c6f60edb7ced..a3fc42617feb9 100644 > --- a/drivers/iio/adc/ad7949.c > +++ b/drivers/iio/adc/ad7949.c > @@ -39,7 +39,7 @@ static const struct ad7949_adc_spec ad7949_adc_spec[] = { > * struct ad7949_adc_chip - AD ADC chip > * @lock: protects write sequences > * @vref: regulator generating Vref > - * @iio_dev: reference to iio structure > + * @indio_dev: reference to iio structure > * @spi: reference to spi structure > * @resolution: resolution of the chip > * @cfg: copy of the configuration register > @@ -54,7 +54,7 @@ struct ad7949_adc_chip { > u8 resolution; > u16 cfg; > unsigned int current_channel; > - u16 buffer ____cacheline_aligned; > + u16 ____cacheline_aligned buffer; > }; > > static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel