From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91E7C433DF for ; Sat, 18 Jul 2020 15:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7B9120775 for ; Sat, 18 Jul 2020 15:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084700; bh=AAZPwQTU94R3L/QF22yxuFg1zBYZopItzGUsuLf8eIc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=enILY60LnmUM136ESujyHT3A49BxybGNXDwVvgnI6/4y9STVOHaGij4PBGEpDy3s7 9FRG+tljAiZrmgsSgF7YNkcu80AIbXjeEvN6UcjQLHGCndmnNaWFgc+yEeC+Vf5qb0 pikjl3/eo2nIyvgNdOpN7FGnmbs6UfEX7KvOnBe8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727114AbgGRPE7 (ORCPT ); Sat, 18 Jul 2020 11:04:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgGRPE7 (ORCPT ); Sat, 18 Jul 2020 11:04:59 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D68612065D; Sat, 18 Jul 2020 15:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084698; bh=AAZPwQTU94R3L/QF22yxuFg1zBYZopItzGUsuLf8eIc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CaZ/g7ubXGxlkcOaOs2tbnOSLM7dFTYTLf3ULk6VCUl90SMLCaGPuqa82Vm9+fJXM HJB9aH6Cv1FZHDh/uFGPS4No6pcsHVJJr8RQry71bi8qsEXNpfjrPUXufP7z/seQlP trpFIqyQGby3AhH6yrjZRtGUL08DTYf0D6TLi2HE= Date: Sat, 18 Jul 2020 16:04:54 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Liam Girdwood , Mark Brown Subject: Re: [PATCH 19/30] iio: dac: ad5064: Fix a few kerneldoc misdemeanours Message-ID: <20200718160454.1a722eea@archlinux> In-Reply-To: <20200716135928.1456727-20-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-20-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:17 +0100 Lee Jones wrote: > Misspelling, missing description and compiler attribute ordering. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5064.c:71: warning: bad line: internal vref. > drivers/iio/dac/ad5064.c:83: warning: Function parameter or member 'channels' not described in 'ad5064_chip_info' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member 'lock' not described in 'ad5064_state' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member '____cacheline_aligned' not described in 'ad5064_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Holding this one for that discussion around kernel-doc handing of ___cacheline_aligned Jonathan > --- > drivers/iio/dac/ad5064.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c > index 303f6d1a5f311..d7109f8f52efa 100644 > --- a/drivers/iio/dac/ad5064.c > +++ b/drivers/iio/dac/ad5064.c > @@ -68,8 +68,8 @@ enum ad5064_regmap_type { > * struct ad5064_chip_info - chip specific information > * @shared_vref: whether the vref supply is shared between channels > * @internal_vref: internal reference voltage. 0 if the chip has no > - internal vref. > - * @channel: channel specification > + * internal vref. > + * @channels: channel specification > * @num_channels: number of channels > * @regmap_type: register map layout variant > */ > @@ -98,6 +98,7 @@ typedef int (*ad5064_write_func)(struct ad5064_state *st, unsigned int cmd, > * @use_internal_vref: set to true if the internal reference voltage should be > * used. > * @write: register write callback > + * @lock: maintain consistency between cached and dev state > * @data: i2c/spi transfer buffers > */ > > @@ -111,7 +112,6 @@ struct ad5064_state { > bool use_internal_vref; > > ad5064_write_func write; > - /* Lock used to maintain consistency between cached and dev state */ > struct mutex lock; > > /* > @@ -121,7 +121,7 @@ struct ad5064_state { > union { > u8 i2c[3]; > __be32 spi; > - } data ____cacheline_aligned; > + } ____cacheline_aligned data; > }; > > enum ad5064_type { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B55C433E4 for ; Sat, 18 Jul 2020 15:06:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 747992067D for ; Sat, 18 Jul 2020 15:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sqpwzyd4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CaZ/g7ub" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 747992067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YfzJFb0h5+vvxooFcjKOV4WR9WBgUSeD085/cgIg334=; b=Sqpwzyd4wqdmvL+de6THn56s3 npAGgP89Erj+GfBZdTjgxo/viMiEynmZdEjqtpqKUYMBC7XO9ZY6408Qka+xbt5OKu7gmNsyPPyrQ RljwFy9w/QBjoorH/Dvwr65FR45Gas4IkIvgeobJHc9KTf7JmDUAt3y28QSCQZt0yZCz4JunFePJ7 7m0avU+ZTOpba3cILhwadzoFxmehVMG7ecCGoR14wAoTosMhvpt9BjGj/iMykouecbIaT5HLaVNeF m3EE672FHgSMBk0Jh6B5n1sCHDcR2i1FxO5A+h8UoNwDRk2vhzTvksim5w/N+HUdsIINICi7VJAfh cibEDV8nA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoOb-00082A-Gm; Sat, 18 Jul 2020 15:05:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoOZ-00081U-E2 for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:05:00 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D68612065D; Sat, 18 Jul 2020 15:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084698; bh=AAZPwQTU94R3L/QF22yxuFg1zBYZopItzGUsuLf8eIc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CaZ/g7ubXGxlkcOaOs2tbnOSLM7dFTYTLf3ULk6VCUl90SMLCaGPuqa82Vm9+fJXM HJB9aH6Cv1FZHDh/uFGPS4No6pcsHVJJr8RQry71bi8qsEXNpfjrPUXufP7z/seQlP trpFIqyQGby3AhH6yrjZRtGUL08DTYf0D6TLi2HE= Date: Sat, 18 Jul 2020 16:04:54 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 19/30] iio: dac: ad5064: Fix a few kerneldoc misdemeanours Message-ID: <20200718160454.1a722eea@archlinux> In-Reply-To: <20200716135928.1456727-20-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-20-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_110459_547416_A072FE81 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:17 +0100 Lee Jones wrote: > Misspelling, missing description and compiler attribute ordering. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5064.c:71: warning: bad line: internal vref. > drivers/iio/dac/ad5064.c:83: warning: Function parameter or member 'channels' not described in 'ad5064_chip_info' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member 'lock' not described in 'ad5064_state' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member '____cacheline_aligned' not described in 'ad5064_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Holding this one for that discussion around kernel-doc handing of ___cacheline_aligned Jonathan > --- > drivers/iio/dac/ad5064.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c > index 303f6d1a5f311..d7109f8f52efa 100644 > --- a/drivers/iio/dac/ad5064.c > +++ b/drivers/iio/dac/ad5064.c > @@ -68,8 +68,8 @@ enum ad5064_regmap_type { > * struct ad5064_chip_info - chip specific information > * @shared_vref: whether the vref supply is shared between channels > * @internal_vref: internal reference voltage. 0 if the chip has no > - internal vref. > - * @channel: channel specification > + * internal vref. > + * @channels: channel specification > * @num_channels: number of channels > * @regmap_type: register map layout variant > */ > @@ -98,6 +98,7 @@ typedef int (*ad5064_write_func)(struct ad5064_state *st, unsigned int cmd, > * @use_internal_vref: set to true if the internal reference voltage should be > * used. > * @write: register write callback > + * @lock: maintain consistency between cached and dev state > * @data: i2c/spi transfer buffers > */ > > @@ -111,7 +112,6 @@ struct ad5064_state { > bool use_internal_vref; > > ad5064_write_func write; > - /* Lock used to maintain consistency between cached and dev state */ > struct mutex lock; > > /* > @@ -121,7 +121,7 @@ struct ad5064_state { > union { > u8 i2c[3]; > __be32 spi; > - } data ____cacheline_aligned; > + } ____cacheline_aligned data; > }; > > enum ad5064_type { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel