From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09416C433DF for ; Sat, 18 Jul 2020 15:06:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC7052076A for ; Sat, 18 Jul 2020 15:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084759; bh=jj/XrXFFLzYgXOaVzl2PD4A1ReBY9X+TER5hVC5F5YM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bOyR236sZaeXDaJ+6ytcdgnCrWat94rTUKryvIuxLJt4JljtS0e97obIpK8r0iuoe 1Kq6pKjla6BbgPIuLi+x6fPNLBmkSRioAhFxP2hR7kXLnzl1QAPu/BPhZq9kMJ+V6t x52QwlMcFoin8jFRQw4jJoCsajW2A5qz5Ub4FK6I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727924AbgGRPF6 (ORCPT ); Sat, 18 Jul 2020 11:05:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:36156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPF6 (ORCPT ); Sat, 18 Jul 2020 11:05:58 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C2D42067D; Sat, 18 Jul 2020 15:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084757; bh=jj/XrXFFLzYgXOaVzl2PD4A1ReBY9X+TER5hVC5F5YM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i1EGHB5I8OT0s1qFhm6UBOZ8PU/T17FKt8BVTPiaIZSJeBqrRKxobdS6rLUIZPE8M N3nvHziwMlctkqUcF0ZluAWRMgcbmJ8FLR6NNtXqoj6kNWjaXcgqW1SRp/ev4ZRW6c LDWoE4ev7zw4qHnNYnTnjlJ35rAAhhouRo+Mec84= Date: Sat, 18 Jul 2020 16:05:53 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich Subject: Re: [PATCH 20/30] iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote unworthy kerneldocs Message-ID: <20200718160553.7362307c@archlinux> In-Reply-To: <20200716135928.1456727-21-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-21-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:18 +0100 Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'dev' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'cached_val' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'lock' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:323: warning: cannot understand function prototype: 'enum ad5446_supported_spi_device_ids ' > drivers/iio/dac/ad5446.c:545: warning: cannot understand function prototype: 'enum ad5446_supported_i2c_device_ids ' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones Seems simple so applied. Thanks, Jonathan > --- > drivers/iio/dac/ad5446.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 8f8afc8999bc7..15c314f08a007 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -29,11 +29,14 @@ > > /** > * struct ad5446_state - driver instance specific data > - * @spi: spi_device > + * @dev: this device > * @chip_info: chip model specific constants, available modes etc > * @reg: supply regulator > * @vref_mv: actual reference voltage used > - * @lock lock to protect the data buffer during write ops > + * @cached_val: store/retrieve values during power down > + * @pwr_down_mode: power down mode (1k, 100k or tristate) > + * @pwr_down: true if the device is in power down > + * @lock: lock to protect the data buffer during write ops > */ > > struct ad5446_state { > @@ -313,7 +316,7 @@ static int ad5660_write(struct ad5446_state *st, unsigned val) > return spi_write(spi, data, sizeof(data)); > } > > -/** > +/* > * ad5446_supported_spi_device_ids: > * The AD5620/40/60 parts are available in different fixed internal reference > * voltage options. The actual part numbers may look differently > @@ -535,7 +538,7 @@ static int ad5622_write(struct ad5446_state *st, unsigned val) > return i2c_master_send(client, (char *)&data, sizeof(data)); > } > > -/** > +/* > * ad5446_supported_i2c_device_ids: > * The AD5620/40/60 parts are available in different fixed internal reference > * voltage options. The actual part numbers may look differently From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D22E5C433E3 for ; Sat, 18 Jul 2020 15:07:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CCC02067D for ; Sat, 18 Jul 2020 15:07:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m9s9aWi8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="i1EGHB5I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CCC02067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kxSaWloBGCYin1cvxOCn8ijlVkgCSQVkM9SP2JISUSc=; b=m9s9aWi8vQ3uh5s0zaOywg2FR LGXCbDSiYFL2D84Hy0ujtatQwkPp2+/Uq44rF+xEFat22bgdEzSfKyUVXNfSmJi0i8sMvPdevv8VH 9SAGd27v0o3kxBGNeAB3KqZulTjcywnJySQoQX3+6F/XXiS+Ky1TLBxsu/LYKJn6Q2FVttkmwkuJ2 RnypgTz0qRctdH87n1c0f3N1UhjOQm80yLuLN5Xef5uvw0U7gDERwSqfbP71B7VNWZX39rkhLzQEM jSW+0KfUxPz/hJaFvpQ/pOT1L4iJW6rCDe17JdWshfNyhKPYTsAJ71ADGP+AlQ9kXFoJwbEtWFasH zb9Z5a9qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoPZ-0000NZ-Do; Sat, 18 Jul 2020 15:06:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoPW-0000MZ-7W for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:05:59 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C2D42067D; Sat, 18 Jul 2020 15:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595084757; bh=jj/XrXFFLzYgXOaVzl2PD4A1ReBY9X+TER5hVC5F5YM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i1EGHB5I8OT0s1qFhm6UBOZ8PU/T17FKt8BVTPiaIZSJeBqrRKxobdS6rLUIZPE8M N3nvHziwMlctkqUcF0ZluAWRMgcbmJ8FLR6NNtXqoj6kNWjaXcgqW1SRp/ev4ZRW6c LDWoE4ev7zw4qHnNYnTnjlJ35rAAhhouRo+Mec84= Date: Sat, 18 Jul 2020 16:05:53 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 20/30] iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote unworthy kerneldocs Message-ID: <20200718160553.7362307c@archlinux> In-Reply-To: <20200716135928.1456727-21-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-21-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_110558_399142_70EB100C X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:18 +0100 Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'dev' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'cached_val' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'pwr_down' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:48: warning: Function parameter or member 'lock' not described in 'ad5446_state' > drivers/iio/dac/ad5446.c:323: warning: cannot understand function prototype: 'enum ad5446_supported_spi_device_ids ' > drivers/iio/dac/ad5446.c:545: warning: cannot understand function prototype: 'enum ad5446_supported_i2c_device_ids ' > > Cc: Michael Hennerich > Signed-off-by: Lee Jones Seems simple so applied. Thanks, Jonathan > --- > drivers/iio/dac/ad5446.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 8f8afc8999bc7..15c314f08a007 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -29,11 +29,14 @@ > > /** > * struct ad5446_state - driver instance specific data > - * @spi: spi_device > + * @dev: this device > * @chip_info: chip model specific constants, available modes etc > * @reg: supply regulator > * @vref_mv: actual reference voltage used > - * @lock lock to protect the data buffer during write ops > + * @cached_val: store/retrieve values during power down > + * @pwr_down_mode: power down mode (1k, 100k or tristate) > + * @pwr_down: true if the device is in power down > + * @lock: lock to protect the data buffer during write ops > */ > > struct ad5446_state { > @@ -313,7 +316,7 @@ static int ad5660_write(struct ad5446_state *st, unsigned val) > return spi_write(spi, data, sizeof(data)); > } > > -/** > +/* > * ad5446_supported_spi_device_ids: > * The AD5620/40/60 parts are available in different fixed internal reference > * voltage options. The actual part numbers may look differently > @@ -535,7 +538,7 @@ static int ad5622_write(struct ad5446_state *st, unsigned val) > return i2c_master_send(client, (char *)&data, sizeof(data)); > } > > -/** > +/* > * ad5446_supported_i2c_device_ids: > * The AD5620/40/60 parts are available in different fixed internal reference > * voltage options. The actual part numbers may look differently _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel