From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14D7C433E1 for ; Sat, 18 Jul 2020 15:16:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8438E207FB for ; Sat, 18 Jul 2020 15:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085406; bh=35faZSalQB+cqTbX1R2VNGg6wNJC60ycGnCnnnSFeUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QuS8Sza7wRRT9ci5UPisghiNjhE7VnBl8tiuZySzkWNtAaejAYbRcyzTWldt9D6ip +0a4J/gu016WnLDTegpbAQgUkkMNbG62ITCSJ/3NmVTWpxfgQNry4fD+LCuN0bjheF YaYtK4XCW873kX4N2nZ1nkj6M2ei7Vc7xVfPnbhE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbgGRPQp (ORCPT ); Sat, 18 Jul 2020 11:16:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:38830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPQp (ORCPT ); Sat, 18 Jul 2020 11:16:45 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DFFB2076A; Sat, 18 Jul 2020 15:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085404; bh=35faZSalQB+cqTbX1R2VNGg6wNJC60ycGnCnnnSFeUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GQXiioKh2xzlwlYfRQF87o/7SX0vTb0COerHrKePioeTcLwiMCHI9pKGO4hK4KK13 K36kr0J6TWfP5UOZhl8yQBDgk03QoKSbKcp38ghMznXE629HgwRZz2qKj4d7QepVVS L7rGtEH+m/1HxvSwMVRpUN6Sf5x64qvmgFitTY1k= Date: Sat, 18 Jul 2020 16:16:40 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Daniel Baluta Subject: Re: [PATCH 28/30] iio: magnetometer: mmc35240: Fix function header formatting Message-ID: <20200718161640.70fce581@archlinux> In-Reply-To: <20200716135928.1456727-29-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-29-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:26 +0100 Lee Jones wrote: > All lines in the header must start with " *". > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/magnetometer/mmc35240.c:304: warning: bad line: compensation for output value. > > Cc: Daniel Baluta > Signed-off-by: Lee Jones I tweaked this one a tiny bit to drop the brackets you added. I remember looking this up recently and they are optional in the kernel-doc format. Adds a very small amount of confusion perhaps to add them in here. Applied > --- > drivers/iio/magnetometer/mmc35240.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c > index 1787d656d0094..19e46b1f4ee81 100644 > --- a/drivers/iio/magnetometer/mmc35240.c > +++ b/drivers/iio/magnetometer/mmc35240.c > @@ -300,8 +300,8 @@ static int mmc35240_read_measurement(struct mmc35240_data *data, __le16 buf[3]) > } > > /** > - * mmc35240_raw_to_mgauss - convert raw readings to milli gauss. Also apply > - compensation for output value. > + * mmc35240_raw_to_mgauss() - convert raw readings to milli gauss. Also apply > + * compensation for output value. > * > * @data: device private data > * @index: axis index for which we want the conversion From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3D9C433E3 for ; Sat, 18 Jul 2020 15:18:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B21DA20775 for ; Sat, 18 Jul 2020 15:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WsvuliYb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GQXiioKh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21DA20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z2z+dk0biUT5OvNUC3oo8ugq+SQ6FCi/Awxqzvr6Dqg=; b=WsvuliYbuJyvNW5yoKglbSu/N qUogw9yP+K0FfvaWgGTF+eOT1asqAgWX2aiMp0whEkWJsYyYkQJbMNBCfDUu2e9t/7StIupgQFhH3 MPXtY2lKTFjUI54CDQRhoLwtOJuQRAmC4OUTiKwVbZz9wpqkNzAbwDb9UgNtWtBGoRuBRjgEtWDuL xARBmRtX+Ge1JQf9WG3uE+3k0+9f0o3p8bNOgPy7Mg0mS+ExYwU+id+FudnsR3LdJ11F/edeeqSPP zLLSoNzukDZgV0MgjOrtvFR2hh+9SyWafVoX6T5vOZltI3cpiQVzNPGjCvMyKzSP+ygRH+1sxvCLc qsvmeQJKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoZz-0003Mz-Sq; Sat, 18 Jul 2020 15:16:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoZx-0003MF-Ej for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:16:46 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DFFB2076A; Sat, 18 Jul 2020 15:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085404; bh=35faZSalQB+cqTbX1R2VNGg6wNJC60ycGnCnnnSFeUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GQXiioKh2xzlwlYfRQF87o/7SX0vTb0COerHrKePioeTcLwiMCHI9pKGO4hK4KK13 K36kr0J6TWfP5UOZhl8yQBDgk03QoKSbKcp38ghMznXE629HgwRZz2qKj4d7QepVVS L7rGtEH+m/1HxvSwMVRpUN6Sf5x64qvmgFitTY1k= Date: Sat, 18 Jul 2020 16:16:40 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 28/30] iio: magnetometer: mmc35240: Fix function header formatting Message-ID: <20200718161640.70fce581@archlinux> In-Reply-To: <20200716135928.1456727-29-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-29-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_111645_583732_9713F3C8 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:26 +0100 Lee Jones wrote: > All lines in the header must start with " *". > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/magnetometer/mmc35240.c:304: warning: bad line: compensation for output value. > > Cc: Daniel Baluta > Signed-off-by: Lee Jones I tweaked this one a tiny bit to drop the brackets you added. I remember looking this up recently and they are optional in the kernel-doc format. Adds a very small amount of confusion perhaps to add them in here. Applied > --- > drivers/iio/magnetometer/mmc35240.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c > index 1787d656d0094..19e46b1f4ee81 100644 > --- a/drivers/iio/magnetometer/mmc35240.c > +++ b/drivers/iio/magnetometer/mmc35240.c > @@ -300,8 +300,8 @@ static int mmc35240_read_measurement(struct mmc35240_data *data, __le16 buf[3]) > } > > /** > - * mmc35240_raw_to_mgauss - convert raw readings to milli gauss. Also apply > - compensation for output value. > + * mmc35240_raw_to_mgauss() - convert raw readings to milli gauss. Also apply > + * compensation for output value. > * > * @data: device private data > * @index: axis index for which we want the conversion _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel