From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD43BC433DF for ; Sat, 18 Jul 2020 15:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB8762080D for ; Sat, 18 Jul 2020 15:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085454; bh=BKNVe9fgnfqAHXaTZBDQXkmm6++oSD277VPzoltC4t8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ZceL56Yvew67m7dSuHroV8IHMOgo5qFsLIwgxDFbuhqArCGGDXGAWJRr8MJyA28xZ FXkYtuzdjA4VRsguIxMF/zOSY0Dt2f5btFBJ2GvYNvqVXElcOT+eOpkVbFAomvmmHv eLfpz4EezO7KQo8zw4SxEZGsxcBsmijRfD/odn7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgGRPRd (ORCPT ); Sat, 18 Jul 2020 11:17:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:38970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRPRd (ORCPT ); Sat, 18 Jul 2020 11:17:33 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EB1C20775; Sat, 18 Jul 2020 15:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085452; bh=BKNVe9fgnfqAHXaTZBDQXkmm6++oSD277VPzoltC4t8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s42pLxPyMt7gImBXNBgaVoHkq3TeaCW/j6jzSa/ngTX3ouORea9/7T4obK+xxcFZJ zwjJ1UTz+O8poGCWD8KjlEKsJVVqhf6bsFpJuTdvpoz98p6EQHJVk1gNIjyoN+xOaE ya6eEJwLSRSYeWCAuUh0csSMLHUWb56e6GqCmvtY= Date: Sat, 18 Jul 2020 16:17:28 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Daniel Baluta Subject: Re: [PATCH 29/30] iio: imu: kmx61: Fix formatting in kerneldoc function headers Message-ID: <20200718161728.2faa55f2@archlinux> In-Reply-To: <20200716135928.1456727-30-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-30-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:27 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'data' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'mode' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'device' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'update' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'data' not described in 'kmx61_set_power_state' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'on' not described in 'kmx61_set_power_state' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'device' not described in 'kmx61_set_power_state' > > Cc: Daniel Baluta > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/imu/kmx61.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c > index e67466100aff4..d0cee2e09884d 100644 > --- a/drivers/iio/imu/kmx61.c > +++ b/drivers/iio/imu/kmx61.c > @@ -312,10 +312,10 @@ static int kmx61_convert_wake_up_odr_to_bit(int val, int val2) > > /** > * kmx61_set_mode() - set KMX61 device operating mode > - * @data - kmx61 device private data pointer > - * @mode - bitmask, indicating operating mode for @device > - * @device - bitmask, indicating device for which @mode needs to be set > - * @update - update stby bits stored in device's private @data > + * @data: kmx61 device private data pointer > + * @mode: bitmask, indicating operating mode for @device > + * @device: bitmask, indicating device for which @mode needs to be set > + * @update: update stby bits stored in device's private @data > * > * For each sensor (accelerometer/magnetometer) there are two operating modes > * STANDBY and OPERATION. Neither accel nor magn can be disabled independently > @@ -718,9 +718,9 @@ static int kmx61_setup_any_motion_interrupt(struct kmx61_data *data, > > /** > * kmx61_set_power_state() - set power state for kmx61 @device > - * @data - kmx61 device private pointer > - * @on - power state to be set for @device > - * @device - bitmask indicating device for which @on state needs to be set > + * @data: kmx61 device private pointer > + * @on: power state to be set for @device > + * @device: bitmask indicating device for which @on state needs to be set > * > * Notice that when ACC power state needs to be set to ON and MAG is in > * OPERATION then we know that kmx61_runtime_resume was already called From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0BFC433E0 for ; Sat, 18 Jul 2020 15:18:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40D4120775 for ; Sat, 18 Jul 2020 15:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wI2yV9/N"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s42pLxPy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40D4120775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XyjWIsr7vKeFNaPrhW+7VAHKQJjRNN8NvsqJPJsFq6Q=; b=wI2yV9/Ncjp8IrfCpAuZsSdRQ pgq9yVAnq/EABQWNECv/1iyLt+RACTC8RI5Tk5qlDJ+1YbWYWqhr1KPBGNUe01PnJdvW0KRLljvwO T85HLaH2Bk7wXfo6VkFdSxFUWSdWVNs8iZAlUi0ij/xAPUkiL7HxeGusxsVkHmNUGWDbWJ9bP/6g5 gxDO5TzslxxwkO8JrtT7E+gg63gzPwX744TdsZQG3oyfjQBmZIoilH2bjbeodLJ5j+lvLrRRhH4Z+ wpKRngmXnZ7QnxE6ioMR3BnMk63j52D5VdQgF7ZR09xzeiwtuuhxEgr3N5QsHjfsfBFOEQHqpAo/T n7M3DSg5Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoam-0003V3-KA; Sat, 18 Jul 2020 15:17:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoaj-0003UJ-Dw for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:17:34 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EB1C20775; Sat, 18 Jul 2020 15:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085452; bh=BKNVe9fgnfqAHXaTZBDQXkmm6++oSD277VPzoltC4t8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s42pLxPyMt7gImBXNBgaVoHkq3TeaCW/j6jzSa/ngTX3ouORea9/7T4obK+xxcFZJ zwjJ1UTz+O8poGCWD8KjlEKsJVVqhf6bsFpJuTdvpoz98p6EQHJVk1gNIjyoN+xOaE ya6eEJwLSRSYeWCAuUh0csSMLHUWb56e6GqCmvtY= Date: Sat, 18 Jul 2020 16:17:28 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 29/30] iio: imu: kmx61: Fix formatting in kerneldoc function headers Message-ID: <20200718161728.2faa55f2@archlinux> In-Reply-To: <20200716135928.1456727-30-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-30-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_111733_619382_5AC848CD X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:27 +0100 Lee Jones wrote: > Kerneldoc expects attributes/parameters to be in '@*.: ' format. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'data' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'mode' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'device' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:327: warning: Function parameter or member 'update' not described in 'kmx61_set_mode' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'data' not described in 'kmx61_set_power_state' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'on' not described in 'kmx61_set_power_state' > drivers/iio/imu/kmx61.c:731: warning: Function parameter or member 'device' not described in 'kmx61_set_power_state' > > Cc: Daniel Baluta > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/imu/kmx61.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c > index e67466100aff4..d0cee2e09884d 100644 > --- a/drivers/iio/imu/kmx61.c > +++ b/drivers/iio/imu/kmx61.c > @@ -312,10 +312,10 @@ static int kmx61_convert_wake_up_odr_to_bit(int val, int val2) > > /** > * kmx61_set_mode() - set KMX61 device operating mode > - * @data - kmx61 device private data pointer > - * @mode - bitmask, indicating operating mode for @device > - * @device - bitmask, indicating device for which @mode needs to be set > - * @update - update stby bits stored in device's private @data > + * @data: kmx61 device private data pointer > + * @mode: bitmask, indicating operating mode for @device > + * @device: bitmask, indicating device for which @mode needs to be set > + * @update: update stby bits stored in device's private @data > * > * For each sensor (accelerometer/magnetometer) there are two operating modes > * STANDBY and OPERATION. Neither accel nor magn can be disabled independently > @@ -718,9 +718,9 @@ static int kmx61_setup_any_motion_interrupt(struct kmx61_data *data, > > /** > * kmx61_set_power_state() - set power state for kmx61 @device > - * @data - kmx61 device private pointer > - * @on - power state to be set for @device > - * @device - bitmask indicating device for which @on state needs to be set > + * @data: kmx61 device private pointer > + * @on: power state to be set for @device > + * @device: bitmask indicating device for which @on state needs to be set > * > * Notice that when ACC power state needs to be set to ON and MAG is in > * OPERATION then we know that kmx61_runtime_resume was already called _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel