From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DC95C433E0 for ; Sat, 18 Jul 2020 15:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE2312080D for ; Sat, 18 Jul 2020 15:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085500; bh=xYkPp9E7IfYHLCoHPTUXJOewHyFUrkxmseuBTKtauZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=agOZjxNIdrg9O0oHNLtIG0kKN6n40cja54ertldVANrgIWjMtvOwvg81iwXAX/gfk 2MWIP4IR0bj5H35dLybrsjGyFZ3NV1W2Jp9+PCHfgO5PazGxPGhHBnGYKDa3feSxVP OJ8jBPBNLakAH3U22ZXYZnkIT9x/ZYmRR8MnSrhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgGRPST (ORCPT ); Sat, 18 Jul 2020 11:18:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgGRPST (ORCPT ); Sat, 18 Jul 2020 11:18:19 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7186A20775; Sat, 18 Jul 2020 15:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085499; bh=xYkPp9E7IfYHLCoHPTUXJOewHyFUrkxmseuBTKtauZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mcb0ETvvZ+lnP7JiMxPXzcRcqjMk9rfFvr9Rd0eGmu3gaB68Av9RI2q/10GZx4ckm 6kHnjjUp3IUkxX7NnBKO7aRrKGRw0vR2RL7ZMPwxVcuUddRinHRo7cRrZWiCLj4cqF dwhv7vA85bNOxMBXvqnLW6G9aGRLcd6rEk4/VtZw= Date: Sat, 18 Jul 2020 16:18:14 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Liam Girdwood , Mark Brown Subject: Re: [PATCH 30/30] iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder compiler attribute Message-ID: <20200718161814.06844591@archlinux> In-Reply-To: <20200716135928.1456727-31-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-31-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:28 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vdd_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vref_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'lock' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7303_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Holding this one pending that earlier discussion on whether we should screen ____cacheline_aligned out in kernel-doc script. Thanks, Jonathan > --- > drivers/iio/dac/ad7303.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c > index 15af8a1cce3eb..05d8dc88d4fad 100644 > --- a/drivers/iio/dac/ad7303.c > +++ b/drivers/iio/dac/ad7303.c > @@ -29,6 +29,9 @@ > * @spi: the device for this driver instance > * @config: cached config register value > * @dac_cache: current DAC raw value (chip does not support readback) > + * @vdd_reg: reference to VDD regulator > + * @vref_reg: reference to VREF regulator > + * @lock: protect writes and cache updates > * @data: spi transfer buffer > */ > > @@ -45,7 +48,7 @@ struct ad7303_state { > * DMA (thus cache coherency maintenance) requires the > * transfer buffers to live in their own cache lines. > */ > - __be16 data ____cacheline_aligned; > + __be16 ____cacheline_aligned data; > }; > > static int ad7303_write(struct ad7303_state *st, unsigned int chan, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4337C433E1 for ; Sat, 18 Jul 2020 15:19:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 724A120775 for ; Sat, 18 Jul 2020 15:19:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d8j6tuP/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mcb0ETvv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 724A120775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x6+wR5D/y1cwkPztH9vwe+PAsvHO5HBBiSbId6J+2d0=; b=d8j6tuP/2uA07K3as79A7li/w AjAIRgbyWpUdhhCv/trSOVtTi56nWaJ8UrddgN/BL9QXW17eqhPWiFQlscXBwlRdxQEllZu/W/x98 fBHL3q0gzEGTJDHkXahmpOtswiXCXtCsCvvOPyYtisWGh+IEQ2iART/f5ex3LCNw7VHOKubbth5YY IubjHy0cbOtD5TUZBRqH1Adwp4H6aiQ7Q/v6GXSXTp+63AAEUdMxTRMzo4CJnVAAOrDUaSQ9+3OiF xZdYrKKmMj9Q5LVVRKiXgqtU+K55/BmJyjdun1RDhSFGUG8IAaFBiGXwmRLkqmPnXVSnoEs2nPW9F r05vHvf2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwobW-0003fB-Ei; Sat, 18 Jul 2020 15:18:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwobT-0003e6-OB for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:18:20 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7186A20775; Sat, 18 Jul 2020 15:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595085499; bh=xYkPp9E7IfYHLCoHPTUXJOewHyFUrkxmseuBTKtauZE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mcb0ETvvZ+lnP7JiMxPXzcRcqjMk9rfFvr9Rd0eGmu3gaB68Av9RI2q/10GZx4ckm 6kHnjjUp3IUkxX7NnBKO7aRrKGRw0vR2RL7ZMPwxVcuUddRinHRo7cRrZWiCLj4cqF dwhv7vA85bNOxMBXvqnLW6G9aGRLcd6rEk4/VtZw= Date: Sat, 18 Jul 2020 16:18:14 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 30/30] iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder compiler attribute Message-ID: <20200718161814.06844591@archlinux> In-Reply-To: <20200716135928.1456727-31-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-31-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_111819_906562_3CA8D13A X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:28 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vdd_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vref_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'lock' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7303_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Holding this one pending that earlier discussion on whether we should screen ____cacheline_aligned out in kernel-doc script. Thanks, Jonathan > --- > drivers/iio/dac/ad7303.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c > index 15af8a1cce3eb..05d8dc88d4fad 100644 > --- a/drivers/iio/dac/ad7303.c > +++ b/drivers/iio/dac/ad7303.c > @@ -29,6 +29,9 @@ > * @spi: the device for this driver instance > * @config: cached config register value > * @dac_cache: current DAC raw value (chip does not support readback) > + * @vdd_reg: reference to VDD regulator > + * @vref_reg: reference to VREF regulator > + * @lock: protect writes and cache updates > * @data: spi transfer buffer > */ > > @@ -45,7 +48,7 @@ struct ad7303_state { > * DMA (thus cache coherency maintenance) requires the > * transfer buffers to live in their own cache lines. > */ > - __be16 data ____cacheline_aligned; > + __be16 ____cacheline_aligned data; > }; > > static int ad7303_write(struct ad7303_state *st, unsigned int chan, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel