From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8166C433E3 for ; Sat, 18 Jul 2020 15:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A02202080D for ; Sat, 18 Jul 2020 15:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086264; bh=1wuiIPUiXSmhjJ5LdQ20PRNh28jticm8GjYJ/lQO3C4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=DpT2yPGtrUkC+lYY8P+KmSGvjDW51lv4dVgyIRpG048vLHqPeK3O5cDrHVs9bJLxh 1ZHfHk+Ah+8ETpg0RlfPvoLB7I+jyD9nSn0E7NiAcw56tlz6AvRIkV1K7fEsvjQP9A LlSGxOVPALC7W0bu4fZvwoZZ3ZtEL3AIjg/MssMU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbgGRPbD (ORCPT ); Sat, 18 Jul 2020 11:31:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:41266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbgGRPbD (ORCPT ); Sat, 18 Jul 2020 11:31:03 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44A7C2076A; Sat, 18 Jul 2020 15:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086262; bh=1wuiIPUiXSmhjJ5LdQ20PRNh28jticm8GjYJ/lQO3C4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fMTm3kuucoTH3NtXiv5VTUCkKBXs3MWRPXJRPJw3UaljOi4yp7wXS33ggotopxQ/L p1RM113L0ROPs434YgDq8uwqjNSnRZWjCyVrDLbeVBRefDpZOvwirW5r8ExBsnfcuq GbDHpRL2WUUkfzVz1lLDYKMlJ3Yooe/bYh06IaH4= Date: Sat, 18 Jul 2020 16:30:58 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Rachna Patil Subject: Re: [PATCH 01/30] iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables Message-ID: <20200718163058.672b6362@archlinux> In-Reply-To: <20200717165538.3275050-2-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-2-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2020 17:55:09 +0100 Lee Jones wrote: > Fixes the following W=3D1 kernel build warning(s): >=20 > drivers/iio/adc/ti_am335x_adc.c: In function =E2=80=98tiadc_buffer_preen= able=E2=80=99: > drivers/iio/adc/ti_am335x_adc.c:297:21: warning: variable =E2=80=98read= =E2=80=99 set but not used [-Wunused-but-set-variable] > 297 | int i, fifo1count, read; > | ^~~~ > drivers/iio/adc/ti_am335x_adc.c: In function =E2=80=98tiadc_buffer_predi= sable=E2=80=99: > drivers/iio/adc/ti_am335x_adc.c:346:21: warning: variable =E2=80=98read= =E2=80=99 set but not used [-Wunused-but-set-variable] > 346 | int fifo1count, i, read; > | ^~~~ >=20 > Cc: Rachna Patil > Signed-off-by: Lee Jones Applied to the togreg branch of iio.git which will get pushed out as testin= g for the autobuilders to poke at these changes. Still time or anyone one else to comment. I'm picking these up as they are all noops and appear straight forward. Thanks, Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_= adc.c > index 9d984f2a8ba74..93b67bb165044 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -294,7 +294,7 @@ static int tiadc_start_dma(struct iio_dev *indio_dev) > static int tiadc_buffer_preenable(struct iio_dev *indio_dev) > { > struct tiadc_device *adc_dev =3D iio_priv(indio_dev); > - int i, fifo1count, read; > + int i, fifo1count; > =20 > tiadc_writel(adc_dev, REG_IRQCLR, (IRQENB_FIFO1THRES | > IRQENB_FIFO1OVRRUN | > @@ -303,7 +303,7 @@ static int tiadc_buffer_preenable(struct iio_dev *ind= io_dev) > /* Flush FIFO. Needed in corner cases in simultaneous tsc/adc use */ > fifo1count =3D tiadc_readl(adc_dev, REG_FIFO1CNT); > for (i =3D 0; i < fifo1count; i++) > - read =3D tiadc_readl(adc_dev, REG_FIFO1); > + tiadc_readl(adc_dev, REG_FIFO1); > =20 > return 0; > } > @@ -343,7 +343,7 @@ static int tiadc_buffer_predisable(struct iio_dev *in= dio_dev) > { > struct tiadc_device *adc_dev =3D iio_priv(indio_dev); > struct tiadc_dma *dma =3D &adc_dev->dma; > - int fifo1count, i, read; > + int fifo1count, i; > =20 > tiadc_writel(adc_dev, REG_IRQCLR, (IRQENB_FIFO1THRES | > IRQENB_FIFO1OVRRUN | IRQENB_FIFO1UNDRFLW)); > @@ -358,7 +358,7 @@ static int tiadc_buffer_predisable(struct iio_dev *in= dio_dev) > /* Flush FIFO of leftover data in the time it takes to disable adc */ > fifo1count =3D tiadc_readl(adc_dev, REG_FIFO1CNT); > for (i =3D 0; i < fifo1count; i++) > - read =3D tiadc_readl(adc_dev, REG_FIFO1); > + tiadc_readl(adc_dev, REG_FIFO1); > =20 > return 0; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60500C433E7 for ; Sat, 18 Jul 2020 15:32:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E8F320734 for ; Sat, 18 Jul 2020 15:32:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oYkt0r68"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fMTm3kuu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E8F320734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yWEEeItlD60e4jcp8jQPOsqddZJAqV2PIK2EwbXs6CM=; b=oYkt0r68iIAYjT3daRzazdCyo eXffGk+0nijw2eGEnCJhXTfwW4S+Y91li8pq3LqZEX9yoM8ddVNR8jlWEX/+iXRlrPf5TAkd0TwMu /C8HHq/FdeKvBDYHjfZNrPTR6fpvPji28/C8dj0ajBczodiseSXWsX5EkrwJR2b3NDNJVeaDCi6PO xuC1NyJiNHWCtIPGI0NB5FcPf1p2czPtq3XaWp7DMzJLPQYCiIVkDQDkF3fTFmM193wfWsrys3T+Q EdPVAslnarp2qX9Flh9hBeKYwR86BVNo8aoVvMqcpRV8fhCEk0wNbUYbmXqz7kq7G2sl2HS5nBN6i wKsyA7Ffw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwonp-0004kY-Gk; Sat, 18 Jul 2020 15:31:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwonn-0004jx-OO for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 15:31:04 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44A7C2076A; Sat, 18 Jul 2020 15:31:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595086262; bh=1wuiIPUiXSmhjJ5LdQ20PRNh28jticm8GjYJ/lQO3C4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fMTm3kuucoTH3NtXiv5VTUCkKBXs3MWRPXJRPJw3UaljOi4yp7wXS33ggotopxQ/L p1RM113L0ROPs434YgDq8uwqjNSnRZWjCyVrDLbeVBRefDpZOvwirW5r8ExBsnfcuq GbDHpRL2WUUkfzVz1lLDYKMlJ3Yooe/bYh06IaH4= Date: Sat, 18 Jul 2020 16:30:58 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 01/30] iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables Message-ID: <20200718163058.672b6362@archlinux> In-Reply-To: <20200717165538.3275050-2-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-2-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_113103_958855_0CAEABAD X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Rachna Patil , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxNyBKdWwgMjAyMCAxNzo1NTowOSArMDEwMApMZWUgSm9uZXMgPGxlZS5qb25lc0Bs aW5hcm8ub3JnPiB3cm90ZToKCj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxk IHdhcm5pbmcocyk6Cj4gCj4gIGRyaXZlcnMvaWlvL2FkYy90aV9hbTMzNXhfYWRjLmM6IEluIGZ1 bmN0aW9uIOKAmHRpYWRjX2J1ZmZlcl9wcmVlbmFibGXigJk6Cj4gIGRyaXZlcnMvaWlvL2FkYy90 aV9hbTMzNXhfYWRjLmM6Mjk3OjIxOiB3YXJuaW5nOiB2YXJpYWJsZSDigJhyZWFk4oCZIHNldCBi dXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gIDI5NyB8IGludCBpLCBm aWZvMWNvdW50LCByZWFkOwo+ICB8IF5+fn4KPiAgZHJpdmVycy9paW8vYWRjL3RpX2FtMzM1eF9h ZGMuYzogSW4gZnVuY3Rpb24g4oCYdGlhZGNfYnVmZmVyX3ByZWRpc2FibGXigJk6Cj4gIGRyaXZl cnMvaWlvL2FkYy90aV9hbTMzNXhfYWRjLmM6MzQ2OjIxOiB3YXJuaW5nOiB2YXJpYWJsZSDigJhy ZWFk4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gIDM0 NiB8IGludCBmaWZvMWNvdW50LCBpLCByZWFkOwo+ICB8IF5+fn4KPiAKPiBDYzogUmFjaG5hIFBh dGlsIDxyYWNobmFAdGkuY29tPgo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVz QGxpbmFyby5vcmc+CkFwcGxpZWQgdG8gdGhlIHRvZ3JlZyBicmFuY2ggb2YgaWlvLmdpdCB3aGlj aCB3aWxsIGdldCBwdXNoZWQgb3V0IGFzIHRlc3RpbmcgZm9yCnRoZSBhdXRvYnVpbGRlcnMgdG8g cG9rZSBhdCB0aGVzZSBjaGFuZ2VzLgpTdGlsbCB0aW1lIG9yIGFueW9uZSBvbmUgZWxzZSB0byBj b21tZW50LiBJJ20gcGlja2luZyB0aGVzZSB1cCBhcyB0aGV5IGFyZQphbGwgbm9vcHMgYW5kIGFw cGVhciBzdHJhaWdodCBmb3J3YXJkLgoKVGhhbmtzLAoKSm9uYXRoYW4KCj4gLS0tCj4gIGRyaXZl cnMvaWlvL2FkYy90aV9hbTMzNXhfYWRjLmMgfCA4ICsrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvaWlvL2FkYy90aV9hbTMzNXhfYWRjLmMgYi9kcml2ZXJzL2lpby9hZGMvdGlfYW0zMzV4X2Fk Yy5jCj4gaW5kZXggOWQ5ODRmMmE4YmE3NC4uOTNiNjdiYjE2NTA0NCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2lpby9hZGMvdGlfYW0zMzV4X2FkYy5jCj4gKysrIGIvZHJpdmVycy9paW8vYWRjL3Rp X2FtMzM1eF9hZGMuYwo+IEBAIC0yOTQsNyArMjk0LDcgQEAgc3RhdGljIGludCB0aWFkY19zdGFy dF9kbWEoc3RydWN0IGlpb19kZXYgKmluZGlvX2RldikKPiAgc3RhdGljIGludCB0aWFkY19idWZm ZXJfcHJlZW5hYmxlKHN0cnVjdCBpaW9fZGV2ICppbmRpb19kZXYpCj4gIHsKPiAgCXN0cnVjdCB0 aWFkY19kZXZpY2UgKmFkY19kZXYgPSBpaW9fcHJpdihpbmRpb19kZXYpOwo+IC0JaW50IGksIGZp Zm8xY291bnQsIHJlYWQ7Cj4gKwlpbnQgaSwgZmlmbzFjb3VudDsKPiAgCj4gIAl0aWFkY193cml0 ZWwoYWRjX2RldiwgUkVHX0lSUUNMUiwgKElSUUVOQl9GSUZPMVRIUkVTIHwKPiAgCQkJCUlSUUVO Ql9GSUZPMU9WUlJVTiB8Cj4gQEAgLTMwMyw3ICszMDMsNyBAQCBzdGF0aWMgaW50IHRpYWRjX2J1 ZmZlcl9wcmVlbmFibGUoc3RydWN0IGlpb19kZXYgKmluZGlvX2RldikKPiAgCS8qIEZsdXNoIEZJ Rk8uIE5lZWRlZCBpbiBjb3JuZXIgY2FzZXMgaW4gc2ltdWx0YW5lb3VzIHRzYy9hZGMgdXNlICov Cj4gIAlmaWZvMWNvdW50ID0gdGlhZGNfcmVhZGwoYWRjX2RldiwgUkVHX0ZJRk8xQ05UKTsKPiAg CWZvciAoaSA9IDA7IGkgPCBmaWZvMWNvdW50OyBpKyspCj4gLQkJcmVhZCA9IHRpYWRjX3JlYWRs KGFkY19kZXYsIFJFR19GSUZPMSk7Cj4gKwkJdGlhZGNfcmVhZGwoYWRjX2RldiwgUkVHX0ZJRk8x KTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQo+IEBAIC0zNDMsNyArMzQzLDcgQEAgc3RhdGljIGlu dCB0aWFkY19idWZmZXJfcHJlZGlzYWJsZShzdHJ1Y3QgaWlvX2RldiAqaW5kaW9fZGV2KQo+ICB7 Cj4gIAlzdHJ1Y3QgdGlhZGNfZGV2aWNlICphZGNfZGV2ID0gaWlvX3ByaXYoaW5kaW9fZGV2KTsK PiAgCXN0cnVjdCB0aWFkY19kbWEgKmRtYSA9ICZhZGNfZGV2LT5kbWE7Cj4gLQlpbnQgZmlmbzFj b3VudCwgaSwgcmVhZDsKPiArCWludCBmaWZvMWNvdW50LCBpOwo+ICAKPiAgCXRpYWRjX3dyaXRl bChhZGNfZGV2LCBSRUdfSVJRQ0xSLCAoSVJRRU5CX0ZJRk8xVEhSRVMgfAo+ICAJCQkJSVJRRU5C X0ZJRk8xT1ZSUlVOIHwgSVJRRU5CX0ZJRk8xVU5EUkZMVykpOwo+IEBAIC0zNTgsNyArMzU4LDcg QEAgc3RhdGljIGludCB0aWFkY19idWZmZXJfcHJlZGlzYWJsZShzdHJ1Y3QgaWlvX2RldiAqaW5k aW9fZGV2KQo+ICAJLyogRmx1c2ggRklGTyBvZiBsZWZ0b3ZlciBkYXRhIGluIHRoZSB0aW1lIGl0 IHRha2VzIHRvIGRpc2FibGUgYWRjICovCj4gIAlmaWZvMWNvdW50ID0gdGlhZGNfcmVhZGwoYWRj X2RldiwgUkVHX0ZJRk8xQ05UKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBmaWZvMWNvdW50OyBpKysp Cj4gLQkJcmVhZCA9IHRpYWRjX3JlYWRsKGFkY19kZXYsIFJFR19GSUZPMSk7Cj4gKwkJdGlhZGNf cmVhZGwoYWRjX2RldiwgUkVHX0ZJRk8xKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgfQoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK