From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F16C433E1 for ; Sat, 18 Jul 2020 16:02:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01BFA2080D for ; Sat, 18 Jul 2020 16:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595088170; bh=gCPyaXj3gDoDhRpX1/bqGUHn2gPCArtpU+D0BR05GpE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=z5c33pSQkfs5dOr7+bskACNfj+qBNWclQuqSq+FTcyOkCF5q3zbH6+YuyWvqiErON YW74C6jhtSArVec1o5W/Lw1bXw2AJ1JSzv/ye2LCPDHypx5GU0hi/uHhz0AmAQrhKF XLSjZr+nLE0nW6uxGOqSoY8unF5NHbg+h1iFwkVk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbgGRQCt (ORCPT ); Sat, 18 Jul 2020 12:02:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgGRQCs (ORCPT ); Sat, 18 Jul 2020 12:02:48 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91B9B2076A; Sat, 18 Jul 2020 16:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595088167; bh=gCPyaXj3gDoDhRpX1/bqGUHn2gPCArtpU+D0BR05GpE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d3EZhN95LHOi7blKYCQ8bSx/EHR2nvkUzhHMqLt7wnShygX2M1lDSFb5llcugQMGB 5aLKrPCY/fL2FWUuqlhaBW8jjkaixfb2EluffzclP7QaSe76u4fLzcJdvXl+51ELGj FFp6yFtfn3zvpHZT4TjpBcBn0jkbO6OX3vl5qBjU= Date: Sat, 18 Jul 2020 17:02:43 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Jean-Baptiste Maneyrol Subject: Re: [PATCH 24/30] iio: imu: inv_mpu6050: inv_mpu_core: Demote obvious misuse of kerneldoc to standard comment blocks Message-ID: <20200718170243.7d5ae3a9@archlinux> In-Reply-To: <20200717165538.3275050-25-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-25-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2020 17:55:32 +0100 Lee Jones wrote: > No attempt has been made to document any of the demoted functions here. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf_regs' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'val' not described in 'inv_mpu6050_set_lpf_regs' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:480: warning: Function parameter or member 'indio_dev' not described in 'inv_mpu6050_init_config' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'rate' not described in 'inv_mpu6050_set_lpf' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'dev' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'attr' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'buf' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'count' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'dev' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'attr' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'buf' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'dev' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'attr' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'buf' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:1282: warning: Function parameter or member 'st' not described in 'inv_check_and_setup_chip' > > Cc: Jean-Baptiste Maneyrol > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 4d604fe842e5d..f6b2b2e8f1010 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -433,7 +433,7 @@ static int inv_mpu6050_set_gyro_fsr(struct inv_mpu6050_state *st, > return regmap_write(st->map, st->reg->gyro_config, data); > } > > -/** > +/* > * inv_mpu6050_set_lpf_regs() - set low pass filter registers, chip dependent > * > * MPU60xx/MPU9150 use only 1 register for accelerometer + gyroscope > @@ -467,7 +467,7 @@ static int inv_mpu6050_set_lpf_regs(struct inv_mpu6050_state *st, > return regmap_write(st->map, st->reg->accel_lpf, val); > } > > -/** > +/* > * inv_mpu6050_init_config() - Initialize hardware, disable FIFO. > * > * Initial configuration: > @@ -847,7 +847,7 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev, > return result; > } > > -/** > +/* > * inv_mpu6050_set_lpf() - set low pass filer based on fifo rate. > * > * Based on the Nyquist principle, the bandwidth of the low > @@ -884,7 +884,7 @@ static int inv_mpu6050_set_lpf(struct inv_mpu6050_state *st, int rate) > return 0; > } > > -/** > +/* > * inv_mpu6050_fifo_rate_store() - Set fifo rate. > */ > static ssize_t > @@ -945,7 +945,7 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struct device_attribute *attr, > return count; > } > > -/** > +/* > * inv_fifo_rate_show() - Get the current sampling rate. > */ > static ssize_t > @@ -962,7 +962,7 @@ inv_fifo_rate_show(struct device *dev, struct device_attribute *attr, > return scnprintf(buf, PAGE_SIZE, "%u\n", fifo_rate); > } > > -/** > +/* > * inv_attr_show() - calling this function will show current > * parameters. > * > @@ -1275,7 +1275,7 @@ static const struct iio_info mpu_info = { > .debugfs_reg_access = &inv_mpu6050_reg_access, > }; > > -/** > +/* > * inv_check_and_setup_chip() - check and setup chip. > */ > static int inv_check_and_setup_chip(struct inv_mpu6050_state *st) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD5FC433E3 for ; Sat, 18 Jul 2020 16:04:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 172CD2076A for ; Sat, 18 Jul 2020 16:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PmCLnX3C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="d3EZhN95" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 172CD2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M3s/CHpDSP+HN85ysmYhRrwzLc2sVrV3170taKBZWm4=; b=PmCLnX3CsH3g3O6E8n4fBc+Yy VS34Wk18CZONI0nzlym7g2EhmVVeehRoV9RuPDjgUKG8cJ/LDTanmpS73drEljfgoIt0C50WquMda cNPbCQeq427gNKiltsXMZKhn/I4qY383Iybas/xQ175ivEvELc4vmnuJjT2OILyJ94lrIEfKLgVDR uh2GDsBHQYrOVrFxeNGPkxDttkNxqLuiL4mCTL5j+ZVm7pd+985NPm+L4IKba4Xb+ai9xZk12wNDq 8EfSYu3SY9YhD4mA5/GDKoLIjPMi1YMyiQCSVOuRUBvRG+pV75JZmYplZcUazR2FVVFNmnx85QMY2 xb7rzSfxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpIZ-0002jI-Bz; Sat, 18 Jul 2020 16:02:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwpIW-0002iJ-EL for linux-arm-kernel@lists.infradead.org; Sat, 18 Jul 2020 16:02:49 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91B9B2076A; Sat, 18 Jul 2020 16:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595088167; bh=gCPyaXj3gDoDhRpX1/bqGUHn2gPCArtpU+D0BR05GpE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d3EZhN95LHOi7blKYCQ8bSx/EHR2nvkUzhHMqLt7wnShygX2M1lDSFb5llcugQMGB 5aLKrPCY/fL2FWUuqlhaBW8jjkaixfb2EluffzclP7QaSe76u4fLzcJdvXl+51ELGj FFp6yFtfn3zvpHZT4TjpBcBn0jkbO6OX3vl5qBjU= Date: Sat, 18 Jul 2020 17:02:43 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 24/30] iio: imu: inv_mpu6050: inv_mpu_core: Demote obvious misuse of kerneldoc to standard comment blocks Message-ID: <20200718170243.7d5ae3a9@archlinux> In-Reply-To: <20200717165538.3275050-25-lee.jones@linaro.org> References: <20200717165538.3275050-1-lee.jones@linaro.org> <20200717165538.3275050-25-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_120248_646130_B6214615 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Baptiste Maneyrol , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2020 17:55:32 +0100 Lee Jones wrote: > No attempt has been made to document any of the demoted functions here. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf_regs' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:444: warning: Function parameter or member 'val' not described in 'inv_mpu6050_set_lpf_regs' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:480: warning: Function parameter or member 'indio_dev' not described in 'inv_mpu6050_init_config' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'st' not described in 'inv_mpu6050_set_lpf' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:862: warning: Function parameter or member 'rate' not described in 'inv_mpu6050_set_lpf' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'dev' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'attr' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'buf' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:893: warning: Function parameter or member 'count' not described in 'inv_mpu6050_fifo_rate_store' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'dev' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'attr' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:954: warning: Function parameter or member 'buf' not described in 'inv_fifo_rate_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'dev' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'attr' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:975: warning: Function parameter or member 'buf' not described in 'inv_attr_show' > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c:1282: warning: Function parameter or member 'st' not described in 'inv_check_and_setup_chip' > > Cc: Jean-Baptiste Maneyrol > Signed-off-by: Lee Jones Applied. Thanks, Jonathan > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > index 4d604fe842e5d..f6b2b2e8f1010 100644 > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > @@ -433,7 +433,7 @@ static int inv_mpu6050_set_gyro_fsr(struct inv_mpu6050_state *st, > return regmap_write(st->map, st->reg->gyro_config, data); > } > > -/** > +/* > * inv_mpu6050_set_lpf_regs() - set low pass filter registers, chip dependent > * > * MPU60xx/MPU9150 use only 1 register for accelerometer + gyroscope > @@ -467,7 +467,7 @@ static int inv_mpu6050_set_lpf_regs(struct inv_mpu6050_state *st, > return regmap_write(st->map, st->reg->accel_lpf, val); > } > > -/** > +/* > * inv_mpu6050_init_config() - Initialize hardware, disable FIFO. > * > * Initial configuration: > @@ -847,7 +847,7 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev, > return result; > } > > -/** > +/* > * inv_mpu6050_set_lpf() - set low pass filer based on fifo rate. > * > * Based on the Nyquist principle, the bandwidth of the low > @@ -884,7 +884,7 @@ static int inv_mpu6050_set_lpf(struct inv_mpu6050_state *st, int rate) > return 0; > } > > -/** > +/* > * inv_mpu6050_fifo_rate_store() - Set fifo rate. > */ > static ssize_t > @@ -945,7 +945,7 @@ inv_mpu6050_fifo_rate_store(struct device *dev, struct device_attribute *attr, > return count; > } > > -/** > +/* > * inv_fifo_rate_show() - Get the current sampling rate. > */ > static ssize_t > @@ -962,7 +962,7 @@ inv_fifo_rate_show(struct device *dev, struct device_attribute *attr, > return scnprintf(buf, PAGE_SIZE, "%u\n", fifo_rate); > } > > -/** > +/* > * inv_attr_show() - calling this function will show current > * parameters. > * > @@ -1275,7 +1275,7 @@ static const struct iio_info mpu_info = { > .debugfs_reg_access = &inv_mpu6050_reg_access, > }; > > -/** > +/* > * inv_check_and_setup_chip() - check and setup chip. > */ > static int inv_check_and_setup_chip(struct inv_mpu6050_state *st) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel