All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: willemdebruijn.kernel@gmail.com, srirakr2@cisco.com,
	akpm@linux-foundation.org, xe-linux-external@cisco.com,
	kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, sthemmin@microsoft.com,
	mbumgard@cisco.com
Subject: Re: [PATCH v2] AF_PACKET doesnt strip VLAN information
Date: Mon, 20 Jul 2020 16:36:58 -0700 (PDT)	[thread overview]
Message-ID: <20200720.163658.560155959996455439.davem@davemloft.net> (raw)
In-Reply-To: <20200720135650.1939665b@hermes.lan>

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 20 Jul 2020 13:56:50 -0700

> It matters because the problem is generic, not just to the netvsc driver.
> For example, BPF programs and netfilter rules will see different packets
> when send is through AF_PACKET than they would see for sends from the
> kernel stack.
> 
> Presenting uniform data to the lower layers makes sense.

The issue here is that for hyperv, vlan offloading is not a "may" but
a "must" and I've never understood it to have that meaning.

And I still haven't heard what is going to happen in Q-in-Q situations
even with the ugly hyperv driver hack that is currently under review.

  parent reply	other threads:[~2020-07-20 23:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  9:17 [PATCH v2] AF_PACKET doesnt strip VLAN information Sriram Krishnan
2020-07-18 15:58 ` Willem de Bruijn
     [not found]   ` <CY4PR1101MB21013DCD55B754E29AF4A838907B0@CY4PR1101MB2101.namprd11.prod.outlook.com>
2020-07-20 13:52     ` Willem de Bruijn
2020-07-20 17:01       ` Sriram Krishnan (srirakr2)
2020-07-20 20:56       ` Stephen Hemminger
2020-07-20 21:22         ` Willem de Bruijn
2020-07-20 22:03           ` Stephen Hemminger
2020-07-20 23:36         ` David Miller [this message]
2020-07-19  5:16 ` kernel test robot
2020-07-19  5:16   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720.163658.560155959996455439.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbumgard@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=srirakr2@cisco.com \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.