From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A7FC433DF for ; Tue, 21 Jul 2020 01:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B321A2075B for ; Tue, 21 Jul 2020 01:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgGUBiv (ORCPT ); Mon, 20 Jul 2020 21:38:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgGUBiv (ORCPT ); Mon, 20 Jul 2020 21:38:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F28ACC061794; Mon, 20 Jul 2020 18:38:50 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9016811FFCC52; Mon, 20 Jul 2020 18:22:05 -0700 (PDT) Date: Mon, 20 Jul 2020 18:38:49 -0700 (PDT) Message-Id: <20200720.183849.626605331445628040.davem@davemloft.net> To: cuibixuan@huawei.com Cc: stephen@networkplumber.org, kuba@kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jdmason@kudzu.us, christophe.jaillet@wanadoo.fr, john.wanghui@huawei.com Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX From: David Miller In-Reply-To: <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> References: <20200716173247.78912-1-cuibixuan@huawei.com> <20200719100522.220a6f5a@hermes.lan> <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 20 Jul 2020 18:22:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bixuan Cui Date: Mon, 20 Jul 2020 09:58:39 +0800 > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056 bytes is larger than 1024 bytes > > Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't > have much impact on performance and functionality. > > Signed-off-by: Bixuan Cui > Signed-off-by: Stephen Hemminger > --- > v2: Dropping the NR_SKB_COMPLETED to 16. Applied.