From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF25C433E6 for ; Mon, 20 Jul 2020 08:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D64F22B4E for ; Mon, 20 Jul 2020 08:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AmQST3JV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728042AbgGTIe1 (ORCPT ); Mon, 20 Jul 2020 04:34:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgGTIeY (ORCPT ); Mon, 20 Jul 2020 04:34:24 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76B17C061794 for ; Mon, 20 Jul 2020 01:34:24 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id k71so9872268pje.0 for ; Mon, 20 Jul 2020 01:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qwe5eoeikgPsdVVgJgZFvCBwEfnVFQKOymXhWv/sjwU=; b=AmQST3JV5BHy9gWF+aGGv4HcKoNtzOanTVTgCdxvRsclM7ZaSihwD656nnDS6//PXP tpsTT1zc9zBSPFQMYsWN1ZMOcMPVdLExNzEq+rIFKb8EsN8pa2R79Xr82ACFxH4ZhI/E 75aI897o4xU7hmnfnCIfddj+uJ7oRTkrsOmakhb7l0KiF7SXkwfgySTRNFmdkWdjcY9K nVx38SLgzfBDk/n3+Prj9E2qB5AlN35jxKjhLPHHTImYPwKFGJXINeXTn3zuwJS2bnwW eJoNmTxoa4PcD71X7rld/Tca6WuQrUbRaRW/hPpDcpgZyHQUYbxJKwIhM/qBzciw85V6 SODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qwe5eoeikgPsdVVgJgZFvCBwEfnVFQKOymXhWv/sjwU=; b=qyoeqVDk/98+vyEld5Dls6CZaO7W8tAlw/8eCQalchGhxMiMDuECddnghjVhLypvGM /dtwJ/mf9xV/wuhOBPR1D28XLSq5xYGOtgT3be8XIQ0NY3m55CaRj/LBSs6MObkcw1c8 YEOvXw2o7O76GpNZMWk5AYrrtNQT6xSisLKvYCtyFSjNu44TS0czRmew+OkW247qJnVF t9fvIuNgBwicGtKfZ5k7U+f4txwMoSbHdMyibhozpNTjjdXCvqF+t/9CNm9/9hBZn3Ny gi6ghIWY4fPli9Dci5GW1aBrEdMqvQVFWrqPDZs64Bhf4cFon2OwiCnkDtpFPds98sNV GMjA== X-Gm-Message-State: AOAM533MzLdI2yRgUyzmU+hVhVf7qI7PIAo1Q8oJOL3sEk71d2c4Nu5J XxrYdQsTwlObqOxmuOAB7DQ= X-Google-Smtp-Source: ABdhPJyzxwvAQZZhov+oQjRDbhsrpwR+sNeovC0j7heVwX12gi0gScUzTNiUt3M1omiBDdqQmvR4Bg== X-Received: by 2002:a17:902:b7c8:: with SMTP id v8mr17252214plz.201.1595234063979; Mon, 20 Jul 2020 01:34:23 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id p5sm14072134pgi.83.2020.07.20.01.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 01:34:23 -0700 (PDT) Date: Mon, 20 Jul 2020 17:34:20 +0900 From: Sergey Senozhatsky To: Marco Elver Cc: Sergey Senozhatsky , John Ogness , Petr Mladek , Peter Zijlstra , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , Paul McKenney , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/4] printk: use the lockless ringbuffer Message-ID: <20200720083420.GB463@jagdpanzerIV.localdomain> References: <20200709132344.760-1-john.ogness@linutronix.de> <20200709132344.760-5-john.ogness@linutronix.de> <20200718121053.GA691245@elver.google.com> <20200719034312.GA566736@jagdpanzerIV.localdomain> <20200720064303.GA2144711@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720064303.GA2144711@elver.google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/07/20 08:43), Marco Elver wrote: [..] > please see a full list of newline-print users below. [..] > $> git grep -En '\<(printk|pr_err|pr_warn|pr_info)\>\("\\n"\)' > arch/alpha/kernel/core_wildfire.c:650: printk("\n"); > arch/alpha/kernel/core_wildfire.c:658: printk("\n"); > arch/alpha/kernel/traps.c:120: printk("\n"); [..] In many cases printk("\n") is not for "print a blank line", but rather for "flush pr_cont buffer". -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxRFj-0005jV-Ra for kexec@lists.infradead.org; Mon, 20 Jul 2020 08:34:28 +0000 Received: by mail-pj1-x1044.google.com with SMTP id k1so93366pjt.5 for ; Mon, 20 Jul 2020 01:34:25 -0700 (PDT) Date: Mon, 20 Jul 2020 17:34:20 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH v5 4/4] printk: use the lockless ringbuffer Message-ID: <20200720083420.GB463@jagdpanzerIV.localdomain> References: <20200709132344.760-1-john.ogness@linutronix.de> <20200709132344.760-5-john.ogness@linutronix.de> <20200718121053.GA691245@elver.google.com> <20200719034312.GA566736@jagdpanzerIV.localdomain> <20200720064303.GA2144711@elver.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200720064303.GA2144711@elver.google.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Marco Elver Cc: Andrea Parri , Petr Mladek , Paul McKenney , Sergey Senozhatsky , John Ogness , Peter Zijlstra , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Rostedt , Sergey Senozhatsky , Thomas Gleixner , Linus Torvalds On (20/07/20 08:43), Marco Elver wrote: [..] > please see a full list of newline-print users below. [..] > $> git grep -En '\<(printk|pr_err|pr_warn|pr_info)\>\("\\n"\)' > arch/alpha/kernel/core_wildfire.c:650: printk("\n"); > arch/alpha/kernel/core_wildfire.c:658: printk("\n"); > arch/alpha/kernel/traps.c:120: printk("\n"); [..] In many cases printk("\n") is not for "print a blank line", but rather for "flush pr_cont buffer". -ss _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec