From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEDDC433DF for ; Mon, 20 Jul 2020 08:43:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADB5922B4E for ; Mon, 20 Jul 2020 08:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="e6djTCYW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgGTIny (ORCPT ); Mon, 20 Jul 2020 04:43:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgGTIny (ORCPT ); Mon, 20 Jul 2020 04:43:54 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D94C061794 for ; Mon, 20 Jul 2020 01:43:53 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id f5so19314260ljj.10 for ; Mon, 20 Jul 2020 01:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=e6djTCYWEj2Fmi95lUFWKgkZcJHCyeTSf7Syl643UoYLetz7sglV0iZEAzz9bdhAWy AV2kduveWFWI+JWAlK2oNtidKKo/CEuAaKD0MJ5Pp2tRK5UEZOnqUQB+URJ8qpBiS3E0 7BLXT/fa/imiZu0Qgtj10PZL/JBmO+Pz1dtSqFtftbPH5ryJlZX1B4ohWJEXiBEEvDCm QXR5JmQwVkqYm8SkgaPhzlXf0D9fpQhWmfdlnKXyWsNJSVXFpVk2mp2087rkuizdb6pR gp9yJayr7YSyuNloyVlOeoyOmDejlgs1239X59/cPzNKO7ss8eXDNgChuv/x7qWhxATI 9lQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=CMHRftXflLOZh5dK2SxGbPhDS9ng+zvGXqGrDnI8Ujwjn9XUVU1zzFPmnVA4P9RBzq y6JBs6GJY5ykj6vDj0IjwpdpukBqPSEqQtUglVSwPajCu52gsQbiY2iF1p5Tzgc7fNSe VzrSDh+nqSwBygA1bcpsF8edVasJfzzx14FfQEwliCqIo3/j8ofws9PtSwrgP8x2xWv1 Yhmr2H7nLiOTEbWz6clKJre3pqn0R2k49CNXMUZqtW8xrARK7UOReGkixHuWyPNcRsYt ULpH4oPmBP1UABVUR4wylZ6iQ9EB9b8sV89jiWStPbld3ZqldDGusQI7eAKAIGDSznjM noPQ== X-Gm-Message-State: AOAM533Mq7MIrPORP/nexjmGqMWYUXXBrlrLc3LwtsUkGl418XLX9s98 8BSPZJlAnYEhF/sk/RQQXD1pZg== X-Google-Smtp-Source: ABdhPJxDpc+xGL9gCU4hB6aJTaR2Pfe9WrNdwYB5SAzencPCUUdqx2ZecSSoIxaZ/WyEMlHA9/Z3Zg== X-Received: by 2002:a05:651c:1057:: with SMTP id x23mr9133434ljm.116.1595234632369; Mon, 20 Jul 2020 01:43:52 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s62sm3101085lja.100.2020.07.20.01.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 01:43:51 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E7866102393; Mon, 20 Jul 2020 11:43:51 +0300 (+03) Date: Mon, 20 Jul 2020 11:43:51 +0300 From: "Kirill A. Shutemov" To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Subject: Re: [PATCH v16 06/22] mm/thp: clean up lru_add_page_tail Message-ID: <20200720084351.v3skr3pluudy6fer@box> References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2020 at 08:58:40AM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH v16 06/22] mm/thp: clean up lru_add_page_tail Date: Mon, 20 Jul 2020 11:43:51 +0300 Message-ID: <20200720084351.v3skr3pluudy6fer@box> References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=e6djTCYWEj2Fmi95lUFWKgkZcJHCyeTSf7Syl643UoYLetz7sglV0iZEAzz9bdhAWy AV2kduveWFWI+JWAlK2oNtidKKo/CEuAaKD0MJ5Pp2tRK5UEZOnqUQB+URJ8qpBiS3E0 7BLXT/fa/imiZu0Qgtj10PZL/JBmO+Pz1dtSqFtftbPH5ryJlZX1B4ohWJEXiBEEvDCm QXR5JmQwVkqYm8SkgaPhzlXf0D9fpQhWmfdlnKXyWsNJSVXFpVk2mp2087rkuizdb6pR gp9yJayr7YSyuNloyVlOeoyOmDejlgs1239X59/cPzNKO7ss8eXDNgChuv/x7qWhxATI 9lQA== Content-Disposition: inline In-Reply-To: <1594429136-20002-7-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Shi Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, yang.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org On Sat, Jul 11, 2020 at 08:58:40AM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov