From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AC2C433E0 for ; Mon, 20 Jul 2020 09:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16FE92080D for ; Mon, 20 Jul 2020 09:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728093AbgGTJyN (ORCPT ); Mon, 20 Jul 2020 05:54:13 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:58632 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbgGTJyN (ORCPT ); Mon, 20 Jul 2020 05:54:13 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 526A21C0BE7; Mon, 20 Jul 2020 11:54:10 +0200 (CEST) Date: Mon, 20 Jul 2020 11:54:09 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition Message-ID: <20200720095409.GA13137@amd> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20200716182007.18389-2-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Introduce a multicolor class that groups colored LEDs > within a LED node. >=20 > The multicolor class groups monochrome LEDs and allows controlling two > aspects of the final combined color: hue and lightness. The former is > controlled via the intensity file and the latter is controlled > via brightness file. >=20 > Acked-by: Jacek Anaszewski > Signed-off-by: Dan Murphy Thanks, applied and pushed out. > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +MultiColor LED handling under Linux > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2E.. > +Multicolor Class Control > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D AFAICT The first one should be "Multicolor" for consistency. > +config LEDS_CLASS_MULTICOLOR > + tristate "LED MultiColor Class Support" Here too. Can you send a followup patch to fix it up? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8VacEACgkQMOfwapXb+vL47gCeJCu3DvOixmoJWqLguCyuTJCL hgoAoMBx7ND/jhL5P0SKhzIqU3p9701G =px13 -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B83BC433E6 for ; Mon, 20 Jul 2020 09:55:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F268B21775 for ; Mon, 20 Jul 2020 09:55:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qdhlwODE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F268B21775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S/XzKkzHRNNRnlgeqxLB2mLpU/g3mEUItZgiKTDGDzk=; b=qdhlwODEfqcdmUCLCnfBGLokQ U2gZr/v5mXuajroSf6rR6PVRI+Ulr9c3j32BHdQ9TyvxOeAU/+pK26TWbeq/sEHSo2EIvef672IT9 lXw35urxlilEHLa5+orqmDkpeo6Fuv+eUm6NsnXTGDCkcmk9UY+cGW1H/NhKBPbjqtU0mAuuSSVSo Vw9yoq0iJgiVgKoqjAyhxB4qgKL4Bg4fY05QDoCcorEB88mjSmAnoTdm9T/VuT3u4FQrA4y4b+wa4 3z8CIjT55C/CMK1N4COpLGODtkxMLGa3twICvCPJpNioJmisDD9JUiUCkCwiXu8Fhki2OwYscNbmT YHlpqAsWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxSV2-0004cG-4D; Mon, 20 Jul 2020 09:54:21 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxSUz-0004b8-6c for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2020 09:54:18 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 526A21C0BE7; Mon, 20 Jul 2020 11:54:10 +0200 (CEST) Date: Mon, 20 Jul 2020 11:54:09 +0200 From: Pavel Machek To: Dan Murphy Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition Message-ID: <20200720095409.GA13137@amd> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-2-dmurphy@ti.com> MIME-Version: 1.0 In-Reply-To: <20200716182007.18389-2-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_055417_361404_43660D28 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Type: multipart/mixed; boundary="===============7566206809636716885==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7566206809636716885== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Introduce a multicolor class that groups colored LEDs > within a LED node. >=20 > The multicolor class groups monochrome LEDs and allows controlling two > aspects of the final combined color: hue and lightness. The former is > controlled via the intensity file and the latter is controlled > via brightness file. >=20 > Acked-by: Jacek Anaszewski > Signed-off-by: Dan Murphy Thanks, applied and pushed out. > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +MultiColor LED handling under Linux > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2E.. > +Multicolor Class Control > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D AFAICT The first one should be "Multicolor" for consistency. > +config LEDS_CLASS_MULTICOLOR > + tristate "LED MultiColor Class Support" Here too. Can you send a followup patch to fix it up? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8VacEACgkQMOfwapXb+vL47gCeJCu3DvOixmoJWqLguCyuTJCL hgoAoMBx7ND/jhL5P0SKhzIqU3p9701G =px13 -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- --===============7566206809636716885== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7566206809636716885==--