From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword
Date: Mon, 20 Jul 2020 13:40:26 +0300 [thread overview]
Message-ID: <20200720104026.GR3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200716211919.GA17378@embeddedor>
On Thu, Jul 16, 2020 at 04:19:19PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Pushed to my review and testing queue, thanks!
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index a917a2df520e..d6e35cba3065 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1372,13 +1372,13 @@ static void byt_irq_unmask(struct irq_data *d)
> switch (irqd_get_trigger_type(d)) {
> case IRQ_TYPE_LEVEL_HIGH:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_RISING:
> value |= BYT_TRIG_POS;
> break;
> case IRQ_TYPE_LEVEL_LOW:
> value |= BYT_TRIG_LVL;
> - /* fall through */
> + fallthrough;
> case IRQ_TYPE_EDGE_FALLING:
> value |= BYT_TRIG_NEG;
> break;
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-20 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 21:19 [PATCH][next] pinctrl: baytrail: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-20 10:40 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720104026.GR3703480@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.