All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH][STABLE 4.9] irqchip/gic: Atomically update affinity
Date: Mon, 20 Jul 2020 14:27:25 +0200	[thread overview]
Message-ID: <20200720122725.GB3147730@kroah.com> (raw)
In-Reply-To: <20200707153741.1935141-1-maz@kernel.org>

On Tue, Jul 07, 2020 at 04:37:41PM +0100, Marc Zyngier wrote:
> Commit 005c34ae4b44f085120d7f371121ec7ded677761 upstream.
> 
> The GIC driver uses a RMW sequence to update the affinity, and
> relies on the gic_lock_irqsave/gic_unlock_irqrestore sequences
> to update it atomically.
> 
> But these sequences only expand into anything meaningful if
> the BL_SWITCHER option is selected, which almost never happens.
> 
> It also turns out that using a RMW and locks is just as silly,
> as the GIC distributor supports byte accesses for the GICD_TARGETRn
> registers, which when used make the update atomic by definition.
> 
> Drop the terminally broken code and replace it by a byte write.
> 
> Fixes: 04c8b0f82c7d ("irqchip/gic: Make locking a BL_SWITCHER only feature")
> Cc: stable@vger.kernel.org
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>  drivers/irqchip/irq-gic.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)

Thanks for the backport, now queued up.

greg k-h

      parent reply	other threads:[~2020-07-20 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 15:37 [PATCH][STABLE 4.9] irqchip/gic: Atomically update affinity Marc Zyngier
2020-07-09 14:30 ` Sasha Levin
2020-07-20 12:27 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720122725.GB3147730@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=maz@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.