From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC811C433E6 for ; Mon, 20 Jul 2020 15:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9E9B2064B for ; Mon, 20 Jul 2020 15:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595259957; bh=GwgIP+ig8wbE/vDuBsQcjivBJySfzTgXP/rgU1Yd5/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zYwE6xQeJ586u8pLxNnyyYbVFQNKXl5t8jlni0JOvpyGvKXS6mMjNoaShWYLcz7uQ vltq+qOi1kXcztkeFCOGqYFfk7HKXKBTKkb3z1bK62n0ePgfOSFsrX9HrGAfgHoEbh c4s5Y7R9lfMlBoxWi/jYsmRdlge9MMhGyKd7ft/Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730592AbgGTPp4 (ORCPT ); Mon, 20 Jul 2020 11:45:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:40326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730570AbgGTPpu (ORCPT ); Mon, 20 Jul 2020 11:45:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8753C2064B; Mon, 20 Jul 2020 15:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595259950; bh=GwgIP+ig8wbE/vDuBsQcjivBJySfzTgXP/rgU1Yd5/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JnQaVGIsPdXJmAuHB/uxAdmv54oGvVOjJmrWcGZowC3biqi/A+HYXPHVRADJSchmX xQzn2jk1GSTf6SO+3lCWOX7juOqvlUR3MGQKtG920xh1E81Kf47v44EwpyrfzfUEJG vfmjNFvRHyw9fOsV/RzBFdqiYnzePs3ALTWSjQNc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jamal Hadi Salim , Jiri Pirko , Cong Wang , "David S. Miller" , syzbot+d411cff6ab29cc2c311b@syzkaller.appspotmail.com Subject: [PATCH 4.14 050/125] net_sched: fix a memory leak in atm_tc_init() Date: Mon, 20 Jul 2020 17:36:29 +0200 Message-Id: <20200720152805.430717873@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152802.929969555@linuxfoundation.org> References: <20200720152802.929969555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cong Wang [ Upstream commit 306381aec7c2b5a658eebca008c8a1b666536cba ] When tcf_block_get() fails inside atm_tc_init(), atm_tc_put() is called to release the qdisc p->link.q. But the flow->ref prevents it to do so, as the flow->ref is still zero. Fix this by moving the p->link.ref initialization before tcf_block_get(). Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure") Reported-and-tested-by: syzbot+d411cff6ab29cc2c311b@syzkaller.appspotmail.com Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/sch_atm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c @@ -545,15 +545,15 @@ static int atm_tc_init(struct Qdisc *sch if (!p->link.q) p->link.q = &noop_qdisc; pr_debug("atm_tc_init: link (%p) qdisc %p\n", &p->link, p->link.q); + p->link.vcc = NULL; + p->link.sock = NULL; + p->link.common.classid = sch->handle; + p->link.ref = 1; err = tcf_block_get(&p->link.block, &p->link.filter_list); if (err) return err; - p->link.vcc = NULL; - p->link.sock = NULL; - p->link.common.classid = sch->handle; - p->link.ref = 1; tasklet_init(&p->task, sch_atm_dequeue, (unsigned long)sch); return 0; }