From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07D6C433E2 for ; Mon, 20 Jul 2020 15:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8D312065E for ; Mon, 20 Jul 2020 15:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260059; bh=221b/j4YBJGJwtLatHEUMclSCzxLCqcNEjhJB+xYaSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TBlsco+wIJOY9AoMfKGHakLLbS7fNuwxOFT07ggKdBq6fSQGz/FJ0R1JfH3Gp9aJK gXj+zCcLWwtwykB7WCVHWCOdig1ViD4QwGbKi0xXZuw+ca+0psep24+J/VfiNlV/7W bVbxVDX+wVDYQsJL4rc1RegJMWymZ8t2Q5LefUzY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730788AbgGTPri (ORCPT ); Mon, 20 Jul 2020 11:47:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:42626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729480AbgGTPr2 (ORCPT ); Mon, 20 Jul 2020 11:47:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED6A02065E; Mon, 20 Jul 2020 15:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260047; bh=221b/j4YBJGJwtLatHEUMclSCzxLCqcNEjhJB+xYaSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uFj/wHqIVuJzHBhGdaShRO9Y8ZxW56apd0W+W++3jtVEKlXFDJ0q7ndh5bCKmKib3 XSbOyhil6hmvBw5LE9tuBfM53WeGUoundMq/W/16j3n1jfBoh4aJmjP28butQCbZvs OCJXe8zYrARqhULz8ZCOBiTMW0sxdavmm6hiENuY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , Jerry Snitselaar , Jarkko Sakkinen , Sasha Levin Subject: [PATCH 4.14 057/125] tpm_tis: extra chip->ops check on error path in tpm_tis_core_init Date: Mon, 20 Jul 2020 17:36:36 +0200 Message-Id: <20200720152805.780979333@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152802.929969555@linuxfoundation.org> References: <20200720152802.929969555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Averin [ Upstream commit ccf6fb858e17a8f8a914a1c6444d277cfedfeae6 ] Found by smatch: drivers/char/tpm/tpm_tis_core.c:1088 tpm_tis_core_init() warn: variable dereferenced before check 'chip->ops' (see line 979) 'chip->ops' is assigned in the beginning of function in tpmm_chip_alloc->tpm_chip_alloc and is used before first possible goto to error path. Signed-off-by: Vasily Averin Reviewed-by: Jerry Snitselaar Reviewed-by: Jarkko Sakkinen Signed-off-by: Jarkko Sakkinen Signed-off-by: Sasha Levin --- drivers/char/tpm/tpm_tis_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 9b1116501f209..c028ffd953326 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -897,7 +897,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, return 0; out_err: - if ((chip->ops != NULL) && (chip->ops->clk_enable != NULL)) + if (chip->ops->clk_enable != NULL) chip->ops->clk_enable(chip, false); tpm_tis_remove(chip); -- 2.25.1