From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00679C433E2 for ; Mon, 20 Jul 2020 16:37:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD0FE20773 for ; Mon, 20 Jul 2020 16:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595263037; bh=qcJinvA9UWAln0obTJFKjUkwzI+BlB1bSmeMSMmtkFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fHlAONwEGLGmqg7qXgcD5h8i0ZfMRBxljdVkC4QquWpdSCq4zU3opmTnLCtNIKpLk cZBt5kyeHtGRD4r0gFhXF9Ya91bYLuurKcnOzhUmr2lXx1422T9IfBtBE6UY2GKh1H 6Ez0KiM1qlCjCI5SV00pyHjVBD3lAnbbB/4DzlDI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731888AbgGTQhP (ORCPT ); Mon, 20 Jul 2020 12:37:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:48998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730721AbgGTPvv (ORCPT ); Mon, 20 Jul 2020 11:51:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F8DD2065E; Mon, 20 Jul 2020 15:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260311; bh=qcJinvA9UWAln0obTJFKjUkwzI+BlB1bSmeMSMmtkFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vfDMw69CrewEfusug8XkOezQJ3wb65nak6ue4P82D2ApCRF8PunJdHraUokJp37uu 73YnQ2nUBBdKsWG5IPiEYOuDnOX7wpxiOImC9+cxeuG7qlK3KCv66tn21iGQUD3Lax UsaR6gt/7mwAh6BZ0VDVTpH53Azh/EGW/Ct1e3Wg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Paul Menzel , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.19 056/133] ACPI: video: Use native backlight on Acer TravelMate 5735Z Date: Mon, 20 Jul 2020 17:36:43 +0200 Message-Id: <20200720152806.430939543@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152803.732195882@linuxfoundation.org> References: <20200720152803.732195882@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Menzel [ Upstream commit c41c36e900a337b4132b12ccabc97f5578248b44 ] Currently, changing the brightness of the internal display of the Acer TravelMate 5735Z does not work. Pressing the function keys or changing the slider, GNOME Shell 3.36.2 displays the OSD (five steps), but the brightness does not change. The Acer TravelMate 5735Z shipped with Windows 7 and as such does not trigger our "win8 ready" heuristic for preferring the native backlight interface. Still ACPI backlight control doesn't work on this model, where as the native (intel_video) backlight interface does work by adding `acpi_backlight=native` or `acpi_backlight=none` to Linux’ command line. So, add a quirk to force using native backlight control on this model. Link: https://bugzilla.kernel.org/show_bug.cgi?id=207835 Reviewed-by: Hans de Goede Signed-off-by: Paul Menzel Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/video_detect.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 5f0178967d14c..ab1da5e6e7e3e 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -337,6 +337,16 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "JV50"), }, }, + { + /* https://bugzilla.kernel.org/show_bug.cgi?id=207835 */ + .callback = video_detect_force_native, + .ident = "Acer TravelMate 5735Z", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 5735Z"), + DMI_MATCH(DMI_BOARD_NAME, "BA51_MV"), + }, + }, /* * Desktops which falsely report a backlight and which our heuristics -- 2.25.1