From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA030C433E7 for ; Mon, 20 Jul 2020 15:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E610206E9 for ; Mon, 20 Jul 2020 15:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260157; bh=Ii21Y4dB2dtPOuktMfoSercnM/W9406kERuSR4p265M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PL0l4ayF8nER9EnxCH9oTucIPDXSUIFoR/TvDOTVFzRXbLYDL/i6mw7qKBXewoF/X KMfHp797aXNfj3K+my1NCdz1OJuUx76iRTi9AuRrEt4gn33w9zqTdS/4vVkbGj+eRE bU30fc0cuQuwwNXInyAfnprjH/vQFJXzkGCFqPyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730994AbgGTPtQ (ORCPT ); Mon, 20 Jul 2020 11:49:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:45134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729386AbgGTPtK (ORCPT ); Mon, 20 Jul 2020 11:49:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33B1C206E9; Mon, 20 Jul 2020 15:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260149; bh=Ii21Y4dB2dtPOuktMfoSercnM/W9406kERuSR4p265M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZEbaydjhJyAuZUP1r2VgqgIYFSkx36RWvIJWxTbwTZm82RRcddvUKvStVYKhV8ak7 tJ5Mzd/lrJlmgrDduB/ZLPMbHV9VOryMxnmQAXu29xwMK/YKmDckwt7c71icb350DB O6w2YYm3+mx9JyK4c9UAIECHTxl+kyorraezLbS8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yariv , Dmitry Torokhov , Jiri Kosina Subject: [PATCH 4.14 094/125] HID: magicmouse: do not set up autorepeat Date: Mon, 20 Jul 2020 17:37:13 +0200 Message-Id: <20200720152807.562768192@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152802.929969555@linuxfoundation.org> References: <20200720152802.929969555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Torokhov commit 6363d2065cd399cf9d6dc9d08c437f8658831100 upstream. Neither the trackpad, nor the mouse want input core to generate autorepeat events for their buttons, so let's reset the bit (as hid-input sets it for these devices based on the usage vendor code). Cc: stable@vger.kernel.org Reported-by: Yariv Tested-by: Yariv Signed-off-by: Dmitry Torokhov Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-magicmouse.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/hid/hid-magicmouse.c +++ b/drivers/hid/hid-magicmouse.c @@ -451,6 +451,12 @@ static int magicmouse_setup_input(struct __set_bit(MSC_RAW, input->mscbit); } + /* + * hid-input may mark device as using autorepeat, but neither + * the trackpad, nor the mouse actually want it. + */ + __clear_bit(EV_REP, input->evbit); + return 0; }