From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849B5C433F8 for ; Mon, 20 Jul 2020 16:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51E38207DD for ; Mon, 20 Jul 2020 16:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261487; bh=PwYgY0PClXBj/wQ9kZvqrTpH+5i2U9MhVT4YdPtSaoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=m9H9OIRCog5FFSW+15mDjIk8ld6cK7RHwIJeyt1TBGa1vu+RtNenQrRRjylGRhFRQ Mzg1M/MsbKiRi/CKDVaSMMTqpQmqmy25w0a53niqaJEugBoYv+K1f96KiY6kdIPaRE /r0SIUrA9ZxRR27qK++45dZWfYe5k3wic1u3XovQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733072AbgGTQL0 (ORCPT ); Mon, 20 Jul 2020 12:11:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:50314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732732AbgGTQLS (ORCPT ); Mon, 20 Jul 2020 12:11:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EFA82065E; Mon, 20 Jul 2020 16:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595261478; bh=PwYgY0PClXBj/wQ9kZvqrTpH+5i2U9MhVT4YdPtSaoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NHp3ulDoslfUyP1LIUvxA7/gJ71rjB4NMsQ9UGez/9c8ZKNE80v+gCfydpdp0VmKg rUs2SGd4ivy3b+X4w5S2w2Xn8a4yH+32O5NpgUirJLrSyMLdgI4YfHqVOLzrYWbmJE O1Ik+8sdMNrJ+if+j5Kpg5NnIkzXjwjxegwRGIsc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aharon Landau , Maor Gottlieb , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 5.7 130/244] RDMA/mlx5: Verify that QP is created with RQ or SQ Date: Mon, 20 Jul 2020 17:36:41 +0200 Message-Id: <20200720152832.023451568@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152825.863040590@linuxfoundation.org> References: <20200720152825.863040590@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aharon Landau commit 0eacc574aae7300bf46c10c7116c3ba5825505b7 upstream. RAW packet QP and underlay QP must be created with either RQ or SQ, check that. Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters") Link: https://lore.kernel.org/r/20200427154636.381474-37-leon@kernel.org Signed-off-by: Aharon Landau Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx5/qp.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1525,6 +1525,8 @@ static int create_raw_packet_qp(struct m u16 uid = to_mpd(pd)->uid; u32 out[MLX5_ST_SZ_DW(create_tir_out)] = {}; + if (!qp->sq.wqe_cnt && !qp->rq.wqe_cnt) + return -EINVAL; if (qp->sq.wqe_cnt) { err = create_raw_packet_qp_tis(dev, qp, sq, tdn, pd); if (err)