From: Kalle Valo <kvalo@codeaurora.org>
To: "Saheed O. Bolarinwa" <refactormyself@gmail.com>
Cc: skhan@linuxfoundation.org, linux-pci@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Subject: Re: [PATCH 3/14 v3] ath9k: Check the return value of pcie_capability_read_*()
Date: Mon, 20 Jul 2020 17:09:51 +0000 (UTC) [thread overview]
Message-ID: <20200720170951.3BFFDC433C9@smtp.codeaurora.org> (raw)
In-Reply-To: <20200713175529.29715-2-refactormyself@gmail.com>
"Saheed O. Bolarinwa" <refactormyself@gmail.com> wrote:
> On failure pcie_capability_read_dword() sets it's last parameter, val
> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
> failure. This would introduce a bug because (x & x) == (~0 & x).
>
> This bug can be avoided without changing the function's behaviour if the
> return value of pcie_capability_read_dword is checked to confirm success.
>
> Check the return value of pcie_capability_read_dword() to ensure success.
>
> Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9a8ab2bfb678 ath9k: Check the return value of pcie_capability_read_*()
--
https://patchwork.kernel.org/patch/11660731/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-07-20 17:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 17:55 [PATCH 1/14 v3] IB/hfi1: Check the return value of pcie_capability_read_*() Saheed O. Bolarinwa
2020-07-13 17:55 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa
2020-07-13 17:09 ` Jason Gunthorpe
2020-07-13 17:09 ` [Linux-kernel-mentees] " Jason Gunthorpe
2020-07-13 17:55 ` [PATCH 3/14 v3] ath9k: " Saheed O. Bolarinwa
2020-07-13 17:55 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa
2020-07-20 17:09 ` Kalle Valo [this message]
2020-07-20 17:09 ` Kalle Valo
2020-07-13 17:55 ` [PATCH 4/14 v3] iwlegacy: " Saheed O. Bolarinwa
2020-07-13 17:55 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa
2020-07-15 16:47 ` Kalle Valo
2020-07-15 16:47 ` Kalle Valo
2020-07-13 17:55 ` [PATCH 8/14 v3] PCI/ACPI: " Saheed O. Bolarinwa
2020-07-13 17:55 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa
2020-07-14 13:27 ` Rafael J. Wysocki
2020-07-14 13:27 ` [Linux-kernel-mentees] " Rafael J. Wysocki
2020-07-13 17:55 ` [PATCH 12/14 v3] PCI/AER: " Saheed O. Bolarinwa
2020-07-13 17:55 ` [Linux-kernel-mentees] " Saheed O. Bolarinwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720170951.3BFFDC433C9@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=refactormyself@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.