From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F43FC433E2 for ; Mon, 20 Jul 2020 17:37:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 821B320702 for ; Mon, 20 Jul 2020 17:37:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 821B320702 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxZjN-0007br-6X; Mon, 20 Jul 2020 17:37:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxZjM-0007bi-89 for xen-devel@lists.xenproject.org; Mon, 20 Jul 2020 17:37:36 +0000 X-Inumbo-ID: b228c418-caaf-11ea-84ac-bc764e2007e4 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b228c418-caaf-11ea-84ac-bc764e2007e4; Mon, 20 Jul 2020 17:37:35 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1jxZjJ-000ILK-Oo; Mon, 20 Jul 2020 17:37:33 +0000 Date: Mon, 20 Jul 2020 18:37:33 +0100 From: Tim Deegan To: Jan Beulich Subject: Re: [PATCH 5/5] x86/shadow: l3table[] and gl3e[] are HVM only Message-ID: <20200720173733.GA70485@deinos.phlegethon.org> References:

<20200718182037.GA48915@deinos.phlegethon.org> <1baa0d50-86a4-b0ba-d43a-ad0c0446b54b@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1baa0d50-86a4-b0ba-d43a-ad0c0446b54b@suse.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , "xen-devel@lists.xenproject.org" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Andrew Cooper Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" At 10:55 +0200 on 20 Jul (1595242521), Jan Beulich wrote: > On 18.07.2020 20:20, Tim Deegan wrote: > > At 12:00 +0200 on 15 Jul (1594814409), Jan Beulich wrote: > >> ... by the very fact that they're 3-level specific, while PV always gets > >> run in 4-level mode. This requires adding some seemingly redundant > >> #ifdef-s - some of them will be possible to drop again once 2- and > >> 3-level guest code doesn't get built anymore in !HVM configs, but I'm > >> afraid there's still quite a bit of disentangling work to be done to > >> make this possible. > >> > >> Signed-off-by: Jan Beulich > > > > Looks good. It seems like the new code for '3-level non-HVM' in > > guest-walks ought to have some sort of assert-unreachable in them too > > - or is there a reason to to? > > You mean this piece of code > > +#elif !defined(CONFIG_HVM) > + (void)root_gfn; > + memset(gw, 0, sizeof(*gw)); > + return false; > +#else /* PAE */ > > If so - sure, ASSERT_UNREACHABLE() could be added there. It simply > didn't occur to me. I take it your ack for the entire series holds > here with this addition. Yes, it does. Thanks! Tim.