From: Boris Burkov <boris@bur.io>
To: Eryu Guan <guan@eryu.me>, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: [PATCH v4] generic: add a test for umount racing mount
Date: Mon, 20 Jul 2020 12:05:56 -0700 [thread overview]
Message-ID: <20200720190556.3292884-1-boris@bur.io> (raw)
In-Reply-To: <20200719171853.GE2557159@desktop>
Test if dirtying many inodes (which can delay umount) then
unmounting and quickly mounting again causes the mount to fail.
A race, which breaks the test in btrfs, is fixed by the patch:
"btrfs: fix mount failure caused by race with umount"
Signed-off-by: Boris Burkov <boris@bur.io>
---
- dd to XFS_IO_PROG
- 1M writes to 4k writes
tests/generic/603 | 53 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/603.out | 2 ++
tests/generic/group | 1 +
3 files changed, 56 insertions(+)
create mode 100755 tests/generic/603
create mode 100644 tests/generic/603.out
diff --git a/tests/generic/603 b/tests/generic/603
new file mode 100755
index 00000000..90f0d1d3
--- /dev/null
+++ b/tests/generic/603
@@ -0,0 +1,53 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Facebook All Rights Reserved.
+#
+# FS QA Test 603
+#
+# Evicting dirty inodes can take a long time during umount.
+# Check that a new mount racing with such a delayed umount succeeds.
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs generic
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs > /dev/null 2>&1
+_scratch_mount
+for i in $(seq 0 500)
+do
+ $XFS_IO_PROG -c "pwrite 0 4K" $SCRATCH_MNT/$i >/dev/null 2>&1
+done
+_scratch_unmount &
+_scratch_mount
+wait
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/603.out b/tests/generic/603.out
new file mode 100644
index 00000000..6810da89
--- /dev/null
+++ b/tests/generic/603.out
@@ -0,0 +1,2 @@
+QA output created by 603
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index d9ab9a31..c0ace35b 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -605,3 +605,4 @@
600 auto quick quota
601 auto quick quota
602 auto quick encrypt
+603 auto quick
--
2.24.1
next prev parent reply other threads:[~2020-07-20 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 0:55 [PATCH] btrfs: add a test for umount racing mount Boris Burkov
2020-07-10 14:35 ` Josef Bacik
2020-07-10 17:18 ` [PATCH v2] generic: " Boris Burkov
2020-07-10 17:52 ` Josef Bacik
2020-07-12 11:37 ` Zorro Lang
2020-07-13 20:46 ` [PATCH v3] " Boris Burkov
2020-07-14 5:21 ` Zorro Lang
2020-07-19 17:18 ` Eryu Guan
2020-07-20 19:05 ` Boris Burkov [this message]
2020-07-21 5:03 ` [PATCH v4] " Zorro Lang
2020-07-19 17:14 ` [PATCH v2] " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720190556.3292884-1-boris@bur.io \
--to=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.