From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, chriscool@tuxfamily.org
Subject: Re: [PATCH 0/4] upload-pack: custom allowed object filters
Date: Mon, 20 Jul 2020 16:09:34 -0400 [thread overview]
Message-ID: <20200720200934.GC91942@syl.lan> (raw)
In-Reply-To: <20200708084136.GA2324177@coredump.intra.peff.net>
On Wed, Jul 08, 2020 at 04:41:36AM -0400, Jeff King wrote:
> On Thu, Jul 02, 2020 at 04:06:14PM -0400, Taylor Blau wrote:
>
> > [uploadpack]
> > allowAnySHA1InWant = true
> > allowFilter = true
> > [uploadpack "filter"]
> > allow = false
> > [uploadpack "filter.blob:limit"]
> > allow = true
> > [uploadpack "filter.blob:none"]
> > allow = true
> > [uploadpack "filter.tree"]
> > allow = true
> > maxDepth = 0
>
> I thought the previous discussion landed on:
>
> uploadpackfilter.blob:none.allow
>
> etc, to avoid the confusing appearance of four-level keys (and the weird
> case sensitivity implications that would cause).
Yup, I agree. I added a little bit more detail to this response in
another email that I posted shortly above in this thread.
Rest assured that I haven't forgotten about this series, I've just been
busy and not feeling too pressured to get back to it since we're well
into the release-candidate phase, and shouldn't be worrying about this
until after 2.28.0.
If you're interested, I have what I will eventually call 'v2' of this
series at:
https://github.com/ttaylorr/git/tree/tb/upload-pack-filter-config
> -Peff
Thanks,
Taylor
next prev parent reply other threads:[~2020-07-20 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 20:06 [PATCH 0/4] upload-pack: custom allowed object filters Taylor Blau
2020-07-02 20:06 ` [PATCH 1/4] list_objects_filter_options: introduce 'list_object_filter_config_name' Taylor Blau
2020-07-02 20:06 ` [PATCH 2/4] upload-pack.c: allow banning certain object filter(s) Taylor Blau
2020-07-08 8:45 ` Jeff King
2020-07-20 20:05 ` Taylor Blau
2020-07-15 10:00 ` SZEDER Gábor
2020-07-15 10:55 ` Jeff King
2020-07-20 20:07 ` Taylor Blau
2020-07-20 20:21 ` Jeff King
2020-07-22 9:17 ` SZEDER Gábor
2020-07-22 20:15 ` Taylor Blau
2020-07-23 1:41 ` Junio C Hamano
2020-07-23 1:50 ` Taylor Blau
2020-07-22 9:21 ` SZEDER Gábor
2020-07-22 20:16 ` Taylor Blau
2020-07-23 7:51 ` SZEDER Gábor
2020-07-23 14:13 ` Taylor Blau
2020-07-02 20:06 ` [PATCH 3/4] upload-pack.c: pass 'struct list_objects_filter_options *' Taylor Blau
2020-07-02 20:06 ` [PATCH 4/4] upload-pack.c: introduce 'uploadpack.filter.tree.maxDepth' Taylor Blau
2020-07-15 10:11 ` SZEDER Gábor
2020-07-08 8:41 ` [PATCH 0/4] upload-pack: custom allowed object filters Jeff King
2020-07-20 20:09 ` Taylor Blau [this message]
2020-07-21 20:06 ` Junio C Hamano
2020-07-21 20:27 ` Taylor Blau
2020-07-21 22:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720200934.GC91942@syl.lan \
--to=me@ttaylorr.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.