From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E76C433E7 for ; Tue, 21 Jul 2020 07:33:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ADBC2080D for ; Tue, 21 Jul 2020 07:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uyIY9Iej" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ADBC2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79B616E4A5; Tue, 21 Jul 2020 07:32:57 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2684F6E499 for ; Tue, 21 Jul 2020 07:32:52 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id a15so5182754wrh.10 for ; Tue, 21 Jul 2020 00:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SH3RbtCrYO14PYMTjYuYB95AsJJwceXoHKCr8ENGRpE=; b=uyIY9IejzqqfbyZ5QpbKDeceYiLOwBcWEopgYFEbhbinBHe89E/NYKmBp++khNP7Wl y9eVjdMiB6Vy3dGQoc1F3JY/Zruj/Ii9uaAHqdf82p54nfPQZ/cP5DcimchNUa1Jjz1n pxod2jkSuelcThXLLvnESdjBcPwUGxpk8XYdZ26gxprOiO1fLK4U8FXQo7VG9oiDcQCW ZbCxXyPAiGHN1+Jd+xedmJteKeGnkT3V1UJ/8kKWBXB3C4v8eWXLhHj1QX3L0k4abZ8S KBAigEusqmdC4k+EJeH5Ck7ZQ2UroNgmW/ScYulYI1JQY/T9G+kGdHHcHOqyQEHSPnhb NdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SH3RbtCrYO14PYMTjYuYB95AsJJwceXoHKCr8ENGRpE=; b=Bxk5WpjB0e4iWiz1zH/Rq8bmmcW19YEbjhkwiBVt4+z8JemCEMbNACWviOkq89Y+LV w/uZkAgXCIqZKF/VdfkWdTUO389dJz85rCWIA2OOUMmQI1//Tde+Zfq7+ZqzGZ7HaOZR otAAduXl9rED0JhRyrIprd/YwC1Lv38VdsuIJBd/NfJn0H2hCeLvPhJJhazy0yAzQJof tx1MUeIIuZtD9zshftdzgUg/nshLwXBWqsJe64cKk/wq1C58nP+FZ+rwjwHJcAcGBRW3 xWjHRx1hhGQVmskUOyyRRU6vareSgMGUcBc4r5l2odAtD6vmPgozXyYIf8ZYKqzTFCj1 mVIw== X-Gm-Message-State: AOAM532ty50EFMptkzwrkT9FQuyhgCFwu1+7TFfsnlRWgDelATxWsdt8 Mh+w3c+aRRR5j99D8YV+8Sk5yJRJ X-Google-Smtp-Source: ABdhPJyVZ68hkeiSErc/QJwKbChC1vgep0tclV0cibzNII1YmLtvNLsz2PxhXNQ0X1VgaD4Zy7iOqA== X-Received: by 2002:adf:e68f:: with SMTP id r15mr16883834wrm.196.1595316770480; Tue, 21 Jul 2020 00:32:50 -0700 (PDT) Received: from abel.fritz.box ([2a02:908:1252:fb60:5eb1:eb29:dadc:7fc5]) by smtp.gmail.com with ESMTPSA id s4sm29740896wre.53.2020.07.21.00.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 00:32:50 -0700 (PDT) From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" X-Google-Original-From: =?UTF-8?q?Christian=20K=C3=B6nig?= To: dri-devel@lists.freedesktop.org Subject: [PATCH 04/11] drm/ttm: cleanup coding style and implementation. Date: Tue, 21 Jul 2020 09:32:38 +0200 Message-Id: <20200721073245.2484-4-christian.koenig@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200721073245.2484-1-christian.koenig@amd.com> References: <20200721073245.2484-1-christian.koenig@amd.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Madhav.Chauhan@amd.com, michael.j.ruhl@intel.com, tzimmermann@suse.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T25seSBmdW5jdGlvbmFsIGNoYW5nZSBpcyB0byBhbHdheXMga2VlcCBpb19yZXNlcnZlZF9jb3Vu dCB1cCB0byBkYXRlCmZvciBkZWJ1Z2dpbmcgZXZlbiB3aGVuIGl0IGlzIG5vdCB1c2VkIG90aGVy d2lzZS4KClNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib191dGlsLmMgfCA5NyArKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9u cygrKSwgNDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3R0bS90 dG1fYm9fdXRpbC5jIGIvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdXRpbC5jCmluZGV4IDZj MDVmNGZkMTVhZS4uN2ZiM2UwYmNiYWI0IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vdHRt L3R0bV9ib191dGlsLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdXRpbC5jCkBA IC0xMTUsMzkgKzExNSwzNSBAQCBzdGF0aWMgaW50IHR0bV9tZW1faW9fZXZpY3Qoc3RydWN0IHR0 bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4pCiB7CiAJc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0ICpi bzsKIAotCWlmICghbWFuLT51c2VfaW9fcmVzZXJ2ZV9scnUgfHwgbGlzdF9lbXB0eSgmbWFuLT5p b19yZXNlcnZlX2xydSkpCisJYm8gPSBsaXN0X2ZpcnN0X2VudHJ5X29yX251bGwoJm1hbi0+aW9f cmVzZXJ2ZV9scnUsCisJCQkJICAgICAgc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0LAorCQkJCSAg ICAgIGlvX3Jlc2VydmVfbHJ1KTsKKwlpZiAoIWJvKQogCQlyZXR1cm4gLUVOT1NQQzsKIAotCWJv ID0gbGlzdF9maXJzdF9lbnRyeSgmbWFuLT5pb19yZXNlcnZlX2xydSwKLQkJCSAgICAgIHN0cnVj dCB0dG1fYnVmZmVyX29iamVjdCwKLQkJCSAgICAgIGlvX3Jlc2VydmVfbHJ1KTsKIAlsaXN0X2Rl bF9pbml0KCZiby0+aW9fcmVzZXJ2ZV9scnUpOwogCXR0bV9ib191bm1hcF92aXJ0dWFsX2xvY2tl ZChibyk7Ci0KIAlyZXR1cm4gMDsKIH0KIAotCiBpbnQgdHRtX21lbV9pb19yZXNlcnZlKHN0cnVj dCB0dG1fYm9fZGV2aWNlICpiZGV2LAogCQkgICAgICAgc3RydWN0IHR0bV9tZW1fcmVnICptZW0p CiB7CiAJc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4gPSAmYmRldi0+bWFuW21lbS0+ bWVtX3R5cGVdOwotCWludCByZXQgPSAwOworCWludCByZXQ7CisKKwlpZiAobWVtLT5idXMuaW9f cmVzZXJ2ZWRfY291bnQrKykKKwkJcmV0dXJuIDA7CiAKIAlpZiAoIWJkZXYtPmRyaXZlci0+aW9f bWVtX3Jlc2VydmUpCiAJCXJldHVybiAwOwotCWlmIChsaWtlbHkoIW1hbi0+dXNlX2lvX3Jlc2Vy dmVfbHJ1KSkKLQkJcmV0dXJuIGJkZXYtPmRyaXZlci0+aW9fbWVtX3Jlc2VydmUoYmRldiwgbWVt KTsKIAotCWlmIChiZGV2LT5kcml2ZXItPmlvX21lbV9yZXNlcnZlICYmCi0JICAgIG1lbS0+YnVz LmlvX3Jlc2VydmVkX2NvdW50KysgPT0gMCkgewogcmV0cnk6Ci0JCXJldCA9IGJkZXYtPmRyaXZl ci0+aW9fbWVtX3Jlc2VydmUoYmRldiwgbWVtKTsKLQkJaWYgKHJldCA9PSAtRU5PU1BDKSB7Ci0J CQlyZXQgPSB0dG1fbWVtX2lvX2V2aWN0KG1hbik7Ci0JCQlpZiAocmV0ID09IDApCi0JCQkJZ290 byByZXRyeTsKLQkJfQorCXJldCA9IGJkZXYtPmRyaXZlci0+aW9fbWVtX3Jlc2VydmUoYmRldiwg bWVtKTsKKwlpZiAocmV0ID09IC1FTk9TUEMpIHsKKwkJcmV0ID0gdHRtX21lbV9pb19ldmljdCht YW4pOworCQlpZiAocmV0ID09IDApCisJCQlnb3RvIHJldHJ5OwogCX0KIAlyZXR1cm4gcmV0Owog fQpAQCAtMTU1LDM1ICsxNTEsMzEgQEAgaW50IHR0bV9tZW1faW9fcmVzZXJ2ZShzdHJ1Y3QgdHRt X2JvX2RldmljZSAqYmRldiwKIHZvaWQgdHRtX21lbV9pb19mcmVlKHN0cnVjdCB0dG1fYm9fZGV2 aWNlICpiZGV2LAogCQkgICAgIHN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtKQogewotCXN0cnVjdCB0 dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuID0gJmJkZXYtPm1hblttZW0tPm1lbV90eXBlXTsKLQot CWlmIChsaWtlbHkoIW1hbi0+dXNlX2lvX3Jlc2VydmVfbHJ1KSkKKwlpZiAoLS1tZW0tPmJ1cy5p b19yZXNlcnZlZF9jb3VudCkKIAkJcmV0dXJuOwogCi0JaWYgKGJkZXYtPmRyaXZlci0+aW9fbWVt X3Jlc2VydmUgJiYKLQkgICAgLS1tZW0tPmJ1cy5pb19yZXNlcnZlZF9jb3VudCA9PSAwICYmCi0J ICAgIGJkZXYtPmRyaXZlci0+aW9fbWVtX2ZyZWUpCi0JCWJkZXYtPmRyaXZlci0+aW9fbWVtX2Zy ZWUoYmRldiwgbWVtKTsKKwlpZiAoIWJkZXYtPmRyaXZlci0+aW9fbWVtX2ZyZWUpCisJCXJldHVy bjsKIAorCWJkZXYtPmRyaXZlci0+aW9fbWVtX2ZyZWUoYmRldiwgbWVtKTsKIH0KIAogaW50IHR0 bV9tZW1faW9fcmVzZXJ2ZV92bShzdHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3QgKmJvKQogeworCXN0 cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuID0gJmJvLT5iZGV2LT5tYW5bYm8tPm1lbS5t ZW1fdHlwZV07CiAJc3RydWN0IHR0bV9tZW1fcmVnICptZW0gPSAmYm8tPm1lbTsKIAlpbnQgcmV0 OwogCi0JaWYgKCFtZW0tPmJ1cy5pb19yZXNlcnZlZF92bSkgewotCQlzdHJ1Y3QgdHRtX21lbV90 eXBlX21hbmFnZXIgKm1hbiA9Ci0JCQkmYm8tPmJkZXYtPm1hblttZW0tPm1lbV90eXBlXTsKKwlp ZiAobWVtLT5idXMuaW9fcmVzZXJ2ZWRfdm0pCisJCXJldHVybiAwOwogCi0JCXJldCA9IHR0bV9t ZW1faW9fcmVzZXJ2ZShiby0+YmRldiwgbWVtKTsKLQkJaWYgKHVubGlrZWx5KHJldCAhPSAwKSkK LQkJCXJldHVybiByZXQ7Ci0JCW1lbS0+YnVzLmlvX3Jlc2VydmVkX3ZtID0gdHJ1ZTsKLQkJaWYg KG1hbi0+dXNlX2lvX3Jlc2VydmVfbHJ1KQotCQkJbGlzdF9hZGRfdGFpbCgmYm8tPmlvX3Jlc2Vy dmVfbHJ1LAotCQkJCSAgICAgICZtYW4tPmlvX3Jlc2VydmVfbHJ1KTsKLQl9CisJcmV0ID0gdHRt X21lbV9pb19yZXNlcnZlKGJvLT5iZGV2LCBtZW0pOworCWlmICh1bmxpa2VseShyZXQgIT0gMCkp CisJCXJldHVybiByZXQ7CisJbWVtLT5idXMuaW9fcmVzZXJ2ZWRfdm0gPSB0cnVlOworCWlmICht YW4tPnVzZV9pb19yZXNlcnZlX2xydSkKKwkJbGlzdF9hZGRfdGFpbCgmYm8tPmlvX3Jlc2VydmVf bHJ1LAorCQkJICAgICAgJm1hbi0+aW9fcmVzZXJ2ZV9scnUpOwogCXJldHVybiAwOwogfQogCkBA IC0xOTEsMTUgKzE4MywxNyBAQCB2b2lkIHR0bV9tZW1faW9fZnJlZV92bShzdHJ1Y3QgdHRtX2J1 ZmZlcl9vYmplY3QgKmJvKQogewogCXN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtID0gJmJvLT5tZW07 CiAKLQlpZiAobWVtLT5idXMuaW9fcmVzZXJ2ZWRfdm0pIHsKLQkJbWVtLT5idXMuaW9fcmVzZXJ2 ZWRfdm0gPSBmYWxzZTsKLQkJbGlzdF9kZWxfaW5pdCgmYm8tPmlvX3Jlc2VydmVfbHJ1KTsKLQkJ dHRtX21lbV9pb19mcmVlKGJvLT5iZGV2LCBtZW0pOwotCX0KKwlpZiAoIW1lbS0+YnVzLmlvX3Jl c2VydmVkX3ZtKQorCQlyZXR1cm47CisKKwltZW0tPmJ1cy5pb19yZXNlcnZlZF92bSA9IGZhbHNl OworCWxpc3RfZGVsX2luaXQoJmJvLT5pb19yZXNlcnZlX2xydSk7CisJdHRtX21lbV9pb19mcmVl KGJvLT5iZGV2LCBtZW0pOwogfQogCi1zdGF0aWMgaW50IHR0bV9tZW1fcmVnX2lvcmVtYXAoc3Ry dWN0IHR0bV9ib19kZXZpY2UgKmJkZXYsIHN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtLAotCQkJdm9p ZCAqKnZpcnR1YWwpCitzdGF0aWMgaW50IHR0bV9tZW1fcmVnX2lvcmVtYXAoc3RydWN0IHR0bV9i b19kZXZpY2UgKmJkZXYsCisJCQkgICAgICAgc3RydWN0IHR0bV9tZW1fcmVnICptZW0sCisJCQkg ICAgICAgdm9pZCAqKnZpcnR1YWwpCiB7CiAJc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICpt YW4gPSAmYmRldi0+bWFuW21lbS0+bWVtX3R5cGVdOwogCWludCByZXQ7CkBAIC0yMTYsOSArMjEw LDExIEBAIHN0YXRpYyBpbnQgdHRtX21lbV9yZWdfaW9yZW1hcChzdHJ1Y3QgdHRtX2JvX2Rldmlj ZSAqYmRldiwgc3RydWN0IHR0bV9tZW1fcmVnICptCiAJCWFkZHIgPSBtZW0tPmJ1cy5hZGRyOwog CX0gZWxzZSB7CiAJCWlmIChtZW0tPnBsYWNlbWVudCAmIFRUTV9QTF9GTEFHX1dDKQotCQkJYWRk ciA9IGlvcmVtYXBfd2MobWVtLT5idXMuYmFzZSArIG1lbS0+YnVzLm9mZnNldCwgbWVtLT5idXMu c2l6ZSk7CisJCQlhZGRyID0gaW9yZW1hcF93YyhtZW0tPmJ1cy5iYXNlICsgbWVtLT5idXMub2Zm c2V0LAorCQkJCQkgIG1lbS0+YnVzLnNpemUpOwogCQllbHNlCi0JCQlhZGRyID0gaW9yZW1hcCht ZW0tPmJ1cy5iYXNlICsgbWVtLT5idXMub2Zmc2V0LCBtZW0tPmJ1cy5zaXplKTsKKwkJCWFkZHIg PSBpb3JlbWFwKG1lbS0+YnVzLmJhc2UgKyBtZW0tPmJ1cy5vZmZzZXQsCisJCQkJICAgICAgIG1l bS0+YnVzLnNpemUpOwogCQlpZiAoIWFkZHIpIHsKIAkJCSh2b2lkKSB0dG1fbWVtX2lvX2xvY2so bWFuLCBmYWxzZSk7CiAJCQl0dG1fbWVtX2lvX2ZyZWUoYmRldiwgbWVtKTsKQEAgLTIzMCw4ICsy MjYsOSBAQCBzdGF0aWMgaW50IHR0bV9tZW1fcmVnX2lvcmVtYXAoc3RydWN0IHR0bV9ib19kZXZp Y2UgKmJkZXYsIHN0cnVjdCB0dG1fbWVtX3JlZyAqbQogCXJldHVybiAwOwogfQogCi1zdGF0aWMg dm9pZCB0dG1fbWVtX3JlZ19pb3VubWFwKHN0cnVjdCB0dG1fYm9fZGV2aWNlICpiZGV2LCBzdHJ1 Y3QgdHRtX21lbV9yZWcgKm1lbSwKLQkJCSB2b2lkICp2aXJ0dWFsKQorc3RhdGljIHZvaWQgdHRt X21lbV9yZWdfaW91bm1hcChzdHJ1Y3QgdHRtX2JvX2RldmljZSAqYmRldiwKKwkJCQlzdHJ1Y3Qg dHRtX21lbV9yZWcgKm1lbSwKKwkJCQl2b2lkICp2aXJ0dWFsKQogewogCXN0cnVjdCB0dG1fbWVt X3R5cGVfbWFuYWdlciAqbWFuOwogCkBAIC01MTMsMTEgKzUxMCwxMyBAQCBzdGF0aWMgaW50IHR0 bV9ib19pb3JlbWFwKHN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8sCiAJfSBlbHNlIHsKIAkJ bWFwLT5ib19rbWFwX3R5cGUgPSB0dG1fYm9fbWFwX2lvbWFwOwogCQlpZiAobWVtLT5wbGFjZW1l bnQgJiBUVE1fUExfRkxBR19XQykKLQkJCW1hcC0+dmlydHVhbCA9IGlvcmVtYXBfd2MoYm8tPm1l bS5idXMuYmFzZSArIGJvLT5tZW0uYnVzLm9mZnNldCArIG9mZnNldCwKKwkJCW1hcC0+dmlydHVh bCA9IGlvcmVtYXBfd2MoYm8tPm1lbS5idXMuYmFzZSArCisJCQkJCQkgIGJvLT5tZW0uYnVzLm9m ZnNldCArIG9mZnNldCwKIAkJCQkJCSAgc2l6ZSk7CiAJCWVsc2UKLQkJCW1hcC0+dmlydHVhbCA9 IGlvcmVtYXAoYm8tPm1lbS5idXMuYmFzZSArIGJvLT5tZW0uYnVzLm9mZnNldCArIG9mZnNldCwK LQkJCQkJCSAgICAgICBzaXplKTsKKwkJCW1hcC0+dmlydHVhbCA9IGlvcmVtYXAoYm8tPm1lbS5i dXMuYmFzZSArCisJCQkJCSAgICAgICBiby0+bWVtLmJ1cy5vZmZzZXQgKyBvZmZzZXQsCisJCQkJ CSAgICAgICBzaXplKTsKIAl9CiAJcmV0dXJuICghbWFwLT52aXJ0dWFsKSA/IC1FTk9NRU0gOiAw OwogfQotLSAKMi4xNy4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK