From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD58C433E3 for ; Tue, 21 Jul 2020 11:52:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 254BB2080D for ; Tue, 21 Jul 2020 11:52:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TgrGhm+v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729777AbgGULwv (ORCPT ); Tue, 21 Jul 2020 07:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgGULwu (ORCPT ); Tue, 21 Jul 2020 07:52:50 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD433C061794 for ; Tue, 21 Jul 2020 04:52:49 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so20813833wrj.13 for ; Tue, 21 Jul 2020 04:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YZopNL5/8ANY4qnCt9+wKywvq9+QBDbxQFIaGJPGSkU=; b=TgrGhm+v1Mg3jVuL3BVaIhy8BL4lZKWs1CJ5bFyF8NCqc/f9wNyORftQhIAIS+awPP lXfjUjWffFMBQ2bsP4cZY1Kvkw1IR7iTvP/AeVPsgUtQPuf/ew4WV66IVqGxg59czy1/ 0hK9NHIXNYTuW0pWAP/TbkSXMR7X1C+GnBPEeK5VP1a06mrAejxwDn7uvoHrW5qMXraU VM/Xx8uECxzqCY48+v4TYcTNadfgAyqfTTPPZXZpBR8Ty4ZeeetMqIq3iRLUZ1P/eT2i +/YN/KGYQ+p6Cv2VDBkyV0d4+mhKQMWnvCkYPI75nGeG2dpPF3ImzwWb8hq4rZiOYjiN etyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YZopNL5/8ANY4qnCt9+wKywvq9+QBDbxQFIaGJPGSkU=; b=OGxPzWrZ4uX5srRhFxavN38jL8v5Mh/p4IaUzx7LlhUhe0OsQAfO4lpiUEeUzkpvyM i95wh34orAiSkIOD18foXbmqcr4JYvbRCvFgEuJUt3dtd3rwiATnDzMSHFPzFvqlqQZM +Bd59J/snh4N89vdfqs3Vbzlyqz4kHx26KMAkzYa2t++kPVrndyG1I8PUSzoP5br5xeq 4yytS06SELO4CGGsuuWNJXpoPlzUm/ieAawrBZo5gDI943v4YW7gVIn3O/6QXtH+OiSA XXq4I43Q3sOId8rqpWkElz3+d7z93tM6GGhLmUep2xAdHIL3YzlXbPOnIg8b/Ag1HU1C 2v6Q== X-Gm-Message-State: AOAM531OI+K482yBq/XgaGPcclz3IlkRgdUXhfDHB4LeYbS1o4ot0C9K uUGXTroNhQX79xN6L8qujm5Pww== X-Google-Smtp-Source: ABdhPJzkuMo6BVRg+eIcLsNrunYrL7MrNDfMCxb56XFQ8NXNkSdiOirXEPWIr6xsfVjqdIMtGKLThA== X-Received: by 2002:a5d:490c:: with SMTP id x12mr13034598wrq.238.1595332368446; Tue, 21 Jul 2020 04:52:48 -0700 (PDT) Received: from dell ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id s203sm3250315wms.32.2020.07.21.04.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 04:52:47 -0700 (PDT) Date: Tue, 21 Jul 2020 12:52:46 +0100 From: Lee Jones To: Felipe Balbi Cc: Minas Harutyunyan , "gregkh@linuxfoundation.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Ben Dooks Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 Message-ID: <20200721115246.GE621928@dell> References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> <87blk9p5ia.fsf@kernel.org> <5862f649-8058-7e39-cb43-2a4b09303333@synopsys.com> <875zahp0i0.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875zahp0i0.fsf@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020, Felipe Balbi wrote: > Minas Harutyunyan writes: > > > Hi Felipe, > > > > On 7/21/2020 1:43 PM, Felipe Balbi wrote: > >> Minas Harutyunyan writes: > >> > >>> On 7/15/2020 1:32 PM, Lee Jones wrote: > >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2 > >>>> value. Looks like this has been broken since > >>>> dwc2_gadget_wkup_alert_handler() was added back in 2018. > >>>> > >>>> Also fixes the following W=1 warning: > >>>> > >>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’: > >>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable] > >>>> 259 | u32 gintmsk2; > >>>> | ^~~~~~~~ > >>>> > >>>> Cc: Minas Harutyunyan > >>>> Cc: Ben Dooks > >>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt") > >>>> Signed-off-by: Lee Jones > >>> > >>> Acked-by: Minas Harutyunyan > >> > >> Should I apply the entire series or only 1/8? > >> > > In this series only 2 patches are related to dwc2, which I'm already Acked: > > > > [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 > > [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control > > register > > > > I can't acked other patches from this series, because they are not > > related to dwc2. > > heh, I saw that after sending the email, sorry :-) Also, all patches are already in -next, courtesy of Greg. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00, BODY_QUOTE_MALF_MSGID,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A9AC433E0 for ; Tue, 21 Jul 2020 11:54:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD64022482 for ; Tue, 21 Jul 2020 11:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zXhVrYXh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TgrGhm+v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD64022482 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gw9y6AP9yR70g2ydajfM3OMdwWJnETnUqLxtF79KGV0=; b=zXhVrYXhvf9KVkZFZINVD5Pmw 7mKng54ijNHrr9HhORmPJY/cOKnJNVoYfYYuLUt0SmgtvDz6NYipFT+RszJ6J7Q7BKJam6Pclujws Allwmn5k6mMswoF03xyoeltkdkU56X8yGXApUO40nq28yg05sJ4ERja/t+9juQfosY4msfYMUymFf FgBNBkCrfAJFfmmrvFNY0kVJ+iDwfeUYeT2nsULQlvWzg5/gGQMInm18VgKl2s13wKEflK+z5wSSx x5dRGUayGxXo/tbo3ahlmVJzYOoB9SS0ZZx9WlXDfTT7o//FYx7SarLItM6FM61e4Q2eNFlGr5wJR oKA8qHshQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxqpK-0005Iq-5p; Tue, 21 Jul 2020 11:52:54 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxqpG-0005IK-OU for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 11:52:52 +0000 Received: by mail-wr1-x444.google.com with SMTP id a15so5960647wrh.10 for ; Tue, 21 Jul 2020 04:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YZopNL5/8ANY4qnCt9+wKywvq9+QBDbxQFIaGJPGSkU=; b=TgrGhm+v1Mg3jVuL3BVaIhy8BL4lZKWs1CJ5bFyF8NCqc/f9wNyORftQhIAIS+awPP lXfjUjWffFMBQ2bsP4cZY1Kvkw1IR7iTvP/AeVPsgUtQPuf/ew4WV66IVqGxg59czy1/ 0hK9NHIXNYTuW0pWAP/TbkSXMR7X1C+GnBPEeK5VP1a06mrAejxwDn7uvoHrW5qMXraU VM/Xx8uECxzqCY48+v4TYcTNadfgAyqfTTPPZXZpBR8Ty4ZeeetMqIq3iRLUZ1P/eT2i +/YN/KGYQ+p6Cv2VDBkyV0d4+mhKQMWnvCkYPI75nGeG2dpPF3ImzwWb8hq4rZiOYjiN etyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YZopNL5/8ANY4qnCt9+wKywvq9+QBDbxQFIaGJPGSkU=; b=EYJvxQNf9Sy1GJCswhi2mRL+DThXy2GgXNbvA5m/dLnoCZwv0pszXyzrs3hElvIjs4 +62bg9NVOrWbPyh2hkw21nzVGgp8zoVb6rZGxyH+KG4IJdbVzzrQy1+2HK3DPs3XQMg0 E8ck80JPUlmOI8pnNJhXcSxUM+C4YRTspujKyrymrADIck8CBqQd/MFe3Irk06foSFHc /ai00XghuR2YGD72vDT+YANB/PY22G/ezYWJHyrx8McjYyWyO3qaJQgqoI827jb/sQT9 iL7NRCTWzsGLOiBFRRqrUFAPapYLj4x70coEpI7OQZLTYjHKRlD8VX+RBxt5vy3WerBk yp7A== X-Gm-Message-State: AOAM531dBfpGlpSDgjYgqXfJ1ARXFMKlWZZmv8cwlgwDc1p8S5orqEOg Un9m4ZrMPnDCKbJvlIDe3v97EQ== X-Google-Smtp-Source: ABdhPJzkuMo6BVRg+eIcLsNrunYrL7MrNDfMCxb56XFQ8NXNkSdiOirXEPWIr6xsfVjqdIMtGKLThA== X-Received: by 2002:a5d:490c:: with SMTP id x12mr13034598wrq.238.1595332368446; Tue, 21 Jul 2020 04:52:48 -0700 (PDT) Received: from dell ([2.27.167.94]) by smtp.gmail.com with ESMTPSA id s203sm3250315wms.32.2020.07.21.04.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2020 04:52:47 -0700 (PDT) Date: Tue, 21 Jul 2020 12:52:46 +0100 From: Lee Jones To: Felipe Balbi Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 Message-ID: <20200721115246.GE621928@dell> References: <20200715093209.3165641-1-lee.jones@linaro.org> <20200715093209.3165641-2-lee.jones@linaro.org> <566f2d65-1b5a-ed2a-f33f-516b66be2624@synopsys.com> <87blk9p5ia.fsf@kernel.org> <5862f649-8058-7e39-cb43-2a4b09303333@synopsys.com> <875zahp0i0.fsf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <875zahp0i0.fsf@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_075251_463294_B2731179 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , Minas Harutyunyan , "linux-kernel@vger.kernel.org" , Ben Dooks , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMSBKdWwgMjAyMCwgRmVsaXBlIEJhbGJpIHdyb3RlOgoKPiBNaW5hcyBIYXJ1dHl1 bnlhbiA8TWluYXMuSGFydXR5dW55YW5Ac3lub3BzeXMuY29tPiB3cml0ZXM6Cj4gCj4gPiBIaSBG ZWxpcGUsCj4gPgo+ID4gT24gNy8yMS8yMDIwIDE6NDMgUE0sIEZlbGlwZSBCYWxiaSB3cm90ZToK PiA+PiBNaW5hcyBIYXJ1dHl1bnlhbiA8TWluYXMuSGFydXR5dW55YW5Ac3lub3BzeXMuY29tPiB3 cml0ZXM6Cj4gPj4gCj4gPj4+IE9uIDcvMTUvMjAyMCAxOjMyIFBNLCBMZWUgSm9uZXMgd3JvdGU6 Cj4gPj4+PiBUaGUgdmFsdWUgb2J0YWluZWQgZnJvbSBHSU5UU1RTMiBzaG91bGQgYmUgbWFza2Vk IHdpdGggdGhlIEdJTlRNU0syCj4gPj4+PiB2YWx1ZS4gIExvb2tzIGxpa2UgdGhpcyBoYXMgYmVl biBicm9rZW4gc2luY2UKPiA+Pj4+IGR3YzJfZ2FkZ2V0X3drdXBfYWxlcnRfaGFuZGxlcigpIHdh cyBhZGRlZCBiYWNrIGluIDIwMTguCj4gPj4+Pgo+ID4+Pj4gQWxzbyBmaXhlcyB0aGUgZm9sbG93 aW5nIFc9MSB3YXJuaW5nOgo+ID4+Pj4KPiA+Pj4+ICAgIGRyaXZlcnMvdXNiL2R3YzIvZ2FkZ2V0 LmM6IEluIGZ1bmN0aW9uIOKAmGR3YzJfZ2FkZ2V0X3drdXBfYWxlcnRfaGFuZGxlcuKAmToKPiA+ Pj4+ICAgIGRyaXZlcnMvdXNiL2R3YzIvZ2FkZ2V0LmM6MjU5OjY6IHdhcm5pbmc6IHZhcmlhYmxl IOKAmGdpbnRtc2sy4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFi bGVdCj4gPj4+PiAgICAyNTkgfCB1MzIgZ2ludG1zazI7Cj4gPj4+PiAgICB8IF5+fn5+fn5+Cj4g Pj4+Pgo+ID4+Pj4gQ2M6IE1pbmFzIEhhcnV0eXVueWFuIDxobWluYXNAc3lub3BzeXMuY29tPgo+ ID4+Pj4gQ2M6IEJlbiBEb29rcyA8YmVuQHNpbXRlYy5jby51az4KPiA+Pj4+IEZpeGVzOiAxODdj NTI5OGExMjI5ICgidXNiOiBkd2MyOiBnYWRnZXQ6IEFkZCBoYW5kbGVyIGZvciBXa3VwQWxlcnQg aW50ZXJydXB0IikKPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxp bmFyby5vcmc+Cj4gPj4+Cj4gPj4+IEFja2VkLWJ5OiBNaW5hcyBIYXJ1dHl1bnlhbiA8aG1pbmFz QHN5bm9wc3lzLmNvbT4KPiA+PiAKPiA+PiBTaG91bGQgSSBhcHBseSB0aGUgZW50aXJlIHNlcmll cyBvciBvbmx5IDEvOD8KPiA+PiAKPiA+IEluIHRoaXMgc2VyaWVzIG9ubHkgMiBwYXRjaGVzIGFy ZSByZWxhdGVkIHRvIGR3YzIsIHdoaWNoIEknbSBhbHJlYWR5IEFja2VkOgo+ID4KPiA+IFtQQVRD SCB2MiAxLzhdIHVzYjogZHdjMjogZ2FkZ2V0OiBNYWtlIHVzZSBvZiBHSU5UTVNLMgo+ID4gW1BB VENIIHYyIDIvOF0gdXNiOiBkd2MyOiBnYWRnZXQ6IEF2b2lkIHBvaW50bGVzcyByZWFkIG9mIEVQ IGNvbnRyb2wgCj4gPiByZWdpc3Rlcgo+ID4KPiA+IEkgY2FuJ3QgYWNrZWQgb3RoZXIgcGF0Y2hl cyBmcm9tIHRoaXMgc2VyaWVzLCBiZWNhdXNlIHRoZXkgYXJlIG5vdCAKPiA+IHJlbGF0ZWQgdG8g ZHdjMi4KPiAKPiBoZWgsIEkgc2F3IHRoYXQgYWZ0ZXIgc2VuZGluZyB0aGUgZW1haWwsIHNvcnJ5 IDotKQoKQWxzbywgYWxsIHBhdGNoZXMgYXJlIGFscmVhZHkgaW4gLW5leHQsIGNvdXJ0ZXN5IG9m IEdyZWcuCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAt IERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBm b3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=