From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632EDC433E2 for ; Tue, 21 Jul 2020 13:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CF41207DD for ; Tue, 21 Jul 2020 13:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgGUNg7 (ORCPT ); Tue, 21 Jul 2020 09:36:59 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47180 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726412AbgGUNg7 (ORCPT ); Tue, 21 Jul 2020 09:36:59 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jxsRz-006B2n-IY; Tue, 21 Jul 2020 15:36:55 +0200 Date: Tue, 21 Jul 2020 15:36:55 +0200 From: Andrew Lunn To: Codrin Ciubotariu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, robh+dt@kernel.org, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node Message-ID: <20200721133655.GA1472201@lunn.ch> References: <20200721100234.1302910-1-codrin.ciubotariu@microchip.com> <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) > * decrement it before returning. > */ > of_node_put(child); > - > return of_mdiobus_register(bp->mii_bus, np); > } Please avoid white space changes like this. Otherwise this looks O.K. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9EEC433E2 for ; Tue, 21 Jul 2020 13:38:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E0E920792 for ; Tue, 21 Jul 2020 13:38:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PNA0+oFP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E0E920792 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TzbM9Jx/S6Ya7lp/6MGuTON3hmi10iRqPupj7Qis6a0=; b=PNA0+oFPqxsfpoR+a8jAZH1Aa khOWs/MsRqxifv4XtJ6lajZYFW/g9L2H4B7/BGtMYYNg22uDOcpOMHcdU4MwnuSNnNni0tL2X7iV5 YfnKmpS/qDxLKXxrrbvDjCLJjZhQb0XdN9TAyh86r1GVJYMvyIf7c1dTGaej5dkapTH1iEq1dTiPM ZEff4HGooknJpbLQecmSUraZaok7m3ZUCmTHVDi4yO8qvHNF24ecWCVW6FCFg8tEVjJJ8kCeOMbVn OKeSsamHvTeYcCDJQb0W7TUIrtvEXAxYFY05I9hO7vfCCamPgGCO9ZfBWkAiq/ErhWZwWBGXrAXg4 Ik20R8iRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxsS7-0003NL-W8; Tue, 21 Jul 2020 13:37:04 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxsS5-0003Mb-9I for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 13:37:02 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jxsRz-006B2n-IY; Tue, 21 Jul 2020 15:36:55 +0200 Date: Tue, 21 Jul 2020 15:36:55 +0200 From: Andrew Lunn To: Codrin Ciubotariu Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node Message-ID: <20200721133655.GA1472201@lunn.ch> References: <20200721100234.1302910-1-codrin.ciubotariu@microchip.com> <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_093701_327747_C75E807B X-CRM114-Status: UNSURE ( 5.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, kuba@kernel.org, claudiu.beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) > * decrement it before returning. > */ > of_node_put(child); > - > return of_mdiobus_register(bp->mii_bus, np); > } Please avoid white space changes like this. Otherwise this looks O.K. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel