From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D26C433E1 for ; Wed, 22 Jul 2020 07:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A12B206F5 for ; Wed, 22 Jul 2020 07:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728394AbgGVHLI (ORCPT ); Wed, 22 Jul 2020 03:11:08 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51584 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbgGVHLI (ORCPT ); Wed, 22 Jul 2020 03:11:08 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2B3751C0BF1; Wed, 22 Jul 2020 09:11:05 +0200 (CEST) Date: Wed, 22 Jul 2020 09:10:55 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Message-ID: <20200722071055.GA8984@amd> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210554.GC5966@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>+ ret =3D fwnode_property_read_u32_array(child, > >>+ "reg", > >>+ led_banks, > >>+ ret); > >Move this to subfunction to reduce the indentation? (Or, just refactor > >it somehow). >=20 > Actually I can just put it all on the same line since the 80 character > requirement is relaxed. No. You have too long and too complex function, with too many blocks inside each other. Please fix it. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8X5n8ACgkQMOfwapXb+vIx7QCeJ+80yzhE3zdJ33JsSBF1CbS9 i0EAn1cgjVdwOdcgTvETrwYx8ha/r9B5 =x2Vm -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA21C433E7 for ; Wed, 22 Jul 2020 07:12:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A42206F5 for ; Wed, 22 Jul 2020 07:12:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LvmkCxdt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A42206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gB5e/5X1n2Lzzfczijj1VExQVEQWbHnQS6iQiyojUj8=; b=LvmkCxdtFKdf959KnZNSt+yLJ vejfOyndBEx0ACbw5ZMlUEHXtz60qEuTM6A+FJyZfVK1Hjo5nP+nnqiWAlWyMnf3FyE+SWgI6G4jc ZMKX8s/2H1+PGY3H4w1MHvSiZnTWnQDs5k/xVKUvwmQ6y2YRrSvb6W2MqeQvY3BjBmbqbpGYS77jQ kv0y/Ap3WwfYdtvP7V1afnyEnMpKX46b+1gqKNm3ihaYYEtUeNoWOksUgsaHBO7W5gh8mvUJDJnbb zVLR0DuqnJLaK4w5neDTZVJN3stgkPmncDnOPKe87WOjmpumTS/oM4/fgx/vN4Fk4OuRgFI/6Cgi0 hsjUgm43A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy8uF-0003Wx-4o; Wed, 22 Jul 2020 07:11:11 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy8uC-0003VU-42 for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 07:11:09 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2B3751C0BF1; Wed, 22 Jul 2020 09:11:05 +0200 (CEST) Date: Wed, 22 Jul 2020 09:10:55 +0200 From: Pavel Machek To: Dan Murphy Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Message-ID: <20200722071055.GA8984@amd> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210554.GC5966@amd> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_031108_301294_D6344183 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Type: multipart/mixed; boundary="===============7337373093455048471==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7337373093455048471== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>+ ret =3D fwnode_property_read_u32_array(child, > >>+ "reg", > >>+ led_banks, > >>+ ret); > >Move this to subfunction to reduce the indentation? (Or, just refactor > >it somehow). >=20 > Actually I can just put it all on the same line since the 80 character > requirement is relaxed. No. You have too long and too complex function, with too many blocks inside each other. Please fix it. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8X5n8ACgkQMOfwapXb+vIx7QCeJ+80yzhE3zdJ33JsSBF1CbS9 i0EAn1cgjVdwOdcgTvETrwYx8ha/r9B5 =x2Vm -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- --===============7337373093455048471== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7337373093455048471==--