From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Bin Gao <bin.gao@linux.intel.com>
Subject: Re: [PATCH] gpio: wcove: Use irqchip template
Date: Wed, 22 Jul 2020 13:58:06 +0300 [thread overview]
Message-ID: <20200722105806.GV3703480@smile.fi.intel.com> (raw)
In-Reply-To: <840db56f-d041-6bac-fdca-3dd26152e313@redhat.com>
On Wed, Jul 22, 2020 at 10:57:08AM +0200, Hans de Goede wrote:
> On 7/17/20 5:19 PM, Linus Walleij wrote:
> > This makes the driver use the irqchip template to assign
> > properties to the gpio_irq_chip instead of using the
> > explicit calls to gpiochip_irqchip_add_nested() and
> > gpiochip_set_nested_irqchip(). The irqchip is instead
> > added while adding the gpiochip.
> >
> > Cc: Bin Gao <bin.gao@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > Same notices as on the Crystalcove: this one I actually
> > managed to compiletest properly.
>
> I've given this patch a test-run on a machine with the
> Whiskey Cove PMIC and with the caveat that I've not
> actually tested the GPIO IRQ functionality, since that
> does not seem to be used on any machines, I see no adverse
> side effects from this patch, so it is:
>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
Applied to my branch, thanks!
Same for Crystal Cove.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-22 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 15:19 [PATCH] gpio: wcove: Use irqchip template Linus Walleij
2020-07-22 8:57 ` Hans de Goede
2020-07-22 10:58 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722105806.GV3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bin.gao@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.