From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99D9C433DF for ; Wed, 22 Jul 2020 12:39:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9E8A206E3 for ; Wed, 22 Jul 2020 12:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbgGVMjo (ORCPT ); Wed, 22 Jul 2020 08:39:44 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:53308 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgGVMjo (ORCPT ); Wed, 22 Jul 2020 08:39:44 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7AB5E1C0BD8; Wed, 22 Jul 2020 14:39:41 +0200 (CEST) Date: Wed, 22 Jul 2020 14:39:41 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Message-ID: <20200722123941.GA3448@ucw.cz> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210554.GC5966@amd> <20200722071055.GA8984@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi! > > > > > + ret = fwnode_property_read_u32_array(child, > > > > > + "reg", > > > > > + led_banks, > > > > > + ret); > > > > Move this to subfunction to reduce the indentation? (Or, just refactor > > > > it somehow). > > > Actually I can just put it all on the same line since the 80 character > > > requirement is relaxed. > > No. > > > > You have too long and too complex function, with too many blocks > > inside each other. Please fix it. > > I will refactor Thank you. Pavel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB89C433DF for ; Wed, 22 Jul 2020 12:41:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E414420717 for ; Wed, 22 Jul 2020 12:41:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WndtsDFb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E414420717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KOvp4kG7V5wKKP7xCE4QuW/y6rixdnV0U/WMDVIyMms=; b=WndtsDFbg5MwOvIuzxtUEeVvZ Phc3jXvdRjPRc2e33WQTkGY8KiY9X+Ls1sqBZKxY9/whOLR5T7bkxfETqRtaThaF68t8y80nTQHeZ nyVrFjYmEZrJY41GHKRAVpy47e5eH+TbgT5gN6meUNaAwvYJYR5HrGg9IwjfsIgeK6qEr8St6So2E JNnNIpsWAyiLlcXbTFRxiPkSLbocxl8eLZPYnVr2mbJkwkDI1Vxkb6Th9viqoGvdtvWK6Fnyu9QTq 3UrbjAiVmOIMpd2UhipZg+OFQSaeeR0PB6/+uTKVT4gXyr0iG6ovKLVRa1YwwAPvrbJIqAL5nyZRr S0Oi8ewOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyE2E-0008U5-RE; Wed, 22 Jul 2020 12:39:46 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyE2C-0008TT-V0 for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 12:39:45 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7AB5E1C0BD8; Wed, 22 Jul 2020 14:39:41 +0200 (CEST) Date: Wed, 22 Jul 2020 14:39:41 +0200 From: Pavel Machek To: Dan Murphy Subject: Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver Message-ID: <20200722123941.GA3448@ucw.cz> References: <20200716182007.18389-1-dmurphy@ti.com> <20200716182007.18389-4-dmurphy@ti.com> <20200721210554.GC5966@amd> <20200722071055.GA8984@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_083945_115255_C8A09F2E X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! > > > > > + ret = fwnode_property_read_u32_array(child, > > > > > + "reg", > > > > > + led_banks, > > > > > + ret); > > > > Move this to subfunction to reduce the indentation? (Or, just refactor > > > > it somehow). > > > Actually I can just put it all on the same line since the 80 character > > > requirement is relaxed. > > No. > > > > You have too long and too complex function, with too many blocks > > inside each other. Please fix it. > > I will refactor Thank you. Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel