All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Hyun Kwon <hyun.kwon@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH 2/3] dmaengine: xilinx: dpdma: add missing kernel doc
Date: Wed, 22 Jul 2020 15:45:19 +0300	[thread overview]
Message-ID: <20200722124519.GG5833@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200718135201.191881-2-vkoul@kernel.org>

Hi Vinod,

Thank you for the patch.

On Sat, Jul 18, 2020 at 07:22:00PM +0530, Vinod Koul wrote:
> xilinx_dpdma_sw_desc_set_dma_addrs() documentation is missing describing
> 'xdev', so add it
> 
> drivers/dma/xilinx/xilinx_dpdma.c:313: warning: Function parameter or
> member 'xdev' not described in 'xilinx_dpdma_sw_desc_set_dma_addrs'
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 8e602378f2dc..430f3714f6a3 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -295,6 +295,7 @@ static inline void dpdma_set(void __iomem *base, u32 offset, u32 set)
>  
>  /**
>   * xilinx_dpdma_sw_desc_set_dma_addrs - Set DMA addresses in the descriptor
> + * @xdev: DPDMA device
>   * @sw_desc: The software descriptor in which to set DMA addresses
>   * @prev: The previous descriptor
>   * @dma_addr: array of dma addresses

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2020-07-22 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 13:51 [PATCH 1/3] dmaengine: xilinx: dpdma: remove comparison of unsigned expression Vinod Koul
2020-07-18 13:52 ` [PATCH 2/3] dmaengine: xilinx: dpdma: add missing kernel doc Vinod Koul
2020-07-22 12:45   ` Laurent Pinchart [this message]
2020-07-18 13:52 ` [PATCH 3/3] dmaengine: xilinx: dpdma: fix kernel doc format Vinod Koul
2020-07-22 13:11   ` Laurent Pinchart
2020-07-22 14:26     ` Vinod Koul
2020-07-22 14:51       ` Laurent Pinchart
2020-07-22 14:54         ` Vinod Koul
2020-07-22 16:18           ` Laurent Pinchart
2020-07-22 12:44 ` [PATCH 1/3] dmaengine: xilinx: dpdma: remove comparison of unsigned expression Laurent Pinchart
2020-07-22 14:25   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200722124519.GG5833@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hyun.kwon@xilinx.com \
    --cc=michal.simek@xilinx.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.