From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44B6C433DF for ; Wed, 22 Jul 2020 13:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6AA220674 for ; Wed, 22 Jul 2020 13:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732335AbgGVN1O (ORCPT ); Wed, 22 Jul 2020 09:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727825AbgGVN1O (ORCPT ); Wed, 22 Jul 2020 09:27:14 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 195D2C0619DC for ; Wed, 22 Jul 2020 06:27:14 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyEm5-0002P5-1w; Wed, 22 Jul 2020 15:27:09 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jyEm4-0005Hr-Fu; Wed, 22 Jul 2020 15:27:08 +0200 Date: Wed, 22 Jul 2020 15:27:08 +0200 From: Michael Tretter To: Amit Sunil Dhamne Cc: mturquette@baylibre.com, sboyd@codeaurora.org, sboyd@kernel.org, michal.simek@xilinx.com, mark.rutland@arm.com, linux-clk@vger.kernel.org, rajanv@xilinx.com, jollys@xilinx.com, tejasp@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rajan Vaja , Tejas Patel Subject: Re: [PATCH v2 2/3] clk: zynqmp: Use firmware specific divider clock flags Message-ID: <20200722132708.GD21264@pengutronix.de> References: <1595400932-303612-1-git-send-email-amit.sunil.dhamne@xilinx.com> <1595400932-303612-3-git-send-email-amit.sunil.dhamne@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1595400932-303612-3-git-send-email-amit.sunil.dhamne@xilinx.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:24:05 up 153 days, 20:54, 130 users, load average: 0.16, 0.13, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020 23:55:31 -0700, Amit Sunil Dhamne wrote: > From: Rajan Vaja > > Use ZynqMP specific divider clock flags instead of using CCF flags. > > Signed-off-by: Rajan Vaja > Signed-off-by: Tejas Patel > Signed-off-by: Amit Sunil Dhamne > --- > drivers/clk/zynqmp/clk-zynqmp.h | 9 +++++++++ > drivers/clk/zynqmp/divider.c | 16 +++++++++++++++- > 2 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/zynqmp/clk-zynqmp.h b/drivers/clk/zynqmp/clk-zynqmp.h > index 3cb6149..ec33525 100644 > --- a/drivers/clk/zynqmp/clk-zynqmp.h > +++ b/drivers/clk/zynqmp/clk-zynqmp.h > @@ -32,6 +32,15 @@ > /* do not gate, ever */ > #define ZYNQMP_CLK_IS_CRITICAL BIT(11) > > +/* Type Flags for divider clock */ > +#define ZYNQMP_CLK_DIVIDER_ONE_BASED BIT(0) > +#define ZYNQMP_CLK_DIVIDER_POWER_OF_TWO BIT(1) > +#define ZYNQMP_CLK_DIVIDER_ALLOW_ZERO BIT(2) > +#define ZYNQMP_CLK_DIVIDER_HIWORD_MASK BIT(3) > +#define ZYNQMP_CLK_DIVIDER_ROUND_CLOSEST BIT(4) > +#define ZYNQMP_CLK_DIVIDER_READ_ONLY BIT(5) > +#define ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO BIT(6) > + > enum topology_type { > TYPE_INVALID, > TYPE_MUX, > diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c > index 3ab57d9..86cb785 100644 > --- a/drivers/clk/zynqmp/divider.c > +++ b/drivers/clk/zynqmp/divider.c > @@ -320,7 +320,21 @@ struct clk_hw *zynqmp_clk_register_divider(const char *name, > /* struct clk_divider assignments */ > div->is_frac = !!((nodes->flag & CLK_FRAC) | > (nodes->custom_type_flag & CUSTOM_FLAG_CLK_FRAC)); > - div->flags = nodes->type_flag; > + div->flags = 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ONE_BASED) ? > + CLK_DIVIDER_ONE_BASED : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_POWER_OF_TWO) ? > + CLK_DIVIDER_POWER_OF_TWO : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ALLOW_ZERO) ? > + CLK_DIVIDER_ALLOW_ZERO : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_POWER_OF_TWO) ? > + CLK_DIVIDER_HIWORD_MASK : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ROUND_CLOSEST) ? > + CLK_DIVIDER_ROUND_CLOSEST : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_READ_ONLY) ? > + CLK_DIVIDER_READ_ONLY : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO) ? > + CLK_DIVIDER_MAX_AT_ZERO : 0; Add a helper function for converting the flags. Michael > div->hw.init = &init; > div->clk_id = clk_id; > div->div_type = nodes->type; > -- > 2.7.4 > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CB83C433E1 for ; Wed, 22 Jul 2020 13:28:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D725020674 for ; Wed, 22 Jul 2020 13:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FnfnqOdw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D725020674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3i0H/21i8bnbm/MWZC9hAhY0gfjRZtW195lq7fs0Imk=; b=FnfnqOdwNZQT4xgw0pltZv4RT dKiJQWK0dZbrbGd5cyPdnjzd6hHjauaXiqXf17/W4B4wQ+I6DRR0UlvlhFtuiSNlItTUH3Z/Dvhga 88bf+ojy6bewCeukBPVzqat+ak0Rk8vGrHxmU73V9hOEDZpyTU6V7YmlH3GetTc4n/pFI3bI03x30 UAzJ4+Y+JM0H/NadKSt1fgYWuso1c+R75vlTE9di/KDebwOLmhzJlknWUmdt29V7jBLw4kPHTjAQu Vhq8zMMcX2FHm5acBjU8j8XW+qjAz4ZzIyVqYNUGwh7c8NfAHhiNj/ZL8CurfwFECnZzk7uhBrvr/ COMr5xo5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyEmA-0005Nr-Cw; Wed, 22 Jul 2020 13:27:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyEm8-0005Mz-2R for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 13:27:12 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyEm5-0002P5-1w; Wed, 22 Jul 2020 15:27:09 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jyEm4-0005Hr-Fu; Wed, 22 Jul 2020 15:27:08 +0200 Date: Wed, 22 Jul 2020 15:27:08 +0200 From: Michael Tretter To: Amit Sunil Dhamne Subject: Re: [PATCH v2 2/3] clk: zynqmp: Use firmware specific divider clock flags Message-ID: <20200722132708.GD21264@pengutronix.de> References: <1595400932-303612-1-git-send-email-amit.sunil.dhamne@xilinx.com> <1595400932-303612-3-git-send-email-amit.sunil.dhamne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1595400932-303612-3-git-send-email-amit.sunil.dhamne@xilinx.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:24:05 up 153 days, 20:54, 130 users, load average: 0.16, 0.13, 0.15 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_092712_129723_884BFFC0 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Tejas Patel , Rajan Vaja , tejasp@xilinx.com, sboyd@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, jollys@xilinx.com, rajanv@xilinx.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 21 Jul 2020 23:55:31 -0700, Amit Sunil Dhamne wrote: > From: Rajan Vaja > > Use ZynqMP specific divider clock flags instead of using CCF flags. > > Signed-off-by: Rajan Vaja > Signed-off-by: Tejas Patel > Signed-off-by: Amit Sunil Dhamne > --- > drivers/clk/zynqmp/clk-zynqmp.h | 9 +++++++++ > drivers/clk/zynqmp/divider.c | 16 +++++++++++++++- > 2 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/zynqmp/clk-zynqmp.h b/drivers/clk/zynqmp/clk-zynqmp.h > index 3cb6149..ec33525 100644 > --- a/drivers/clk/zynqmp/clk-zynqmp.h > +++ b/drivers/clk/zynqmp/clk-zynqmp.h > @@ -32,6 +32,15 @@ > /* do not gate, ever */ > #define ZYNQMP_CLK_IS_CRITICAL BIT(11) > > +/* Type Flags for divider clock */ > +#define ZYNQMP_CLK_DIVIDER_ONE_BASED BIT(0) > +#define ZYNQMP_CLK_DIVIDER_POWER_OF_TWO BIT(1) > +#define ZYNQMP_CLK_DIVIDER_ALLOW_ZERO BIT(2) > +#define ZYNQMP_CLK_DIVIDER_HIWORD_MASK BIT(3) > +#define ZYNQMP_CLK_DIVIDER_ROUND_CLOSEST BIT(4) > +#define ZYNQMP_CLK_DIVIDER_READ_ONLY BIT(5) > +#define ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO BIT(6) > + > enum topology_type { > TYPE_INVALID, > TYPE_MUX, > diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c > index 3ab57d9..86cb785 100644 > --- a/drivers/clk/zynqmp/divider.c > +++ b/drivers/clk/zynqmp/divider.c > @@ -320,7 +320,21 @@ struct clk_hw *zynqmp_clk_register_divider(const char *name, > /* struct clk_divider assignments */ > div->is_frac = !!((nodes->flag & CLK_FRAC) | > (nodes->custom_type_flag & CUSTOM_FLAG_CLK_FRAC)); > - div->flags = nodes->type_flag; > + div->flags = 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ONE_BASED) ? > + CLK_DIVIDER_ONE_BASED : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_POWER_OF_TWO) ? > + CLK_DIVIDER_POWER_OF_TWO : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ALLOW_ZERO) ? > + CLK_DIVIDER_ALLOW_ZERO : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_POWER_OF_TWO) ? > + CLK_DIVIDER_HIWORD_MASK : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_ROUND_CLOSEST) ? > + CLK_DIVIDER_ROUND_CLOSEST : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_READ_ONLY) ? > + CLK_DIVIDER_READ_ONLY : 0; > + div->flags |= (nodes->type_flag & ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO) ? > + CLK_DIVIDER_MAX_AT_ZERO : 0; Add a helper function for converting the flags. Michael > div->hw.init = &init; > div->clk_id = clk_id; > div->div_type = nodes->type; > -- > 2.7.4 > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel