From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C393CC433E0 for ; Thu, 23 Jul 2020 19:21:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3C5520709 for ; Thu, 23 Jul 2020 19:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbgGWTVb (ORCPT ); Thu, 23 Jul 2020 15:21:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbgGWTVa (ORCPT ); Thu, 23 Jul 2020 15:21:30 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3BFCC0619DC for ; Thu, 23 Jul 2020 12:21:30 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5155111D69C3B; Thu, 23 Jul 2020 12:04:45 -0700 (PDT) Date: Thu, 23 Jul 2020 12:21:29 -0700 (PDT) Message-Id: <20200723.122129.55324289504423678.davem@davemloft.net> To: W_Armin@gmx.de Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/2] 8390: Miscellaneous cleanups From: David Miller In-Reply-To: <20200723183446.GA6772@mx-linux-amd> References: <20200723183446.GA6772@mx-linux-amd> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Jul 2020 12:04:45 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Armin Wolf Date: Thu, 23 Jul 2020 20:34:46 +0200 > Include necessary librarys. 'libraries' > @@ -64,7 +79,7 @@ const struct net_device_ops ei_netdev_ops = { > .ndo_get_stats = ei_get_stats, > .ndo_set_rx_mode = ei_set_multicast_list, > .ndo_validate_addr = eth_validate_addr, > - .ndo_set_mac_address = eth_mac_addr, > + .ndo_set_mac_address = eth_mac_addr, This has nothing to do with your change. > #ifdef CONFIG_NET_POLL_CONTROLLER > .ndo_poll_controller = ei_poll, > #endif > @@ -74,6 +89,7 @@ EXPORT_SYMBOL(ei_netdev_ops); > struct net_device *__alloc_ei_netdev(int size) > { > struct net_device *dev = ____alloc_ei_netdev(size); > + Neither does this.