All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: maxim,max11100 yaml conversion
Date: Thu, 23 Jul 2020 11:31:18 +0200	[thread overview]
Message-ID: <20200723093118.yxogewmcholhqxm3@uno.localdomain> (raw)
In-Reply-To: <20200722171224.989138-2-jic23@kernel.org>

Hi Jonathan,

On Wed, Jul 22, 2020 at 06:12:22PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Straight forward conversion for this SPI ADC.
> Added limits on spi-max-frequency from datasheet (0.1 to 4.8MHz)
>
> Cc: Jacopo Mondi <jacopo@jmondi.org>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  .../devicetree/bindings/iio/adc/max11100.txt  | 18 -------
>  .../bindings/iio/adc/maxim,max11100.yaml      | 49 +++++++++++++++++++
>  2 files changed, 49 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/max11100.txt b/Documentation/devicetree/bindings/iio/adc/max11100.txt
> deleted file mode 100644
> index b7f7177b8aca..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/max11100.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Maxim max11100 Analog to Digital Converter (ADC)
> -
> -Required properties:
> -  - compatible: Should be "maxim,max11100"
> -  - reg: the adc unit address
> -  - vref-supply: phandle to the regulator that provides reference voltage
> -
> -Optional properties:
> -  - spi-max-frequency: SPI maximum frequency
> -
> -Example:
> -
> -max11100: adc@0 {
> -        compatible = "maxim,max11100";
> -        reg = <0>;
> -        vref-supply = <&adc0_vref>;
> -        spi-max-frequency = <240000>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max11100.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max11100.yaml
> new file mode 100644
> index 000000000000..0cf87556ef82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max11100.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/maxim,max11100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX11100 ADC
> +
> +maintainers:
> +  - Jacopo Mondi <jacopo@jmondi.org>
> +
> +description: |
> +    Single channel 16 bit ADC with SPI interface.
> +
> +properties:
> +  compatible:
> +    const: maxim,max11100
> +
> +  reg:
> +    maxItems: 1
> +
> +  vref-supply:
> +    description: External reference, needed to establish input scaling.
> +
> +  spi-max-frequency:
> +    minimum: 100000
> +    maximum: 4800000
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - vref-supply
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "maxim,max11100";
> +            reg = <0>;
> +            vref-supply = <&adc_vref>;
> +            spi-max-frequency = <240000>;
> +        };
> +    };
> +...
> --
> 2.27.0
>

  reply	other threads:[~2020-07-23  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 17:12 [PATCH 0/3] dt-bindings: iio: adc: Maxim ADC yaml conversions Jonathan Cameron
2020-07-22 17:12 ` [PATCH 1/3] dt-bindings: iio: adc: maxim,max11100 yaml conversion Jonathan Cameron
2020-07-23  9:31   ` Jacopo Mondi [this message]
2020-07-23 21:21   ` Rob Herring
2020-08-01 16:38     ` Jonathan Cameron
2020-07-22 17:12 ` [PATCH 2/3] dt-bindings: iio: adc: maxim,max1118 " Jonathan Cameron
2020-07-23 21:21   ` Rob Herring
2020-07-22 17:12 ` [PATCH 3/3] dt-bindings: iio: adc: maxim,max9611 yaml conversions Jonathan Cameron
2020-07-23  9:30   ` Jacopo Mondi
2020-07-23 21:22   ` Rob Herring
2020-08-01 16:42     ` Jonathan Cameron
2020-07-22 17:18 ` [PATCH 0/3] dt-bindings: iio: adc: Maxim ADC " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723093118.yxogewmcholhqxm3@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akinobu.mita@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.