All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/12] package/gcr: fix gpg path
Date: Thu, 23 Jul 2020 09:44:22 +0200	[thread overview]
Message-ID: <20200723094422.2a35adb7@windsurf.home> (raw)
In-Reply-To: <20200723010810.3237608-2-aduskett@gmail.com>

Hello Adam,

Thanks for picking up the work on udisks!

On Wed, 22 Jul 2020 18:07:59 -0700
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> gnugpg2 does not create /usr/bin/gpg2, instead, /usr/bin/gpg2 is typically
> a symlink to /usr/bin/gpg.
> 
> Buildroot does not create this symlink, so this path is not valid.
> Change the path to /usr/bin/gpg to fix this issue.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Back when gcr was introduced in commit
ec069dcf54cc69c19701a69106acaffdd07023bf, it already had:

+GCR_CONF_ENV = ac_cv_path_GNUPG=/usr/bin/gpg2

so presumably this was working then.

So I think it is probably 86dfb429ae1770550beb49299ef08ef05605c190 that
broke that, as it changed the name of the binaries installed by the
gnupg2 package.

This is the kind of research I would like to see when doing such
changes: don't just fix the current situation, try to find out how we
ended up here, so that we understand since when the problem has been
occurring, whether we need to backport to LTS/stable, etc.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-07-23  7:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  1:07 [Buildroot] [PATCH 00/12] package/udisks: bump version to 2.9.0 aduskett at gmail.com
2020-07-23  1:07 ` [Buildroot] [PATCH 01/12] package/gcr: fix gpg path aduskett at gmail.com
2020-07-23  7:44   ` Thomas Petazzoni [this message]
2020-07-23  1:08 ` [Buildroot] [PATCH 02/12] package/libbytesize: new package aduskett at gmail.com
2020-07-23  7:54   ` Thomas Petazzoni
2020-07-23  1:08 ` [Buildroot] [PATCH 03/12] package/volume-key: " aduskett at gmail.com
2020-07-23  8:58   ` Thomas Petazzoni
2020-07-23  1:08 ` [Buildroot] [PATCH 04/12] package/libblockdev: " aduskett at gmail.com
2020-07-23  8:57   ` Thomas Petazzoni
2020-07-23  1:08 ` [Buildroot] [PATCH 05/12] package/libblockdev: add cryptography support aduskett at gmail.com
2020-07-23 12:06   ` Thomas Petazzoni
2020-07-23  1:08 ` [Buildroot] [PATCH 06/12] package/libblockdev: add fs plugin support aduskett at gmail.com
2020-07-23  1:08 ` [Buildroot] [PATCH 07/12] package/spidermonkey: add host variant aduskett at gmail.com
2020-07-23  1:08 ` [Buildroot] [PATCH 08/12] package/polkit: " aduskett at gmail.com
2020-07-23  1:08 ` [Buildroot] [PATCH 09/12] package/udisks/Config.in: alphabatize package selection aduskett at gmail.com
2020-07-23  1:08 ` [Buildroot] [PATCH 10/12] package/udisks: bump version to 2.9.0 aduskett at gmail.com
2020-07-23  1:08 ` [Buildroot] [PATCH 11/12] package/libblockdev: add gobject-introspection support aduskett at gmail.com
2020-07-23 12:08   ` Thomas Petazzoni
2020-07-23  1:08 ` [Buildroot] [PATCH 12/12] package/udisks: " aduskett at gmail.com
2020-07-23  7:47 ` [Buildroot] [PATCH 00/12] package/udisks: bump version to 2.9.0 Thomas Petazzoni
2020-07-23 14:31 ` Thomas Petazzoni
2020-07-23 16:54   ` Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723094422.2a35adb7@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.