From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6DDEC433E0 for ; Thu, 23 Jul 2020 09:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33A9D20709 for ; Thu, 23 Jul 2020 09:50:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intenta.de header.i=@intenta.de header.b="wyRq9SX7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgGWJug (ORCPT ); Thu, 23 Jul 2020 05:50:36 -0400 Received: from mail.intenta.de ([178.249.25.132]:43888 "EHLO mail.intenta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgGWJug (ORCPT ); Thu, 23 Jul 2020 05:50:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=intenta.de; s=dkim1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:CC:To:From:Date; bh=DTpO2wSxcH/F8/ps/tsSTU3i0/beUuu607Y/JU3khSg=; b=wyRq9SX7gnl/eqjBXhZz2MngmWJAo+/KjR8zanUzaR1R/TJDRlKTQU7oZhuyMroTZ9mXXruxM57gRVv35xmpUbJMgH/8i80Zrzg4J19bsufIyGYOhngrcdoSUenJFENPgskQmikSqfXkiEccug9/L188X2v1NJ9R+hJoG8E0l4w2ypFx96oZvrVDjnSaYWtDB9/FlUvzNpPE869qLK/sslHdzMv3oFRnOj1crmw8TBlkh9KyWckYvy6DlAplPjAK0uqcvTtcSmStPt2nzCUMN6PCcZadexY1AvQrTZwoB7y/jPPP+Zp8GCZcEqyBb+ixqD91LGtWaKGmvqeyEfcf+w==; Date: Thu, 23 Jul 2020 11:50:30 +0200 From: Helmut Grohne To: Michal Simek CC: Greg Kroah-Hartman , Jiri Slaby , Shubhrajyoti Datta , "Jan Kiszka" , "linux-serial@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment Message-ID: <20200723095030.GA23929@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> <20200713121019.GA6920@laureti-dev> <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ICSMA002.intenta.de (10.10.16.48) To ICSMA002.intenta.de (10.10.16.48) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hi Michal, On Wed, Jul 22, 2020 at 09:14:40AM +0200, Michal Simek wrote: > On 13. 07. 20 14:10, Helmut Grohne wrote: > > Can we maybe trim down the matrix somehow? In my context, the need for > > swapping the serial aliases arises from a limitation in u-boot-xlnx and > > the desire to use one dtb for both linux and u-boot. It requires that > > the serial0 alias is the console. Are there other reasons to swap them? > > If not, maybe fixing u-boot would be an option? > > I am not aware about any limitation in u-boot in this space. U-Boot is > working with aliases and also with stdout-patch selection. > Can you please elaborate more on this? I have retested this (with more recent versions than earlier). I confirm that u-boot correctly deals with aliases and chosen/stdout-path. Using linear aliases and assigning stdout to serial1 works. I also confirm that having ttyPS1 without having ttyPS0 works (only tested with this patch applied). I questioned this earlier. So it seems that the need for reversing these aliases is less strong now. If I remember correctly, Jan Kiszka was also using reversed aliases, but I don't know why. Helmut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4386FC433E8 for ; Thu, 23 Jul 2020 09:52:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1353F2084D for ; Thu, 23 Jul 2020 09:52:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tthjh5du"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intenta.de header.i=@intenta.de header.b="wyRq9SX7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1353F2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intenta.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AaDFNE9u8Q4E4kvXawAQMDpyi0yrmfo7il7NcRn2iFQ=; b=Tthjh5duA8UdbPVKA6APKI9cd /E9ieT7Rlb1aFg36h5lmu5WA8BvQcnToY4WAzj67VvoRVbCtWXf6rG3+663m2xaODiIw5g77pbMI2 ijAav1RTOgI/KCeILc2FLX8nQB8+W2vGSSwtqS3C6CP74lY4BpQ67CZwLtitI9qbuoOAUqkkj1Khs RfEYVjfoA1GvFN9tSnus2XZUMhuH04ITtY8Xt/KBneSbMosjE5NuBlya13y0Y/m7H1TvwTJSsyXgz 6/RnUIOarbfXNbqiLPOzyRwn+vcoNRnwUHvQL7rOWRkIBWoRyOYTgNjjYhgjhS4kVsXd3OfkVc14T 3w0lNTJlA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXsC-0001Xn-IG; Thu, 23 Jul 2020 09:50:44 +0000 Received: from mail.intenta.de ([178.249.25.132]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXs9-0001Wi-2U for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 09:50:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=intenta.de; s=dkim1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:CC:To:From:Date; bh=DTpO2wSxcH/F8/ps/tsSTU3i0/beUuu607Y/JU3khSg=; b=wyRq9SX7gnl/eqjBXhZz2MngmWJAo+/KjR8zanUzaR1R/TJDRlKTQU7oZhuyMroTZ9mXXruxM57gRVv35xmpUbJMgH/8i80Zrzg4J19bsufIyGYOhngrcdoSUenJFENPgskQmikSqfXkiEccug9/L188X2v1NJ9R+hJoG8E0l4w2ypFx96oZvrVDjnSaYWtDB9/FlUvzNpPE869qLK/sslHdzMv3oFRnOj1crmw8TBlkh9KyWckYvy6DlAplPjAK0uqcvTtcSmStPt2nzCUMN6PCcZadexY1AvQrTZwoB7y/jPPP+Zp8GCZcEqyBb+ixqD91LGtWaKGmvqeyEfcf+w==; Date: Thu, 23 Jul 2020 11:50:30 +0200 From: Helmut Grohne To: Michal Simek Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment Message-ID: <20200723095030.GA23929@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> <20200713121019.GA6920@laureti-dev> <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ICSMA002.intenta.de (10.10.16.48) To ICSMA002.intenta.de (10.10.16.48) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_055041_385810_275C826E X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Shubhrajyoti Datta , Jan Kiszka , "linux-serial@vger.kernel.org" , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, On Wed, Jul 22, 2020 at 09:14:40AM +0200, Michal Simek wrote: > On 13. 07. 20 14:10, Helmut Grohne wrote: > > Can we maybe trim down the matrix somehow? In my context, the need for > > swapping the serial aliases arises from a limitation in u-boot-xlnx and > > the desire to use one dtb for both linux and u-boot. It requires that > > the serial0 alias is the console. Are there other reasons to swap them? > > If not, maybe fixing u-boot would be an option? > > I am not aware about any limitation in u-boot in this space. U-Boot is > working with aliases and also with stdout-patch selection. > Can you please elaborate more on this? I have retested this (with more recent versions than earlier). I confirm that u-boot correctly deals with aliases and chosen/stdout-path. Using linear aliases and assigning stdout to serial1 works. I also confirm that having ttyPS1 without having ttyPS0 works (only tested with this patch applied). I questioned this earlier. So it seems that the need for reversing these aliases is less strong now. If I remember correctly, Jan Kiszka was also using reversed aliases, but I don't know why. Helmut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel