From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Date: Thu, 23 Jul 2020 10:49:05 -0400 Subject: [Cluster-devel] [PATCH dlm-next 1/4] fs: dlm: don't close socket on invalid message In-Reply-To: <20200723144908.271110-1-aahringo@redhat.com> References: <20200723144908.271110-1-aahringo@redhat.com> Message-ID: <20200723144908.271110-2-aahringo@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch doesn't close sockets when there is an invalid dlm message received. The connection will probably reconnect anyway so. To not close the connection will reduce the number of possible failtures. As we don't have a different strategy to react on such scenario just keep going the connection and ignore the message. Signed-off-by: Alexander Aring --- fs/dlm/lowcomms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 3fa1b93dbbc7e..ec7ed228a9843 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -690,8 +690,6 @@ static int receive_from_sock(struct connection *con) page_address(con->rx_page), con->cb.base, con->cb.len, r); } - if (ret < 0) - goto out_close; cbuf_eat(&con->cb, ret); if (cbuf_empty(&con->cb) && !call_again_soon) { -- 2.26.2