From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AABC433E0 for ; Thu, 23 Jul 2020 17:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7227820771 for ; Thu, 23 Jul 2020 17:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595525730; bh=GSSMRiJIUAIeqKlaLcyxa7JEAvAyR/o1/CAzVcNXGXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qyFl5/iCbi+uxjkg6sa/9XDVdUNFAoab6RF3XmyKpl4WYWPms+eMa/i8lXoXsS7d3 /7yFQqJnmFZUVrgm8k01rNOpB45wPZd/wY11RfxPjX2KslLwSpcibxhmj2lbgLH5YA CtUWcvzmSLWEQwuvRJRC7CItw7iEdYdlA+j89FLE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730006AbgGWRfa (ORCPT ); Thu, 23 Jul 2020 13:35:30 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:39550 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbgGWRf3 (ORCPT ); Thu, 23 Jul 2020 13:35:29 -0400 Received: by mail-il1-f195.google.com with SMTP id k6so5025157ili.6; Thu, 23 Jul 2020 10:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EZcmuqlw+vI8279QgykP+SnxtQePgE6A/1MM/UJc1/I=; b=snHCWZ9/mAYwHaoXnX4LuW4aiIvBDbF1xq0uoK1khSBOAaXdDkTD1JbsFfxBXcoobF FfN07q9RSyrj7zwd6J6I58XBKL3GWtcX+ZLBzrcX/X3Z8FF2E9ed8mhgqn1pZhDohIVF IYwPeVBapa0pI4HY0qN8R693grN7h4gUxHFN6vmHfGf9F/N3dvH+89v1d82yAcdLdhZZ EXNdXQ1JJ1QrmwNWFow35x7e/Nz5xX4rx2No7sn0E6Opt+qxqNKR7pqo/rE+YC6DTco5 byFvGvm3M3Qlk87QhquCWTQOd4BF86/3zBLpXFnBMxPXJ6HEhbm6aVfMcL9LVwK1gpSB D06w== X-Gm-Message-State: AOAM533RloXNnGBceJFaQFN2zZzQ8chHshXxR5A+7j0MwTC8x7D7B1xQ nERqESmJM9C/myyndt8gbg== X-Google-Smtp-Source: ABdhPJz7uG1mV+jAbyXdvaIBTjENYt2s4YK7RlJI7ZsjxplwTXSBfl0YRixwUg/sAJMNR0Qtd5TmGg== X-Received: by 2002:a05:6e02:8e3:: with SMTP id n3mr6415331ilt.259.1595525728765; Thu, 23 Jul 2020 10:35:28 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id k8sm1846100ilk.11.2020.07.23.10.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 10:35:28 -0700 (PDT) Received: (nullmailer pid 579882 invoked by uid 1000); Thu, 23 Jul 2020 17:35:25 -0000 Date: Thu, 23 Jul 2020 11:35:25 -0600 From: Rob Herring To: Peter Chen Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, devicetree@vger.kernel.org, linux-imx@nxp.com, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy Message-ID: <20200723173525.GA576802@bogus> References: <20200717042226.18495-1-peter.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717042226.18495-1-peter.chen@nxp.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jul 17, 2020 at 12:22:23PM +0800, Peter Chen wrote: > Add two parameters which are used to tune USB signal for imx picophy, > picophy is used at imx7d, imx8mm, and imx8mn. > > Reviewed-by: Jun Li > Signed-off-by: Peter Chen > --- > No changes for v2. > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index 51376cbe5f3d..e9858dafb08f 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -100,6 +100,13 @@ i.mx specific properties > It's recommended to specify the over current polarity. > - power-active-high: power signal polarity is active high > - external-vbus-divider: enables off-chip resistor divider for Vbus > +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current Form is , and picophy is not a vendor. > + Control. This signal controls the amount of current sourced to the > + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. > + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. What's the range of values? What's the default if not specified? > +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment. > + Adjust the high-speed transmitter DC level voltage, details can refer > + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. Same comments here. > > Example: > > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1ADC433E0 for ; Thu, 23 Jul 2020 17:36:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AA1B20771 for ; Thu, 23 Jul 2020 17:36:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="twIA/4D8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AA1B20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FazE64XmFeZ/TIedZmf6QLAtfCSji4MUfLFQyXuNKW4=; b=twIA/4D8X/Vtpi8iAYskBM2t4 +UFbOV62QEJ1xP5IRTXd7sHUIh4JWo+lCmwHIfSndiYgcRKUFrgxTLRyXUnQfgIMTeVoOqOxGpvSC R1WNXye4g8Bljgetkui3ZLqEXw1YqJGm/Ynjjp1IpTQUisu+rn/yulCGwv4XAcraS6HVyeF51VzRf TA6mx2YzibqfGktWLGEYcnc1qZZmTfa47nn2/GEmsa0cTOsFH200ZkcN6jB5x9kz2s1nFLzsC8jjh x8P1+mGYSKIKP9d4l6vk8LLRmXCx72MXx/qHG2et5tRnqoEO0JWswveD7agoUkfF8wewNmxhDCvku fs0NfodzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyf80-0007wN-La; Thu, 23 Jul 2020 17:35:32 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyf7x-0007vf-Lu for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 17:35:30 +0000 Received: by mail-il1-f193.google.com with SMTP id a11so5043522ilk.0 for ; Thu, 23 Jul 2020 10:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EZcmuqlw+vI8279QgykP+SnxtQePgE6A/1MM/UJc1/I=; b=Mja/bMN/nrBZ8CvfwPun5XgjCpBY7XOH9CAMV6KPJWAp/YcXr1LsJ5mW3izUlZ3sIi yxJEcXYdn8IzosRkzlFA1V6l+q3O6JZh4in46yICXWVCM0w3sydE5ovaTCNta7dVmPpB +BnEaJhvjbzEfSxqqCxFF7XWvJrHq4+6jqKytm2QTBzj8JRQHUhp4CpEnA+d7+fevMIj 10DDCiW2z2b6XbxS617ezR8zvu3peY6I7GQUTgdANDvXMtcCUDDZLN9058/cAyrulEVr hwHen78yxBlBH4bg0bQb9eg2c5q9NBt2INmbLAcLLfkt5SGJDadR3nwLenEYBwD1ndR6 kAJg== X-Gm-Message-State: AOAM530jqXaDPL6PWXLZx0eIOgvpFJRdPmfV0jINblDUdaAVkTOiKz3b r8bZkxYAy9S5cLUmlG+9vA== X-Google-Smtp-Source: ABdhPJz7uG1mV+jAbyXdvaIBTjENYt2s4YK7RlJI7ZsjxplwTXSBfl0YRixwUg/sAJMNR0Qtd5TmGg== X-Received: by 2002:a05:6e02:8e3:: with SMTP id n3mr6415331ilt.259.1595525728765; Thu, 23 Jul 2020 10:35:28 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id k8sm1846100ilk.11.2020.07.23.10.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 10:35:28 -0700 (PDT) Received: (nullmailer pid 579882 invoked by uid 1000); Thu, 23 Jul 2020 17:35:25 -0000 Date: Thu, 23 Jul 2020 11:35:25 -0600 From: Rob Herring To: Peter Chen Subject: Re: [PATCH v2 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy Message-ID: <20200723173525.GA576802@bogus> References: <20200717042226.18495-1-peter.chen@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200717042226.18495-1-peter.chen@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_133529_734782_09F66E39 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 17, 2020 at 12:22:23PM +0800, Peter Chen wrote: > Add two parameters which are used to tune USB signal for imx picophy, > picophy is used at imx7d, imx8mm, and imx8mn. > > Reviewed-by: Jun Li > Signed-off-by: Peter Chen > --- > No changes for v2. > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index 51376cbe5f3d..e9858dafb08f 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -100,6 +100,13 @@ i.mx specific properties > It's recommended to specify the over current polarity. > - power-active-high: power signal polarity is active high > - external-vbus-divider: enables off-chip resistor divider for Vbus > +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current Form is , and picophy is not a vendor. > + Control. This signal controls the amount of current sourced to the > + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. > + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. What's the range of values? What's the default if not specified? > +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment. > + Adjust the high-speed transmitter DC level voltage, details can refer > + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. Same comments here. > > Example: > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel