From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BD6C433E8 for ; Thu, 23 Jul 2020 20:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E85862065F for ; Thu, 23 Jul 2020 20:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595535658; bh=FbxTYh0fWLjQ7Sjp/R5xOaVw+O8KPQCewwVWb3GHb1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xXgBlVhf834+F5cdM7AN6A4UyhmNatpmZTD2YcHGokNOr/jN6JLBbtsFl7fG2/nmN QXQXwMN3kS8zJFiA7iZM/MoRock0UtuaocP9nEuD71QRvWeDUrNxgOQaG/E0c+bhFd 3Ie8UhKllhtcg3aEvL2RGUcrEUiexnMUqAixxbus= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgGWUU4 (ORCPT ); Thu, 23 Jul 2020 16:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:36072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgGWUU4 (ORCPT ); Thu, 23 Jul 2020 16:20:56 -0400 Received: from localhost (p5486cde4.dip0.t-ipconnect.de [84.134.205.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CC6E2065F; Thu, 23 Jul 2020 20:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595535656; bh=FbxTYh0fWLjQ7Sjp/R5xOaVw+O8KPQCewwVWb3GHb1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wiDrhqxXFEBkyR6m/VPuaPmCl4ujg0haeXzw/xkPYLg3z3GLFf+gmTi1//Rg3F5YG OVTzSeM6GRIMJ2jvZ+8HLl8Z6yuoTEvruZq7jWIayMMCWTG2a1GHwpBErDvopRz/Hy OrAuSlaUupD2qQJWvPEpIotaKQNU1M/CzdCwfsJI= Date: Thu, 23 Jul 2020 22:20:53 +0200 From: Wolfram Sang To: Rayagonda Kokatanur Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Lori Hikichi , Robert Richter , Nishka Dasgupta , Andy Shevchenko , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] i2c: iproc: add slave pec support Message-ID: <20200723202053.GD908@ninjato> References: <20200717090155.10383-1-rayagonda.kokatanur@broadcom.com> <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline In-Reply-To: <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + /* Enable partial slave HW PEC support if requested by the client */ > + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC); > + if (iproc_i2c->en_s_pec) > + dev_info(iproc_i2c->device, "Enable PEC\n"); Where do you set the I2C_CLIENT_PEC flag for the slave? Is your backend code publicly available? I may need a second thought here, but I am not sure I2C_CLIENT_PEC is the right way to enable PEC. Isn't it actually depending on the backend if PEC is needed? I.e. is the backend an I2C device or an SMBus device? --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8Z8SUACgkQFA3kzBSg KbbvpBAAtQRmswxsOKcvCyMFVWcsW5AfEvAruqcfflu4znShCEhfrIQJ0ex22Yar wk20IjlcslcHYVA/9orCWd781sMa0BSmsvYLEpCdIKx+O3IJ7H4vOyVIwda2fcSv tMvgFAANNUV7/zEMhrvM8XRV0c86g19iMq8KtbprPGwX/bg2M4VQko8gmUcGBj4f g1q8x0HjbYCSlEViGTethpGqGK1I8tjWJDIKC4FvqLlU5Vqw8RqkExhHpOLrGEdU EHkJp1TyZkkJ4xgwWQTtHtr68HF2r9VI0pV/jMZRM/D0NZr9gYzT3wFr1OZ4aHYt Km/GLzSSjPjf/TWfO5uB2yLE3Ba15N9U+337L8md02v61ZJRSimyUQucTD661XOd u17HCu0/KLY8jCRvEEdoY6OMNcHZPjKJde4vRuW6o2iiIcuygcbaDUPrOfBuZDdl kwbktPNE3cdRsDX5Sayr1iV/gccDLg1VWaIzVnnWSaQpxBmpB79cQjarHmRnviJj N4VxoI5NW+XEc+eKcPRtFKedO78wj9QZmcPygbbFGEC0HMmCX7ciph6fAGE4aNvs 3NJgVPR+XS9GjVUhc/mL1oUuh3vP509cLWUK7PCGumOu2hEIPqI65SqEnKsFo40x CZH02zq7o5wfOEqZtREELmFr0olUhMlxFh8faiCsfEq941LsaCc= =eWxG -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA5EC433E5 for ; Thu, 23 Jul 2020 20:22:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEC6820792 for ; Thu, 23 Jul 2020 20:22:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b8biYf0R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wiDrhqxX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEC6820792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yYtjIBTRZA7/Ajrsrohw6UbveH5hlhNHdM9U6D+X2Kw=; b=b8biYf0Rt5xqDVq1bTN29bYI5 4wSBz4gx1wKU1TQS3efYvZAqwPWk8WTDBxQA7uxPqs4qIobkW1rGtJfXeYzAEx0oEDPaajuSyeckm JO9wFhfz907C0cktTZfs8GsxS5z7s/wB5oVVCm0nPrLOuEThWf6AzBvr4Jyu/KXM9h4ewDGGOSJUW QK6RWDqZ3zD4BzNi0w+uGZLJBOqD3QRX/5xL3XNm71iVzrJzdZlfZgfLGhIJn8zjg7LhdRwCP5QdU /z5QB83zF24U0lKSvVmCJUzJLQ8hVej9AjDvz/DOvsbHBvx2Dlrax7OuVo6YViHt1MAdvPkt/fZiQ IKv6P71vg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhi6-0004Kp-Ji; Thu, 23 Jul 2020 20:20:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyhi4-0004KJ-Ko for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 20:20:57 +0000 Received: from localhost (p5486cde4.dip0.t-ipconnect.de [84.134.205.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CC6E2065F; Thu, 23 Jul 2020 20:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595535656; bh=FbxTYh0fWLjQ7Sjp/R5xOaVw+O8KPQCewwVWb3GHb1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wiDrhqxXFEBkyR6m/VPuaPmCl4ujg0haeXzw/xkPYLg3z3GLFf+gmTi1//Rg3F5YG OVTzSeM6GRIMJ2jvZ+8HLl8Z6yuoTEvruZq7jWIayMMCWTG2a1GHwpBErDvopRz/Hy OrAuSlaUupD2qQJWvPEpIotaKQNU1M/CzdCwfsJI= Date: Thu, 23 Jul 2020 22:20:53 +0200 From: Wolfram Sang To: Rayagonda Kokatanur Subject: Re: [PATCH v2 2/2] i2c: iproc: add slave pec support Message-ID: <20200723202053.GD908@ninjato> References: <20200717090155.10383-1-rayagonda.kokatanur@broadcom.com> <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20200717090155.10383-3-rayagonda.kokatanur@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_162056_759683_F58CE9B8 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lori Hikichi , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Robert Richter , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, Nishka Dasgupta , Andy Shevchenko , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2784272911484741936==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2784272911484741936== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/3yNEOqWowh/8j+e" Content-Disposition: inline --/3yNEOqWowh/8j+e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + /* Enable partial slave HW PEC support if requested by the client */ > + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC); > + if (iproc_i2c->en_s_pec) > + dev_info(iproc_i2c->device, "Enable PEC\n"); Where do you set the I2C_CLIENT_PEC flag for the slave? Is your backend code publicly available? I may need a second thought here, but I am not sure I2C_CLIENT_PEC is the right way to enable PEC. Isn't it actually depending on the backend if PEC is needed? I.e. is the backend an I2C device or an SMBus device? --/3yNEOqWowh/8j+e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8Z8SUACgkQFA3kzBSg KbbvpBAAtQRmswxsOKcvCyMFVWcsW5AfEvAruqcfflu4znShCEhfrIQJ0ex22Yar wk20IjlcslcHYVA/9orCWd781sMa0BSmsvYLEpCdIKx+O3IJ7H4vOyVIwda2fcSv tMvgFAANNUV7/zEMhrvM8XRV0c86g19iMq8KtbprPGwX/bg2M4VQko8gmUcGBj4f g1q8x0HjbYCSlEViGTethpGqGK1I8tjWJDIKC4FvqLlU5Vqw8RqkExhHpOLrGEdU EHkJp1TyZkkJ4xgwWQTtHtr68HF2r9VI0pV/jMZRM/D0NZr9gYzT3wFr1OZ4aHYt Km/GLzSSjPjf/TWfO5uB2yLE3Ba15N9U+337L8md02v61ZJRSimyUQucTD661XOd u17HCu0/KLY8jCRvEEdoY6OMNcHZPjKJde4vRuW6o2iiIcuygcbaDUPrOfBuZDdl kwbktPNE3cdRsDX5Sayr1iV/gccDLg1VWaIzVnnWSaQpxBmpB79cQjarHmRnviJj N4VxoI5NW+XEc+eKcPRtFKedO78wj9QZmcPygbbFGEC0HMmCX7ciph6fAGE4aNvs 3NJgVPR+XS9GjVUhc/mL1oUuh3vP509cLWUK7PCGumOu2hEIPqI65SqEnKsFo40x CZH02zq7o5wfOEqZtREELmFr0olUhMlxFh8faiCsfEq941LsaCc= =eWxG -----END PGP SIGNATURE----- --/3yNEOqWowh/8j+e-- --===============2784272911484741936== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2784272911484741936==--