From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DB4C433E3 for ; Thu, 23 Jul 2020 20:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5D4C20714 for ; Thu, 23 Jul 2020 20:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595536634; bh=CsKh+uI8RBUAeguUCkreM+7Br+qPHthtVRn/SK0oVIM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xEpV6wQDUl5UJSuSiOshsbfhgFDitUonPgMGyYa1MdG6bUD9DMnMgzEg/0FFisRyt quOLkZ/IVyruV105nBwd0HKJV/JXd7hyNqB2rD5674OE8TcTbaCwb1i71/0defq9LM N3ptUbWMBpV3im0hL9FekkBFXskf73VCtO4uxya4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbgGWUhO (ORCPT ); Thu, 23 Jul 2020 16:37:14 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:46753 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgGWUhN (ORCPT ); Thu, 23 Jul 2020 16:37:13 -0400 Received: by mail-io1-f67.google.com with SMTP id a12so7648701ion.13; Thu, 23 Jul 2020 13:37:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6nkqz8zGOU3urYFWNeUbOdQOY3hcOTYFkmXK97Wy0sc=; b=lpng8KEhCeaVgJQ6RwE2sS+ShDzFrRs6EN2l9KRmxpE85bZQY1QKxoS8NdMLB7e/sB PruvC4Id2IHkLTlk08J7oUPjt43JjBG9x5UuhFLVzpwq7tprYH18J/D5JPUJJ5fMnEVj c38H3YIxuQzDcf9PCmdHqlcpFlbLtva39jYcd5FoowmG2Ners/lTqid9PpgZeOLYHTiJ 37urMaIM8X/2ww9SgEacQrPMUdtDeUo+POnbTqd6Lcy5cY1CHfHl24nMPy+KcIlFESW2 vGfuMeOyIVqO5C7Mtkw/eq9xc55kAPOuJ+Q54Ut718pxYkeHUKKAx4AcsymaoRsK0PgR PbMg== X-Gm-Message-State: AOAM533hv5RX5nbfmr5Eo7AWHEIgTxLuLyuhi8rImPfYW4FU/hGAkx9l xfn56r5bO+XlXigZlh35Bw== X-Google-Smtp-Source: ABdhPJyLxzJTOSuCRBbbSVeCMMXUCvUWmlkxvfC5/nxyt+iEdErKiX/49sT7x90v4qMwaYIbqsRHzw== X-Received: by 2002:a02:cc24:: with SMTP id o4mr6881649jap.105.1595536632720; Thu, 23 Jul 2020 13:37:12 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i6sm1997252ilj.61.2020.07.23.13.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 13:37:12 -0700 (PDT) Received: (nullmailer pid 819123 invoked by uid 1000); Thu, 23 Jul 2020 20:37:10 -0000 Date: Thu, 23 Jul 2020 14:37:10 -0600 From: Rob Herring To: Kurt Kanzenbach Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, devicetree@vger.kernel.org, Sebastian Andrzej Siewior , Richard Cochran , Kamil Alkhouri , ilias.apalodimas@linaro.org, Vladimir Oltean Subject: Re: [PATCH v2 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches Message-ID: <20200723203710.GA810197@bogus> References: <20200723081714.16005-1-kurt@linutronix.de> <20200723081714.16005-9-kurt@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200723081714.16005-9-kurt@linutronix.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 23, 2020 at 10:17:14AM +0200, Kurt Kanzenbach wrote: > Add basic documentation and example. > > Signed-off-by: Kurt Kanzenbach > --- > .../bindings/net/dsa/hellcreek.yaml | 126 ++++++++++++++++++ > 1 file changed, 126 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/dsa/hellcreek.yaml > > diff --git a/Documentation/devicetree/bindings/net/dsa/hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hellcreek.yaml > new file mode 100644 > index 000000000000..1b192ba7f4ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dsa/hellcreek.yaml > @@ -0,0 +1,126 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/dsa/hellcreek.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Hirschmann Hellcreek TSN Switch Device Tree Bindings > + > +allOf: > + - $ref: dsa.yaml# > + > +maintainers: > + - Andrew Lunn > + - Florian Fainelli > + - Vivien Didelot > + - Kurt Kanzenbach > + > +description: > + The Hellcreek TSN Switch IP is a 802.1Q Ethernet compliant switch. It supports > + the Precision Time Protocol, Hardware Timestamping as well the Time Aware > + Shaper. > + > +properties: > + compatible: > + oneOf: > + - const: hirschmann,hellcreek Don't need 'oneOf' for 1 entry. > + > + reg: > + description: > + The physical base address and size of TSN and PTP memory base > + minItems: 2 > + maxItems: 2 > + > + reg-names: > + description: > + Names of the physical base addresses No need for generic descriptions. That's all 'reg-names'... > + minItems: 2 > + maxItems: 2 > + items: > + enum: ["reg", "ptp"] Why not 'tsn' as above instead of reg? In any case, the correct form is: items: - const: reg - const: ptp > + > + leds: > + type: object > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + > + patternProperties: > + "^led@[0-9]+$": > + type: object > + description: Hellcreek leds This should reference leds/common.yaml > + > + properties: > + reg: > + items: > + - enum: [0, 1] > + description: Led number > + > + label: true > + > + default-state: true > + > + required: > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - reg-names > + - ports Use the preferred 'ethernet-ports'. > + - leds Add: unevaluatedProperties: false > + > +examples: > + - | > + switch0: switch@ff240000 { > + compatible = "hirschmann,hellcreek"; > + status = "okay"; Don't show status in examples. > + reg = <0xff240000 0x1000>, > + <0xff250000 0x1000>; > + reg-names = "reg", "ptp"; > + dsa,member = <0 0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "cpu"; > + ethernet = <&gmac0>; > + }; > + > + port@2 { > + reg = <2>; > + label = "lan0"; > + phy-handle = <&phy1>; > + }; > + > + port@3 { > + reg = <3>; > + label = "lan1"; > + phy-handle = <&phy2>; > + }; > + }; > + > + leds { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + label = "sync_good"; > + default-state = "on"; > + }; > + > + led@1 { > + reg = <1>; > + label = "is_gm"; > + default-state = "off"; > + }; > + }; > + }; > -- > 2.20.1 >