All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Jim Fehlig <jfehlig@suse.com>, ian.jackson@eu.citrix.com
Subject: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds
Date: Thu, 23 Jul 2020 15:31:34 -0600	[thread overview]
Message-ID: <20200723213134.11044-1-jfehlig@suse.com> (raw)

The check for XDR support was changed in libvirt commit d7147b3797
to use libtirpc pkg-config instead of complicated AC_CHECK_LIB,
AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been
failing since this change hit libvirt.git master. Fix it by adding
libtirpc-dev to the list of 'extra_packages' installed for libvirt
builds.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

I *think* this change will work for older libvirt branches too.
The old, hand-coded m4 logic should work with libtirpc-dev
installed.

 Osstest/Toolstack/libvirt.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index e817f5b4..11e4d730 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -26,7 +26,7 @@ use XML::LibXML;
 
 sub new {
     my ($class, $ho, $methname,$asset) = @_;
-    my @extra_packages = qw(libavahi-client3);
+    my @extra_packages = qw(libavahi-client3 libtirpc-dev);
     my $nl_lib = "libnl-3-200";
     my $libgnutls = "libgnutls30";
 
-- 
2.26.2



             reply	other threads:[~2020-07-23 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 21:31 Jim Fehlig [this message]
2020-08-10 10:13 ` [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds Ian Jackson
2020-08-10 14:26   ` Jim Fehlig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723213134.11044-1-jfehlig@suse.com \
    --to=jfehlig@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.