From: David Miller <davem@davemloft.net>
To: luobin9@huawei.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
luoxianjun@huawei.com, yin.yinshi@huawei.com,
cloud.wangxiaoyun@huawei.com, chiqijun@huawei.com
Subject: Re: [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event
Date: Fri, 24 Jul 2020 17:04:15 -0700 (PDT) [thread overview]
Message-ID: <20200724.170415.1190789583922952011.davem@davemloft.net> (raw)
In-Reply-To: <20200724091732.19819-2-luobin9@huawei.com>
From: Luo bin <luobin9@huawei.com>
Date: Fri, 24 Jul 2020 17:17:31 +0800
> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
> + struct devlink_fmsg *fmsg, void *priv_ctx,
> + struct netlink_ext_ack *extack)
> +{
> + int err;
> +
> + if (priv_ctx) {
> + err = mgmt_watchdog_report_show(fmsg, priv_ctx);
> + if (err)
> + return err;
> + }
> +
> + return 0;
> +}
As Edward Cree pointed out for v3 of this patch series, this 'err' is not
necessary at all.
next prev parent reply other threads:[~2020-07-25 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 9:17 [PATCH net-next v4 0/2] hinic: add some error messages for debug Luo bin
2020-07-24 9:17 ` [PATCH net-next v4 1/2] hinic: add support to handle hw abnormal event Luo bin
2020-07-25 0:04 ` David Miller [this message]
2020-07-25 1:19 ` luobin (L)
2020-07-24 9:17 ` [PATCH net-next v4 2/2] hinic: add log in exception handling processes Luo bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724.170415.1190789583922952011.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luobin9@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.