All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namjae Jeon <namjae.jeon@samsung.com>
To: gregkh@linuxfoundation.org, sashal@kernel.org
Cc: stable@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>
Subject: [PATCH 5.7.y 1/4] exfat: fix overflow issue in exfat_cluster_to_sector()
Date: Fri, 24 Jul 2020 09:15:41 +0900	[thread overview]
Message-ID: <20200724001544.30862-2-namjae.jeon@samsung.com> (raw)
In-Reply-To: <20200724001544.30862-1-namjae.jeon@samsung.com>

[ Upstream commit 43946b70494beefe40ec1b2ba4744c0f294d7736 ]

An overflow issue can occur while calculating sector in
exfat_cluster_to_sector(). It needs to cast clus's type to sector_t
before left shifting.

Fixes: 1acf1a564b60 ("exfat: add in-memory and on-disk structures and headers")
Cc: stable@vger.kernel.org # v5.7
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
 fs/exfat/exfat_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h
index d865050fa6cd..99e9baf2d31d 100644
--- a/fs/exfat/exfat_fs.h
+++ b/fs/exfat/exfat_fs.h
@@ -375,7 +375,7 @@ static inline bool exfat_is_last_sector_in_cluster(struct exfat_sb_info *sbi,
 static inline sector_t exfat_cluster_to_sector(struct exfat_sb_info *sbi,
 		unsigned int clus)
 {
-	return ((clus - EXFAT_RESERVED_CLUSTERS) << sbi->sect_per_clus_bits) +
+	return ((sector_t)(clus - EXFAT_RESERVED_CLUSTERS) << sbi->sect_per_clus_bits) +
 		sbi->data_start_sector;
 }
 
-- 
2.17.1


  parent reply	other threads:[~2020-07-24  0:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200724002112epcas1p24c54808617a5baddef4e4a2f49722866@epcas1p2.samsung.com>
2020-07-24  0:15 ` [PATCH 5.7.y 0/4] exfat stable patches for 5.7.y Namjae Jeon
     [not found]   ` <CGME20200724002121epcas1p31a4629c7cf9d3b342d18d8f5faf371e2@epcas1p3.samsung.com>
2020-07-24  0:15     ` Namjae Jeon [this message]
     [not found]   ` <CGME20200724002122epcas1p3611340519231e6d365a603bcec134e39@epcas1p3.samsung.com>
2020-07-24  0:15     ` [PATCH 5.7.y 2/4] exfat: fix wrong hint_stat initialization in exfat_find_dir_entry() Namjae Jeon
     [not found]   ` <CGME20200724002123epcas1p1ba65569ce62beb1ba94efb38907a798b@epcas1p1.samsung.com>
2020-07-24  0:15     ` [PATCH 5.7.y 3/4] exfat: fix wrong size update of stream entry by typo Namjae Jeon
     [not found]   ` <CGME20200724002124epcas1p2b7fe53394e20e4dccc23e61e2a82b828@epcas1p2.samsung.com>
2020-07-24  0:15     ` [PATCH 5.7.y 4/4] exfat: fix name_hash computation on big endian systems Namjae Jeon
2020-07-24  3:57   ` [PATCH 5.7.y 0/4] exfat stable patches for 5.7.y Sasha Levin
2020-07-24  4:00     ` Namjae Jeon
2020-07-24  9:42       ` Greg KH
     [not found]         ` <20200726082152epcms1p54e52279179cea382baf02c4616af315b@epcms1p5>
2020-07-26 14:47           ` FW: " Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724001544.30862-2-namjae.jeon@samsung.com \
    --to=namjae.jeon@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.