* [PATCH] ext4:remove some redundant function declarations
@ 2020-07-24 1:47 Shijie Luo
2020-07-24 2:58 ` Ritesh Harjani
0 siblings, 1 reply; 2+ messages in thread
From: Shijie Luo @ 2020-07-24 1:47 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, jack
ext4 update feature functions do not exist now, remove these useless
function declarations.
Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
---
fs/ext4/ext4.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 42f5060f3cdf..196b52c75422 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2924,12 +2924,6 @@ do { \
#endif
-extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
- __u32 compat);
-extern int ext4_update_rocompat_feature(handle_t *handle,
- struct super_block *sb, __u32 rocompat);
-extern int ext4_update_incompat_feature(handle_t *handle,
- struct super_block *sb, __u32 incompat);
extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
struct ext4_group_desc *bg);
extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4:remove some redundant function declarations
2020-07-24 1:47 [PATCH] ext4:remove some redundant function declarations Shijie Luo
@ 2020-07-24 2:58 ` Ritesh Harjani
0 siblings, 0 replies; 2+ messages in thread
From: Ritesh Harjani @ 2020-07-24 2:58 UTC (permalink / raw)
To: Shijie Luo, linux-ext4; +Cc: tytso, jack
On 7/24/20 7:17 AM, Shijie Luo wrote:
> ext4 update feature functions do not exist now, remove these useless
> function declarations.
>
> Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
LGTM, feel free to add:
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> fs/ext4/ext4.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 42f5060f3cdf..196b52c75422 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2924,12 +2924,6 @@ do { \
>
> #endif
>
> -extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
> - __u32 compat);
> -extern int ext4_update_rocompat_feature(handle_t *handle,
> - struct super_block *sb, __u32 rocompat);
> -extern int ext4_update_incompat_feature(handle_t *handle,
> - struct super_block *sb, __u32 incompat);
> extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
> struct ext4_group_desc *bg);
> extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-24 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 1:47 [PATCH] ext4:remove some redundant function declarations Shijie Luo
2020-07-24 2:58 ` Ritesh Harjani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.