All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>
Subject: Re: [PATCH v3 1/1] tpm: add sysfs exports for all banks of PCR registers
Date: Fri, 24 Jul 2020 09:57:45 +0300	[thread overview]
Message-ID: <20200724065745.GB1871046@linux.intel.com> (raw)
In-Reply-To: <20200722155739.26957-2-James.Bottomley@HansenPartnership.com>

On Wed, Jul 22, 2020 at 08:57:39AM -0700, James Bottomley wrote:
> use macro magic to create sysfs per hash groups with 24 PCR files in

'Use'

Please, just say what the patch does in plain English and dust the magic
away.

> them one for each possible agile hash of the TPM.  The files are
                                                   ~~

I'd prefer a single space.

> plugged in to a read function which is TPM version agnostic, so this
> works also for TPM 1.2 although the hash is only sha1 in that case.
> For every hash the TPM supports, a group named pcr-<hash> is created
> and each of the PCR read files placed under it.

Yeah, the commit message is missing the statement what it does and goes
straight away rationalizing "macro magic".

> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>

/Jarkko

  reply	other threads:[~2020-07-24  6:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 15:57 [PATCH v3 0/1] add sysfs exports for TPM 2 PCR registers James Bottomley
2020-07-22 15:57 ` [PATCH v3 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-07-24  6:57   ` Jarkko Sakkinen [this message]
2020-07-27  3:25     ` James Bottomley
2020-08-04 11:35       ` Mimi Zohar
2020-08-18  5:38       ` Jarkko Sakkinen
2020-07-27 15:08   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724065745.GB1871046@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.