From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD61AC433E3 for ; Fri, 24 Jul 2020 08:12:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8958920748 for ; Fri, 24 Jul 2020 08:12:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="Y6jIMlIg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="k6srkc7i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgGXIMP (ORCPT ); Fri, 24 Jul 2020 04:12:15 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:41331 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726437AbgGXIMP (ORCPT ); Fri, 24 Jul 2020 04:12:15 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8E5175C00C3; Fri, 24 Jul 2020 04:12:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 24 Jul 2020 04:12:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=l lMA+z5xxbFrYgBvQFXToJikEdxN9Z4xtWWma8Oxs28=; b=Y6jIMlIgg3LoDmF5/ NDpZM5XhL+hsGuNNoyGuLd47v+GGgFEtXP4CC2hpMrg/lNXVTJzEMuSEQ522oJvY E5uCdsS3boU9WGM9ZH9s9L42/Vj0Uet4Sql8W/AwTZXfuuvea636ToXdlHXeeu7/ 9rin4xGPPS04N6Pwv8RhT+hxV8Cn5T2muPW1nUYzcs4fPXNDzw5fQCwaJENjAJrv 3FIMi6IuMWGEo7Po3IrQe84HBNdILbgpvftJfvpMTCizS1JL/Hviajo5CZEDrN5j bF5E2fSkkkUsWsVUuw7UBsr2ayq//Tapk8n0TdXQu+606lRBX5pCjxeeEqo4wFEj t6q9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=llMA+z5xxbFrYgBvQFXToJikEdxN9Z4xtWWma8Oxs 28=; b=k6srkc7iotFmvhNup6obDys5ISJCFQ7f30//PVyqBEE3oXl5FJuQOeirq U6gS2oD+QcbmNT73cHGTCyiOgIm0yf/7spNuRQ8aTXSmGXlXNPow8WT+dMjj19Jz 3BGymHcMJxIn4qlhmeJE1t/ZfzXcXleUPFDeOrTGUpvz2b0uG6stB59oxhiKlUmc 5pWhaNOtZpNbTkFeuAlKzvxZEO1sDW0/2Opn+49Yy0jhNuhCXiNa/3nzaKlp8Qs3 7DVZVq/FtU8E0mjGJnicHA0jG39qKTnQdze5Eav0Qaxqj3gtc8N0lxbKhxYmXwYb B29zLEg5/DfihvRR5PtodHYkSD4zA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheefgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B7D93328005A; Fri, 24 Jul 2020 04:12:11 -0400 (EDT) Date: Fri, 24 Jul 2020 10:12:09 +0200 From: Maxime Ripard To: Frank Lee Cc: Frank Lee , Rob Herring , Chen-Yu Tsai , devicetree , Linux ARM , Linux Kernel Mailing List , =?utf-8?B?6buE54OB55Sf?= , liyong@allwinnertech.com Subject: Re: [PATCH v4 14/16] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file Message-ID: <20200724081209.d3b6tp2bfkhd63mv@gilmour.lan> References: <20200723165448.crdc4fc5jwqmsret@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 02:25:33PM +0800, Frank Lee wrote: > HI, >=20 > On Fri, Jul 24, 2020 at 12:54 AM Maxime Ripard wrote: > > > > Hi, > > > > On Tue, Jul 14, 2020 at 03:20:29PM +0800, Frank Lee wrote: > > > From: Yangtao Li > > > > > > Allwinner A100 is a new SoC with Cortex-A53 cores, this commit adds > > > the basical DTSI file of it, including the clock, i2c, pins, sid, ths, > > > nmi, and UART support. > > > > > > Signed-off-by: Yangtao Li > > > --- > > > .../arm64/boot/dts/allwinner/sun50i-a100.dtsi | 364 ++++++++++++++++= ++ > > > 1 file changed, 364 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/ar= m64/boot/dts/allwinner/sun50i-a100.dtsi > > > new file mode 100644 > > > index 000000000000..3fb2443f2121 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > > > @@ -0,0 +1,364 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > > +/* > > > + * Copyright (c) 2020 Yangtao Li > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/ { > > > + interrupt-parent =3D <&gic>; > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + > > > + cpus { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + cpu0: cpu@0 { > > > + compatible =3D "arm,armv8"; > > > > You should use the arm,cortex-a53 compatible here, arm,armv8 is for > > software models. > > > > > + sid@3006000 { > > > > The node name is supposed to be the class of the device, and the DT spec > > defines a list of them already. eeprom would be better suited here. >=20 > EFuse is more accurate? I missed that efuse got added. Yeah, it's definitely better Thanks! Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D7AC433E1 for ; Fri, 24 Jul 2020 08:13:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E117C20748 for ; Fri, 24 Jul 2020 08:13:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DLfDWYpv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="Y6jIMlIg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="k6srkc7i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E117C20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MaAoAlt6jcVTbpC/h0kO43VRgrZcKLXY1S/bvi+ESdw=; b=DLfDWYpvcOL21G1uAg/s2qjaJ EpC6B1PzGeHLn1OyMtOpVAZv5C6IukLzOLH9XxAKkd2UtBhz3eU+HZ0SMfzBgeNZ6ykr5VgaJYlpB Une6Ux81d82VcRx9MtnjFGDsxrwYPeGC2FRkJHtEAGdF2zbHWXLd9TMmTgTWSs6FCiv3oD4UuRIHd Jg5PULWFPTZqc8r+atrUbofxbUrSVUO7c6uGjUbp7CQ31wR8l7h5OmUYGBl2j+u7a3E7HHC+F+frm OUYoV9XqW19tnMWqT89bN8ytsKo8XMWEaFKqlKHZqtRM6bV8EPWd1RKYocTj6m81i12JiAJqYHE8a XCLD6p2Sg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jysoW-0004gy-Ej; Fri, 24 Jul 2020 08:12:20 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jysoU-0004gE-Ac for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 08:12:19 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8E5175C00C3; Fri, 24 Jul 2020 04:12:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 24 Jul 2020 04:12:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=l lMA+z5xxbFrYgBvQFXToJikEdxN9Z4xtWWma8Oxs28=; b=Y6jIMlIgg3LoDmF5/ NDpZM5XhL+hsGuNNoyGuLd47v+GGgFEtXP4CC2hpMrg/lNXVTJzEMuSEQ522oJvY E5uCdsS3boU9WGM9ZH9s9L42/Vj0Uet4Sql8W/AwTZXfuuvea636ToXdlHXeeu7/ 9rin4xGPPS04N6Pwv8RhT+hxV8Cn5T2muPW1nUYzcs4fPXNDzw5fQCwaJENjAJrv 3FIMi6IuMWGEo7Po3IrQe84HBNdILbgpvftJfvpMTCizS1JL/Hviajo5CZEDrN5j bF5E2fSkkkUsWsVUuw7UBsr2ayq//Tapk8n0TdXQu+606lRBX5pCjxeeEqo4wFEj t6q9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=llMA+z5xxbFrYgBvQFXToJikEdxN9Z4xtWWma8Oxs 28=; b=k6srkc7iotFmvhNup6obDys5ISJCFQ7f30//PVyqBEE3oXl5FJuQOeirq U6gS2oD+QcbmNT73cHGTCyiOgIm0yf/7spNuRQ8aTXSmGXlXNPow8WT+dMjj19Jz 3BGymHcMJxIn4qlhmeJE1t/ZfzXcXleUPFDeOrTGUpvz2b0uG6stB59oxhiKlUmc 5pWhaNOtZpNbTkFeuAlKzvxZEO1sDW0/2Opn+49Yy0jhNuhCXiNa/3nzaKlp8Qs3 7DVZVq/FtU8E0mjGJnicHA0jG39qKTnQdze5Eav0Qaxqj3gtc8N0lxbKhxYmXwYb B29zLEg5/DfihvRR5PtodHYkSD4zA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrheefgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B7D93328005A; Fri, 24 Jul 2020 04:12:11 -0400 (EDT) Date: Fri, 24 Jul 2020 10:12:09 +0200 From: Maxime Ripard To: Frank Lee Subject: Re: [PATCH v4 14/16] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file Message-ID: <20200724081209.d3b6tp2bfkhd63mv@gilmour.lan> References: <20200723165448.crdc4fc5jwqmsret@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_041218_427241_DAC50F81 X-CRM114-Status: GOOD ( 20.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , liyong@allwinnertech.com, Linux Kernel Mailing List , Chen-Yu Tsai , Rob Herring , =?utf-8?B?6buE54OB55Sf?= , Frank Lee , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 02:25:33PM +0800, Frank Lee wrote: > HI, > > On Fri, Jul 24, 2020 at 12:54 AM Maxime Ripard wrote: > > > > Hi, > > > > On Tue, Jul 14, 2020 at 03:20:29PM +0800, Frank Lee wrote: > > > From: Yangtao Li > > > > > > Allwinner A100 is a new SoC with Cortex-A53 cores, this commit adds > > > the basical DTSI file of it, including the clock, i2c, pins, sid, ths, > > > nmi, and UART support. > > > > > > Signed-off-by: Yangtao Li > > > --- > > > .../arm64/boot/dts/allwinner/sun50i-a100.dtsi | 364 ++++++++++++++++++ > > > 1 file changed, 364 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > > > new file mode 100644 > > > index 000000000000..3fb2443f2121 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a100.dtsi > > > @@ -0,0 +1,364 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > > +/* > > > + * Copyright (c) 2020 Yangtao Li > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/ { > > > + interrupt-parent = <&gic>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + > > > + cpus { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + cpu0: cpu@0 { > > > + compatible = "arm,armv8"; > > > > You should use the arm,cortex-a53 compatible here, arm,armv8 is for > > software models. > > > > > + sid@3006000 { > > > > The node name is supposed to be the class of the device, and the DT spec > > defines a list of them already. eeprom would be better suited here. > > EFuse is more accurate? I missed that efuse got added. Yeah, it's definitely better Thanks! Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel