Re: [PATCH RFC leds + net-next v2 1/1] net: phy: marvell: add support for PHY LEDs via LED class

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3206 bytes --]

Hi "Marek,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Marek-Beh-n/Add-support-for-LEDs-on-Marvell-PHYs/20200724-021441
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7fc3b978a8971305d456b32d3f2ac13191f5a0d7
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/phy/marvell.c:920:3: error: 'struct led_trigger' has no member named 'trigger_type'
     920 |  .trigger_type = &marvell_led_trigger_type,
         |   ^~~~~~~~~~~~
>> drivers/net/phy/marvell.c:920:18: warning: initialization of 'int' from 'struct led_hw_trigger_type *' makes integer from pointer without a cast [-Wint-conversion]
     920 |  .trigger_type = &marvell_led_trigger_type,
         |                  ^
   drivers/net/phy/marvell.c:920:18: note: (near initialization for 'marvell_hw_led_trigger.leddev_list_lock.raw_lock.<anonymous>.cnts.counter')
   drivers/net/phy/marvell.c:920:18: error: initializer element is not computable at load time
   drivers/net/phy/marvell.c:920:18: note: (near initialization for 'marvell_hw_led_trigger.leddev_list_lock.raw_lock.<anonymous>.cnts.counter')
   drivers/net/phy/marvell.c:916:52: warning: missing braces around initializer [-Wmissing-braces]
     916 | static struct led_trigger marvell_hw_led_trigger = {
         |                                                    ^
   ......
     920 |  .trigger_type = &marvell_led_trigger_type,
         |                  {{{{                     }}}}
   drivers/net/phy/marvell.c: In function 'marvell_register_led':
   drivers/net/phy/marvell.c:976:12: error: 'struct led_classdev' has no member named 'trigger_type'; did you mean 'trigger_lock'?
     976 |  led->cdev.trigger_type = &marvell_led_trigger_type;
         |            ^~~~~~~~~~~~
         |            trigger_lock
   drivers/net/phy/marvell.c: At top level:
   drivers/net/phy/marvell.c:688:35: error: storage size of 'marvell_led_trigger_type' isn't known
     688 | static struct led_hw_trigger_type marvell_led_trigger_type;
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~

vim +920 drivers/net/phy/marvell.c

   915	
   916	static struct led_trigger marvell_hw_led_trigger = {
   917		.name		= "hw-control",
   918		.activate	= marvell_led_trigger_activate,
   919		.deactivate	= marvell_led_trigger_deactivate,
 > 920		.trigger_type	= &marvell_led_trigger_type,
   921		.groups		= marvell_led_trig_groups,
   922	};
   923	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66261 bytes --]