From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD97C433E0 for ; Fri, 24 Jul 2020 10:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 558E92073E for ; Fri, 24 Jul 2020 10:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595586412; bh=rVdfRLF8yznNkp/wFEbFevU/Hg1CdRSyD1U/86auq+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0DAjt1pshWQpWl/YxisyAep8I4i+DSoHIaxO5q4TWYwkiH6QAJuOuu9W0zewfjUvC zS7nYXULPq3tTxShCJ9bC22nNgnfgrsLWxFVux/ZPeCxmeGeN8eqIliTa54Z5XyHiJ wW8Xct0H6YvDrV2/2luE62CZfwGyvPrdyvRPjb9w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgGXK0v (ORCPT ); Fri, 24 Jul 2020 06:26:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:58582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbgGXK0v (ORCPT ); Fri, 24 Jul 2020 06:26:51 -0400 Received: from kernel.org (unknown [87.71.40.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B46E2065C; Fri, 24 Jul 2020 10:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595586410; bh=rVdfRLF8yznNkp/wFEbFevU/Hg1CdRSyD1U/86auq+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ISuPeAIlsG5DP6x+uysiGR64wgnZiwHi2/PlNEX4EJ5gZ6a2BsFtRlWen7/jtskTJ zqgCfl/IgqzipJSfqA0TnF6HXBXuCj05y2wR8foas1wGZPtTOT79Aom/l7w1yeygpI LD3rcZMAX69m9q/i8RFTqTuldH+yKRQg1n51312A= Date: Fri, 24 Jul 2020 13:26:41 +0300 From: Mike Rapoport To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Masami Hiramatsu , Peter Zijlstra , Russell King , Will Deacon , Ard Biesheuvel , Mark Rutland , Steven Rostedt , Jessica Yu , linux-arch@vger.kernel.org Subject: Re: [PATCH v5 0/6] arch/x86: kprobes: Remove MODULES dependency Message-ID: <20200724102641.GC2831654@kernel.org> References: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724050553.1724168-1-jarkko.sakkinen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (cc people whi particpaged in v2 disuccsion) On Fri, Jul 24, 2020 at 08:05:47AM +0300, Jarkko Sakkinen wrote: > Remove MODULES dependency by migrating from module_alloc() to the new > text_alloc() API. Essentially these changes provide preliminaries for > allowing to compile a static kernel with a proper tracing support. > > The same API can be used later on in other sites that allocate space for > trampolines, and trivially scaled to other arch's. An arch can inform > with CONFIG_ARCH_HAS_TEXT_ALLOC that it's providing implementation for > text_alloc(). > > Cc: linux-mm@kvack.org > Cc: Andi Kleen > Cc: Masami Hiramatsu > Cc: Peter Zijlstra > > v4: > * Squash lock_modules() patches into one. > * Remove fallback versions of text_alloc() and text_free(). Instead, use > ARCH_HAS_TEXT_ALLOC at site when required. > * Use lockdep_assert_irqs_enabled() in text_free() instead of > WARN_ON(in_interrupt()). > > v3: > * Make text_alloc() API disjoint. > * Remove all the possible extra clutter not absolutely required and > split into more logical pieces. > > Jarkko Sakkinen (6): > kprobes: Remove dependency to the module_mutex > vmalloc: Add text_alloc() and text_free() > arch/x86: Implement text_alloc() and text_free() > arch/x86: kprobes: Use text_alloc() and text_free() > kprobes: Use text_alloc() and text_free() > kprobes: Remove CONFIG_MODULES dependency > > arch/Kconfig | 2 +- > arch/x86/Kconfig | 3 ++ > arch/x86/kernel/Makefile | 1 + > arch/x86/kernel/kprobes/core.c | 4 +-- > arch/x86/kernel/text_alloc.c | 41 +++++++++++++++++++++++ > include/linux/module.h | 32 ++++++++++++++---- > include/linux/vmalloc.h | 17 ++++++++++ > kernel/kprobes.c | 61 +++++++++++++++++++++++----------- > kernel/trace/trace_kprobe.c | 20 ++++++++--- > 9 files changed, 147 insertions(+), 34 deletions(-) > create mode 100644 arch/x86/kernel/text_alloc.c > > -- > 2.25.1 > -- Sincerely yours, Mike.