Re: [git pull] habanalabs pull request for kernel 5.9-rc1 (resend)

From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <oded.gabbay@gmail.com>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] habanalabs pull request for kernel 5.9-rc1 (resend)
Date: Fri, 24 Jul 2020 15:23:23 +0200	[thread overview]
Message-ID: <20200724132323.GA316746@kroah.com> (raw)
In-Reply-To: <CAFCwf10r4eqO=6B=C_iKt17XcY7oVuRDEJs5_x9Anw_5Djig6Q@mail.gmail.com>

On Fri, Jul 24, 2020 at 02:35:17PM +0300, Oded Gabbay wrote:
> On Fri, Jul 24, 2020 at 12:32 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Jul 23, 2020 at 10:15:25PM +0300, Oded Gabbay wrote:
> > > Hello Greg,
> > >
> > > (Re-sending this pull request)
> > >
> > > This is habanalabs pull request for the merge window of kernel 5.9. It
> > > contains many small improvements to common and GAUDI code. Details are in
> > > the tag.
> > >
> > > Thanks,
> > > Oded
> > >
> > > The following changes since commit 7a4462a96777b64b22412f782de226c90290bf75:
> > >
> > >   misc: rtsx: Use standard PCI definitions (2020-07-22 13:39:31 +0200)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-next-2020-07-23
> >
> > {sigh}
> >
> > Commit: 961a7325e670 ("habanalabs: Fix memory leak in error flow of context init")
> >         Fixes tag: Fixes: 786c94810698 ("habanalabs: Use pending cs amount per asic")
> >         Has these problem(s):
> >                 - Subject does not match target commit subject
> >                   Just use
> >                                 git log -1 --format='Fixes: %h ("%s")'
> >
> > The scripts I use to check this are here:
> >         https://github.com/gregkh/gregkh-linux/blob/master/work/verify_fixes.sh
> >         https://github.com/gregkh/gregkh-linux/blob/master/work/verify_signedoff.sh
> >
> > And note, if I ignore these errors, you will just get the same response
> > from Stephen when it hits linux-next :(
> >
> > thanks,
> >
> > greg k-h
> 
> I'm sorry for all the trouble Greg, but I wanted to ask before I send
> it again, won't the fixed sha-id be wrong once you merge this pull
> request to your tree ?

Nope, that's because I am using git to merge it.

> Because this patch fixes a previous patch in this pull-request.
> Maybe I should just squash them ?

That's up to you.  If it was a different author, perhaps keep them
separate, it's your call.

thanks,

greg k-h