All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: 杨帆 <yangfan.fan@bytedance.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>,
	Zhu Yanjun <yanjunz@mellanox.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [External] [PATCH] RDMA/rxe: fix retry forever when rnr_retry >= 7
Date: Fri, 24 Jul 2020 11:18:44 -0300	[thread overview]
Message-ID: <20200724141844.GO25301@ziepe.ca> (raw)
In-Reply-To: <827596D2-8EB2-4660-9118-70289FCD09AA@bytedance.com>

On Fri, Jul 24, 2020 at 10:04:01PM +0800, 杨帆 wrote:
> > 
> > Please read the following from IB specification
> > 
> 
> Oh I see, I missed that part.  Thanks for your explanation.
> 
> 
> > An exception to
> > the following is if the RNR NAK retry counter is set to 7. This value indicates
> > infinite retry and the counter is not decremented.
> 
> I wonder what if the user set RNR retry larger than 7?  Say the user set the RNR
> retry attribute to 10, is he expecting a 10-time retry or an infinite retry?  In
> the current implementation, any larger-than-7 retry count causes infinite retry.
> Is this an expected behavior?

Out of range values should be rejected at modify_qp time

Jason

  reply	other threads:[~2020-07-24 14:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 13:25 [PATCH] RDMA/rxe: fix retry forever when rnr_retry >= 7 Fan Yang
2020-07-23 15:42 ` Zhu Yanjun
2020-07-24 14:04   ` [External] " 杨帆
2020-07-24 14:18     ` Jason Gunthorpe [this message]
2020-07-24 14:20       ` Fan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724141844.GO25301@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yangfan.fan@bytedance.com \
    --cc=yanjunz@mellanox.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.